From: Kalle Valo <kvalo@codeaurora.org>
To: "Rafał Miłecki" <rafal@milecki.pl>
Cc: "James Hughes" <james.hughes@raspberrypi.org>,
"Arend van Spriel" <arend.vanspriel@broadcom.com>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
"Chi-Hsien Lin" <chi-hsien.lin@cypress.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Pieter-Paul Giesberts" <pieter-paul.giesberts@broadcom.com>,
brcm80211-dev-list.pdl@broadcom.com,
"Wright Feng" <wright.feng@cypress.com>,
"Felix Fietkau" <nbd@nbd.name>,
brcm80211-dev-list@cypress.com,
"Franky Lin" <franky.lin@broadcom.com>
Subject: Re: [Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default
Date: Wed, 14 Mar 2018 16:10:21 -0000 [thread overview]
Message-ID: <877eqe63kr.fsf@codeaurora.org> (raw)
In-Reply-To: <52b1812dd3e843adb63ff67fbe95975f@milecki.pl> ("Rafał Miłecki"'s message of "Wed, 14 Mar 2018 16:44:43 +0100")
Rafał Miłecki <rafal@milecki.pl> writes:
>>> + unsigned char *eth_data = skb_mac_header(skb) + ETH_HLEN;
>>> +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS)
>>
>> #ifndef?
>
> I followed what is used in the include/linux/etherdevice.h. Is that a
> good exceuse? Could it be there any some good reason for #if defined()?
Don't know, maybe just a matter of taste? But it would be nice to know
the background behind #ifdef vs #if defined(), never figured it out why
two different forms.
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: "Rafał Miłecki" <rafal@milecki.pl>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Arend van Spriel" <arend.vanspriel@broadcom.com>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Chi-Hsien Lin" <chi-hsien.lin@cypress.com>,
"Wright Feng" <wright.feng@cypress.com>,
"Pieter-Paul Giesberts" <pieter-paul.giesberts@broadcom.com>,
"James Hughes" <james.hughes@raspberrypi.org>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com, netdev@vger.kernel.org,
"Linus Lüssing" <linus.luessing@c0d3.blue>,
"Felix Fietkau" <nbd@nbd.name>,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default
Date: Wed, 14 Mar 2018 18:10:12 +0200 [thread overview]
Message-ID: <877eqe63kr.fsf@codeaurora.org> (raw)
In-Reply-To: <52b1812dd3e843adb63ff67fbe95975f@milecki.pl> ("Rafał Miłecki"'s message of "Wed, 14 Mar 2018 16:44:43 +0100")
Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl> writes:
>>> + unsigned char *eth_data =3D skb_mac_header(skb) + ETH_HLEN;
>>> +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS)
>>
>> #ifndef?
>
> I followed what is used in the include/linux/etherdevice.h. Is that a
> good exceuse? Could it be there any some good reason for #if defined()?
Don't know, maybe just a matter of taste? But it would be nice to know
the background behind #ifdef vs #if defined(), never figured it out why
two different forms.
--=20
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: "Rafał Miłecki" <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
Cc: "Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Arend van Spriel"
<arend.vanspriel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
"Franky Lin" <franky.lin-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
"Hante Meuleman"
<hante.meuleman-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
"Chi-Hsien Lin"
<chi-hsien.lin-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>,
"Wright Feng"
<wright.feng-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>,
"Pieter-Paul Giesberts"
<pieter-paul.giesberts-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
"James Hughes"
<james.hughes-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
brcm80211-dev-list.pdl-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
brcm80211-dev-list-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Linus Lüssing"
<linus.luessing-djzkFPsfvsizQB+pC5nmwQ@public.gmane.org>,
"Felix Fietkau" <nbd-Vt+b4OUoWG0@public.gmane.org>,
bridge-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default
Date: Wed, 14 Mar 2018 18:10:12 +0200 [thread overview]
Message-ID: <877eqe63kr.fsf@codeaurora.org> (raw)
In-Reply-To: <52b1812dd3e843adb63ff67fbe95975f-g1n6cQUeyibVItvQsEIGlw@public.gmane.org> ("Rafał Miłecki"'s message of "Wed, 14 Mar 2018 16:44:43 +0100")
Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org> writes:
>>> + unsigned char *eth_data = skb_mac_header(skb) + ETH_HLEN;
>>> +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS)
>>
>> #ifndef?
>
> I followed what is used in the include/linux/etherdevice.h. Is that a
> good exceuse? Could it be there any some good reason for #if defined()?
Don't know, maybe just a matter of taste? But it would be nice to know
the background behind #ifdef vs #if defined(), never figured it out why
two different forms.
--
Kalle Valo
next prev parent reply other threads:[~2018-03-14 16:10 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 11:01 [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default Rafał Miłecki
2018-03-14 11:01 ` [Bridge] " Rafał Miłecki
2018-03-14 11:01 ` Rafał Miłecki
2018-03-14 12:58 ` Arend van Spriel
2018-03-14 12:58 ` [Bridge] " Arend van Spriel
2018-03-14 12:58 ` Arend van Spriel
2018-03-14 15:39 ` Rafał Miłecki
2018-03-14 16:58 ` [Bridge] " Rafał Miłecki
2018-03-14 15:39 ` Rafał Miłecki
2018-03-14 15:40 ` Rafał Miłecki
2018-03-14 15:58 ` [Bridge] " Rafał Miłecki
2018-03-14 15:40 ` Rafał Miłecki
2018-03-14 15:57 ` Rafał Miłecki
2018-03-14 20:43 ` [Bridge] " Rafał Miłecki
2018-03-14 15:57 ` Rafał Miłecki
2018-03-14 20:44 ` Arend van Spriel
2018-03-14 20:44 ` [Bridge] " Arend van Spriel
2018-03-14 20:44 ` Arend van Spriel
2018-03-14 14:24 ` Kalle Valo
2018-03-14 14:24 ` [Bridge] " Kalle Valo
2018-03-14 14:24 ` Kalle Valo
2018-03-14 14:44 ` Arend van Spriel
2018-03-14 14:44 ` [Bridge] " Arend van Spriel
2018-03-14 14:44 ` Arend van Spriel
2018-03-14 15:08 ` Kalle Valo
2018-03-14 15:08 ` [Bridge] " Kalle Valo
2018-03-14 15:08 ` Kalle Valo
2018-03-14 15:27 ` [Bridge] " Stephen Hemminger
2018-03-14 15:27 ` Stephen Hemminger
2018-03-14 15:27 ` Stephen Hemminger
2018-03-14 15:28 ` Rafał Miłecki
2018-03-14 17:57 ` [Bridge] " Rafał Miłecki
2018-03-14 15:28 ` Rafał Miłecki
2018-03-14 15:44 ` Rafał Miłecki
2018-03-14 15:45 ` [Bridge] " Rafał Miłecki
2018-03-14 15:44 ` Rafał Miłecki
2018-03-14 16:10 ` Kalle Valo [this message]
2018-03-14 16:10 ` [Bridge] " Kalle Valo
2018-03-14 16:10 ` Kalle Valo
2018-03-14 20:55 ` Arend van Spriel
2018-03-14 20:55 ` [Bridge] " Arend van Spriel
2018-03-14 20:55 ` Arend van Spriel
2018-03-15 9:23 ` Kalle Valo
2018-03-15 9:23 ` [Bridge] " Kalle Valo
2018-03-15 9:23 ` Kalle Valo
2018-03-14 15:08 ` [Bridge] " Stephen Hemminger
2018-03-14 15:08 ` Stephen Hemminger
2018-03-14 15:08 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eqe63kr.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=bridge@lists.linux-foundation.org \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=james.hughes@raspberrypi.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pieter-paul.giesberts@broadcom.com \
--cc=rafal@milecki.pl \
--cc=wright.feng@cypress.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.