All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel.vetter@intel.com>, David Airlie <airlied@linux.ie>
Cc: Geliang Tang <geliangtang@163.com>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: fix compiler warnings in intel_audio.c
Date: Wed, 30 Sep 2015 17:35:59 +0300	[thread overview]
Message-ID: <877fn8c6uo.fsf@intel.com> (raw)
In-Reply-To: <d790b1084209de7808dc36f9e877d8a4a5631509.1443622788.git.geliangtang@163.com>

On Wed, 30 Sep 2015, Geliang Tang <geliangtang@163.com> wrote:
> Fix the following warnings:
>
>   CC      drivers/gpu/drm/i915/intel_audio.o
> drivers/gpu/drm/i915/intel_audio.c: In function ‘hsw_audio_codec_enable’:
> drivers/gpu/drm/i915/intel_audio.c:332:39: warning: passing argument 2 of ‘audio_rate_need_prog’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>   if (audio_rate_need_prog(intel_crtc, adjusted_mode)) {
>                                        ^
> drivers/gpu/drm/i915/intel_audio.c:147:13: note: expected ‘struct drm_display_mode *’ but argument is of type ‘const struct drm_display_mode *’
>  static bool audio_rate_need_prog(struct intel_crtc *crtc,
>              ^

Already fixed by Takashi:

http://mid.gmane.org/1443599103-26317-1-git-send-email-tiwai@suse.de

Thanks anyway,
Jani.


>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
>  drivers/gpu/drm/i915/intel_audio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index baadd90..72d696b 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -145,7 +145,7 @@ static uint32_t audio_config_setup_n_reg(int n, uint32_t val)
>  
>  /* check whether N/CTS/M need be set manually */
>  static bool audio_rate_need_prog(struct intel_crtc *crtc,
> -					struct drm_display_mode *mode)
> +				 const struct drm_display_mode *mode)
>  {
>  	if (((mode->clock == TMDS_297M) ||
>  		 (mode->clock == TMDS_296M)) &&
> -- 
> 2.5.0
>
>

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Geliang Tang <geliangtang@163.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: Geliang Tang <geliangtang@163.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915: fix compiler warnings in intel_audio.c
Date: Wed, 30 Sep 2015 17:35:59 +0300	[thread overview]
Message-ID: <877fn8c6uo.fsf@intel.com> (raw)
In-Reply-To: <d790b1084209de7808dc36f9e877d8a4a5631509.1443622788.git.geliangtang@163.com>

On Wed, 30 Sep 2015, Geliang Tang <geliangtang@163.com> wrote:
> Fix the following warnings:
>
>   CC      drivers/gpu/drm/i915/intel_audio.o
> drivers/gpu/drm/i915/intel_audio.c: In function ‘hsw_audio_codec_enable’:
> drivers/gpu/drm/i915/intel_audio.c:332:39: warning: passing argument 2 of ‘audio_rate_need_prog’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>   if (audio_rate_need_prog(intel_crtc, adjusted_mode)) {
>                                        ^
> drivers/gpu/drm/i915/intel_audio.c:147:13: note: expected ‘struct drm_display_mode *’ but argument is of type ‘const struct drm_display_mode *’
>  static bool audio_rate_need_prog(struct intel_crtc *crtc,
>              ^

Already fixed by Takashi:

http://mid.gmane.org/1443599103-26317-1-git-send-email-tiwai@suse.de

Thanks anyway,
Jani.


>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
>  drivers/gpu/drm/i915/intel_audio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index baadd90..72d696b 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -145,7 +145,7 @@ static uint32_t audio_config_setup_n_reg(int n, uint32_t val)
>  
>  /* check whether N/CTS/M need be set manually */
>  static bool audio_rate_need_prog(struct intel_crtc *crtc,
> -					struct drm_display_mode *mode)
> +				 const struct drm_display_mode *mode)
>  {
>  	if (((mode->clock == TMDS_297M) ||
>  		 (mode->clock == TMDS_296M)) &&
> -- 
> 2.5.0
>
>

-- 
Jani Nikula, Intel Open Source Technology Center

  reply	other threads:[~2015-09-30 14:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 14:22 [PATCH] drm/i915: fix compiler warnings in intel_audio.c Geliang Tang
2015-09-30 14:35 ` Jani Nikula [this message]
2015-09-30 14:35   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877fn8c6uo.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geliangtang@163.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.