All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 6/7] ath10k: fix device initialization routine
Date: Wed, 16 Oct 2013 16:31:42 +0300	[thread overview]
Message-ID: <877gdd735t.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1381858196-17000-7-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Tue, 15 Oct 2013 10:29:55 -0700")

Michal Kazior <michal.kazior@tieto.com> writes:

> Hardware revision 2 does not support cold reset
> correctly. As such it would sometimes lead to host
> machine freeze or data bus errors.
>
> The patch introduces warm reset function which is
> used instead of the cold reset one. It also moves
> the reset before interrupts are being set up to
> prevent any kind of spurious interrupts from being
> handled.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

[...]

> +	/* reset CE */
> +	addr = ar_pci->mem + RTC_SOC_BASE_ADDRESS + SOC_RESET_CONTROL_ADDRESS;
> +	val = ioread32(addr);
> +	val |= SOC_RESET_CONTROL_CE_RST_MASK;
> +	iowrite32(val, addr);
> +	val = ioread32(addr);
> +	msleep(10);
> +
> +	/* unreset CE */
> +	val &= ~SOC_RESET_CONTROL_CE_RST_MASK, addr;
> +	iowrite32(val, addr);

This looks wrong, I assume it was supposed to be this:

val &= ~SOC_RESET_CONTROL_CE_RST_MASK;

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 6/7] ath10k: fix device initialization routine
Date: Wed, 16 Oct 2013 16:31:42 +0300	[thread overview]
Message-ID: <877gdd735t.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1381858196-17000-7-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Tue, 15 Oct 2013 10:29:55 -0700")

Michal Kazior <michal.kazior@tieto.com> writes:

> Hardware revision 2 does not support cold reset
> correctly. As such it would sometimes lead to host
> machine freeze or data bus errors.
>
> The patch introduces warm reset function which is
> used instead of the cold reset one. It also moves
> the reset before interrupts are being set up to
> prevent any kind of spurious interrupts from being
> handled.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

[...]

> +	/* reset CE */
> +	addr = ar_pci->mem + RTC_SOC_BASE_ADDRESS + SOC_RESET_CONTROL_ADDRESS;
> +	val = ioread32(addr);
> +	val |= SOC_RESET_CONTROL_CE_RST_MASK;
> +	iowrite32(val, addr);
> +	val = ioread32(addr);
> +	msleep(10);
> +
> +	/* unreset CE */
> +	val &= ~SOC_RESET_CONTROL_CE_RST_MASK, addr;
> +	iowrite32(val, addr);

This looks wrong, I assume it was supposed to be this:

val &= ~SOC_RESET_CONTROL_CE_RST_MASK;

-- 
Kalle Valo

  reply	other threads:[~2013-10-16 13:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15 17:29 [PATCH 0/7] ath10k: fixes 2013-10-15 Michal Kazior
2013-10-15 17:29 ` Michal Kazior
2013-10-15 17:29 ` [PATCH 1/7] ath10k: prevent starting monitor without a vdev Michal Kazior
2013-10-15 17:29   ` Michal Kazior
2013-10-15 17:29 ` [PATCH 2/7] ath10k: add sanity checks for monitor management Michal Kazior
2013-10-15 17:29   ` Michal Kazior
2013-10-16  9:19   ` Kalle Valo
2013-10-16  9:19     ` Kalle Valo
2013-10-15 17:29 ` [PATCH 3/7] ath10k: fix endianess in prints Michal Kazior
2013-10-15 17:29   ` Michal Kazior
2013-10-15 17:29 ` [PATCH 4/7] ath10k: fix NSS reporting in RX Michal Kazior
2013-10-15 17:29   ` Michal Kazior
2013-10-15 17:29 ` [PATCH 5/7] ath10k: fix NULL deref upon early FW crash Michal Kazior
2013-10-15 17:29   ` Michal Kazior
2013-10-15 17:29 ` [PATCH 6/7] ath10k: fix device initialization routine Michal Kazior
2013-10-15 17:29   ` Michal Kazior
2013-10-16 13:31   ` Kalle Valo [this message]
2013-10-16 13:31     ` Kalle Valo
2013-10-15 17:29 ` [PATCH 7/7] ath10k: fix FW crashes on heavy TX on 10.1.389 AP FW Michal Kazior
2013-10-15 17:29   ` Michal Kazior
2013-10-15 18:55 ` [PATCH 0/7] ath10k: fixes 2013-10-15 Kalle Valo
2013-10-15 18:55   ` Kalle Valo
2013-10-16 12:56   ` Kalle Valo
2013-10-16 12:56     ` Kalle Valo
2013-10-16 14:05     ` Michal Kazior
2013-10-16 14:05       ` Michal Kazior
2013-10-16 14:18       ` Kalle Valo
2013-10-16 14:18         ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gdd735t.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.