From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 0/7] ath10k: fixes 2013-10-15
Date: Wed, 16 Oct 2013 15:56:22 +0300 [thread overview]
Message-ID: <87bo2p74sp.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <8761sybbye.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Tue, 15 Oct 2013 21:55:53 +0300")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
> Michal Kazior <michal.kazior@tieto.com> writes:
>
>> This is a bunch of fixes I've had queued up for
>> some time now. I was reluctant to send them
>> without some additional checks and because some of
>> the fixes are not ideal. At least we can get a
>> discussion going if anything raises any serious
>> concern.
>>
>>
>> Michal Kazior (7):
>> ath10k: prevent starting monitor without a vdev
>> ath10k: add sanity checks for monitor management
>> ath10k: fix endianess in prints
>> ath10k: fix NSS reporting in RX
>> ath10k: fix NULL deref upon early FW crash
>> ath10k: fix device initialization routine
>> ath10k: fix FW crashes on heavy TX on 10.1.389 AP FW
>
> I get few long line warnings:
>
> drivers/net/wireless/ath/ath10k/pci.c:1842: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/pci.c:1844: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/pci.c:1847: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/pci.c:1848: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/pci.c:1856: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/pci.c:1875: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/pci.c:1877: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/pci.c:1883: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/mac.c:2284: WARNING: line over 80 characters
Michal, if it's ok for you I'll submit v2 of this patchset. I'll fix the
long line warnings and also I do small cleanup to the warm reset code.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <linux-wireless@vger.kernel.org>, <ath10k@lists.infradead.org>
Subject: Re: [PATCH 0/7] ath10k: fixes 2013-10-15
Date: Wed, 16 Oct 2013 15:56:22 +0300 [thread overview]
Message-ID: <87bo2p74sp.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <8761sybbye.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Tue, 15 Oct 2013 21:55:53 +0300")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
> Michal Kazior <michal.kazior@tieto.com> writes:
>
>> This is a bunch of fixes I've had queued up for
>> some time now. I was reluctant to send them
>> without some additional checks and because some of
>> the fixes are not ideal. At least we can get a
>> discussion going if anything raises any serious
>> concern.
>>
>>
>> Michal Kazior (7):
>> ath10k: prevent starting monitor without a vdev
>> ath10k: add sanity checks for monitor management
>> ath10k: fix endianess in prints
>> ath10k: fix NSS reporting in RX
>> ath10k: fix NULL deref upon early FW crash
>> ath10k: fix device initialization routine
>> ath10k: fix FW crashes on heavy TX on 10.1.389 AP FW
>
> I get few long line warnings:
>
> drivers/net/wireless/ath/ath10k/pci.c:1842: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/pci.c:1844: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/pci.c:1847: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/pci.c:1848: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/pci.c:1856: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/pci.c:1875: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/pci.c:1877: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/pci.c:1883: WARNING: line over 80 characters
> drivers/net/wireless/ath/ath10k/mac.c:2284: WARNING: line over 80 characters
Michal, if it's ok for you I'll submit v2 of this patchset. I'll fix the
long line warnings and also I do small cleanup to the warm reset code.
--
Kalle Valo
next prev parent reply other threads:[~2013-10-16 12:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 17:29 [PATCH 0/7] ath10k: fixes 2013-10-15 Michal Kazior
2013-10-15 17:29 ` Michal Kazior
2013-10-15 17:29 ` [PATCH 1/7] ath10k: prevent starting monitor without a vdev Michal Kazior
2013-10-15 17:29 ` Michal Kazior
2013-10-15 17:29 ` [PATCH 2/7] ath10k: add sanity checks for monitor management Michal Kazior
2013-10-15 17:29 ` Michal Kazior
2013-10-16 9:19 ` Kalle Valo
2013-10-16 9:19 ` Kalle Valo
2013-10-15 17:29 ` [PATCH 3/7] ath10k: fix endianess in prints Michal Kazior
2013-10-15 17:29 ` Michal Kazior
2013-10-15 17:29 ` [PATCH 4/7] ath10k: fix NSS reporting in RX Michal Kazior
2013-10-15 17:29 ` Michal Kazior
2013-10-15 17:29 ` [PATCH 5/7] ath10k: fix NULL deref upon early FW crash Michal Kazior
2013-10-15 17:29 ` Michal Kazior
2013-10-15 17:29 ` [PATCH 6/7] ath10k: fix device initialization routine Michal Kazior
2013-10-15 17:29 ` Michal Kazior
2013-10-16 13:31 ` Kalle Valo
2013-10-16 13:31 ` Kalle Valo
2013-10-15 17:29 ` [PATCH 7/7] ath10k: fix FW crashes on heavy TX on 10.1.389 AP FW Michal Kazior
2013-10-15 17:29 ` Michal Kazior
2013-10-15 18:55 ` [PATCH 0/7] ath10k: fixes 2013-10-15 Kalle Valo
2013-10-15 18:55 ` Kalle Valo
2013-10-16 12:56 ` Kalle Valo [this message]
2013-10-16 12:56 ` Kalle Valo
2013-10-16 14:05 ` Michal Kazior
2013-10-16 14:05 ` Michal Kazior
2013-10-16 14:18 ` Kalle Valo
2013-10-16 14:18 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo2p74sp.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.