From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bartosz Markowski <bartosz.markowski@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: add SoC power save option to PCI features map
Date: Fri, 2 Aug 2013 10:47:44 +0300 [thread overview]
Message-ID: <877gg4pm8v.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1375348187-18216-1-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Thu, 1 Aug 2013 11:09:47 +0200")
Bartosz Markowski <bartosz.markowski@tieto.com> writes:
> Unify the PCI options location.
>
> By default the SoC PS option is disabled to boost the
> performance and due to poor stability on early HW revisions.
> In future we can remove the module parameter and turn on/off
> the PS for given hardware.
>
> This change also makes the pci module parameter for SoC PS static.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
A minor nitpick:
> + if (!test_bit(ATH10K_PCI_FEATURE_SOC_POWER_SAVE, ar_pci->features))
> + ath10k_do_pci_wake(ar); /* Force AWAKE forever */
if (foo)
/* comment */
function_call();
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bartosz Markowski <bartosz.markowski@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: add SoC power save option to PCI features map
Date: Fri, 2 Aug 2013 10:47:44 +0300 [thread overview]
Message-ID: <877gg4pm8v.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1375348187-18216-1-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Thu, 1 Aug 2013 11:09:47 +0200")
Bartosz Markowski <bartosz.markowski@tieto.com> writes:
> Unify the PCI options location.
>
> By default the SoC PS option is disabled to boost the
> performance and due to poor stability on early HW revisions.
> In future we can remove the module parameter and turn on/off
> the PS for given hardware.
>
> This change also makes the pci module parameter for SoC PS static.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
A minor nitpick:
> + if (!test_bit(ATH10K_PCI_FEATURE_SOC_POWER_SAVE, ar_pci->features))
> + ath10k_do_pci_wake(ar); /* Force AWAKE forever */
if (foo)
/* comment */
function_call();
--
Kalle Valo
next prev parent reply other threads:[~2013-08-02 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 9:09 [PATCH] ath10k: add SoC power save option to PCI features map Bartosz Markowski
2013-08-01 9:09 ` Bartosz Markowski
2013-08-02 7:47 ` Kalle Valo [this message]
2013-08-02 7:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gg4pm8v.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=bartosz.markowski@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.