From: Kevin Hilman <khilman@ti.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Tony Lindgren <tony@atomide.com>,
grant.likely@secretlab.ca, linus.walleij@stericsson.com,
tarun.kanti@ti.com
Subject: Re: [PATCH] gpio: omap: be more aggressive with pm_runtime
Date: Wed, 08 Feb 2012 16:01:42 -0800 [thread overview]
Message-ID: <877gzwyivt.fsf@ti.com> (raw)
In-Reply-To: <1328707614-20146-1-git-send-email-balbi@ti.com> (Felipe Balbi's message of "Wed, 8 Feb 2012 15:26:54 +0200")
Felipe Balbi <balbi@ti.com> writes:
> try to keep gpio block suspended as much as possible.
>
> Tested with pandaboard and a sysfs exported gpio.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
Looks like you need a few more get/puts around other places where
registers are accessed. It currently causes a boot crash on OMAP3 in
_set_gpio_triggering().
Did you test GPIO wakeups? both IO ring wakeups and GPIO module-level
wakeups?
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: omap: be more aggressive with pm_runtime
Date: Wed, 08 Feb 2012 16:01:42 -0800 [thread overview]
Message-ID: <877gzwyivt.fsf@ti.com> (raw)
In-Reply-To: <1328707614-20146-1-git-send-email-balbi@ti.com> (Felipe Balbi's message of "Wed, 8 Feb 2012 15:26:54 +0200")
Felipe Balbi <balbi@ti.com> writes:
> try to keep gpio block suspended as much as possible.
>
> Tested with pandaboard and a sysfs exported gpio.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
Looks like you need a few more get/puts around other places where
registers are accessed. It currently causes a boot crash on OMAP3 in
_set_gpio_triggering().
Did you test GPIO wakeups? both IO ring wakeups and GPIO module-level
wakeups?
Kevin
next prev parent reply other threads:[~2012-02-09 0:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 13:26 [PATCH] gpio: omap: be more aggressive with pm_runtime Felipe Balbi
2012-02-08 13:26 ` Felipe Balbi
2012-02-08 13:53 ` Felipe Balbi
2012-02-08 13:53 ` Felipe Balbi
2012-02-09 0:03 ` Kevin Hilman
2012-02-09 0:03 ` Kevin Hilman
2012-02-09 6:08 ` Felipe Balbi
2012-02-09 6:08 ` Felipe Balbi
2012-02-09 0:01 ` Kevin Hilman [this message]
2012-02-09 0:01 ` Kevin Hilman
2012-02-09 6:09 ` Felipe Balbi
2012-02-09 6:09 ` Felipe Balbi
2012-02-09 11:11 ` Felipe Balbi
2012-02-09 11:11 ` Felipe Balbi
2012-02-09 11:29 ` Felipe Balbi
2012-02-09 11:29 ` Felipe Balbi
2012-02-09 12:03 ` Grazvydas Ignotas
2012-02-09 12:03 ` Grazvydas Ignotas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gzwyivt.fsf@ti.com \
--to=khilman@ti.com \
--cc=balbi@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tarun.kanti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.