From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ferenc Fejes <ferenc.fejes@ericsson.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Gerhard Engleder <gerhard@engleder-embedded.com>,
UNGLinuxDriver@microchip.com,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>,
intel-wired-lan@lists.osuosl.org,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Pranavi Somisetty <pranavi.somisetty@amd.com>,
Jiri Pirko <jiri@resnulli.us>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Roger Quadros <rogerq@kernel.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
Harini Katakam <harini.katakam@amd.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jose Abreu <joabreu@synopsys.com>,
Oleksij Rempel <linux@rempel-privat.de>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net-next 1/5] net/sched: taprio: don't overwrite "sch" variable in taprio_dump_class_stats()
Date: Tue, 30 May 2023 15:33:02 -0700 [thread overview]
Message-ID: <878rd5v49t.fsf@intel.com> (raw)
In-Reply-To: <20230530213252.pddrmwgppneawmht@skbuf>
Vladimir Oltean <vladimir.oltean@nxp.com> writes:
> On Tue, May 30, 2023 at 02:14:17PM -0700, Vinicius Costa Gomes wrote:
>> But I have a suggestion, this "taprio_queue_get() ->
>> dev_queue->qdisc_sleeping()" dance should have the same result as
>> calling 'taprio_leaf()'.
>>
>> I am thinking of using taprio_leaf() here and in taprio_dump_class().
>> Could be a separate commit.
>
> Got it, you want to consolidate the dev_queue->qdisc_sleeping pattern.
> Since taprio_dump_class() could benefit from the consolidation too, they
> could really be both converted separately. Or I could also handle that
> in this patch set, if I need to resend it.
Exactly. Both options sound great.
Cheers,
--
Vinicius
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Kurt Kanzenbach <kurt@linutronix.de>,
Gerhard Engleder <gerhard@engleder-embedded.com>,
Amritha Nambiar <amritha.nambiar@intel.com>,
Ferenc Fejes <ferenc.fejes@ericsson.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Roger Quadros <rogerq@kernel.org>,
Pranavi Somisetty <pranavi.somisetty@amd.com>,
Harini Katakam <harini.katakam@amd.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>,
Oleksij Rempel <linux@rempel-privat.de>,
Jacob Keller <jacob.e.keller@intel.com>,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
intel-wired-lan@lists.osuosl.org,
Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Subject: Re: [PATCH net-next 1/5] net/sched: taprio: don't overwrite "sch" variable in taprio_dump_class_stats()
Date: Tue, 30 May 2023 15:33:02 -0700 [thread overview]
Message-ID: <878rd5v49t.fsf@intel.com> (raw)
In-Reply-To: <20230530213252.pddrmwgppneawmht@skbuf>
Vladimir Oltean <vladimir.oltean@nxp.com> writes:
> On Tue, May 30, 2023 at 02:14:17PM -0700, Vinicius Costa Gomes wrote:
>> But I have a suggestion, this "taprio_queue_get() ->
>> dev_queue->qdisc_sleeping()" dance should have the same result as
>> calling 'taprio_leaf()'.
>>
>> I am thinking of using taprio_leaf() here and in taprio_dump_class().
>> Could be a separate commit.
>
> Got it, you want to consolidate the dev_queue->qdisc_sleeping pattern.
> Since taprio_dump_class() could benefit from the consolidation too, they
> could really be both converted separately. Or I could also handle that
> in this patch set, if I need to resend it.
Exactly. Both options sound great.
Cheers,
--
Vinicius
next prev parent reply other threads:[~2023-05-30 22:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 9:19 [Intel-wired-lan] [PATCH net-next 0/5] xstats for tc-taprio Vladimir Oltean
2023-05-30 9:19 ` Vladimir Oltean
2023-05-30 9:19 ` [Intel-wired-lan] [PATCH net-next 1/5] net/sched: taprio: don't overwrite "sch" variable in taprio_dump_class_stats() Vladimir Oltean
2023-05-30 9:19 ` Vladimir Oltean
2023-05-30 21:14 ` [Intel-wired-lan] " Vinicius Costa Gomes
2023-05-30 21:14 ` Vinicius Costa Gomes
2023-05-30 21:32 ` [Intel-wired-lan] " Vladimir Oltean
2023-05-30 21:32 ` Vladimir Oltean
2023-05-30 22:33 ` Vinicius Costa Gomes [this message]
2023-05-30 22:33 ` Vinicius Costa Gomes
2023-05-30 9:19 ` [Intel-wired-lan] [PATCH net-next 2/5] net/sched: taprio: replace tc_taprio_qopt_offload :: enable with a "cmd" enum Vladimir Oltean
2023-05-30 9:19 ` Vladimir Oltean
2023-05-30 12:01 ` [Intel-wired-lan] " Horatiu Vultur
2023-05-30 12:01 ` Horatiu Vultur
2023-05-30 12:20 ` [Intel-wired-lan] " Kurt Kanzenbach
2023-05-30 12:20 ` Kurt Kanzenbach
2023-05-30 12:45 ` [Intel-wired-lan] " Zulkifli, Muhammad Husaini
2023-05-30 12:45 ` Zulkifli, Muhammad Husaini
2023-05-30 20:50 ` [Intel-wired-lan] " Gerhard Engleder
2023-05-30 20:50 ` Gerhard Engleder
2023-05-31 17:08 ` [Intel-wired-lan] " Simon Horman
2023-05-31 17:08 ` Simon Horman
2023-05-31 17:10 ` [Intel-wired-lan] " Vladimir Oltean
2023-05-31 17:10 ` Vladimir Oltean
2023-05-30 9:19 ` [Intel-wired-lan] [PATCH net-next 3/5] net/sched: taprio: add netlink reporting for offload statistics counters Vladimir Oltean
2023-05-30 9:19 ` Vladimir Oltean
2023-05-30 22:52 ` [Intel-wired-lan] " Vinicius Costa Gomes
2023-05-30 22:52 ` Vinicius Costa Gomes
2023-05-31 13:33 ` [Intel-wired-lan] " Vladimir Oltean
2023-05-31 13:33 ` Vladimir Oltean
2023-05-31 10:54 ` [Intel-wired-lan] " Zulkifli, Muhammad Husaini
2023-05-31 10:54 ` Zulkifli, Muhammad Husaini
2023-05-30 9:19 ` [Intel-wired-lan] [PATCH net-next 4/5] net: enetc: refactor enetc_setup_tc_taprio() to have a switch/case for cmd Vladimir Oltean
2023-05-30 9:19 ` Vladimir Oltean
2023-05-30 9:19 ` [Intel-wired-lan] [PATCH net-next 5/5] net: enetc: report statistics counters for taprio Vladimir Oltean
2023-05-30 9:19 ` Vladimir Oltean
2023-05-31 9:10 ` [Intel-wired-lan] [PATCH net-next 0/5] xstats for tc-taprio patchwork-bot+netdevbpf
2023-05-31 9:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rd5v49t.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=ferenc.fejes@ericsson.com \
--cc=gerhard@engleder-embedded.com \
--cc=harini.katakam@amd.com \
--cc=horatiu.vultur@microchip.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.wei.hong.sit@intel.com \
--cc=mohammad.athari.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=pranavi.somisetty@amd.com \
--cc=rogerq@kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.