From: Kalle Valo <kvalo@qca.qualcomm.com>
To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: add soft/hard firmware crash option to simulate_fw_crash
Date: Mon, 24 Mar 2014 10:25:00 +0200 [thread overview]
Message-ID: <878us080mb.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20140313082431.10798.10888.stgit@potku.adurom.net> (Kalle Valo's message of "Thu, 13 Mar 2014 10:24:31 +0200")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
> From: Marek Puzyniak <marek.puzyniak@tieto.com>
>
> Command WMI_FORCE_FW_HANG_CMDID is not supported in firmware 10.1.
> In order to have firmware crash simulation functionality also
> in firmware 10.1 driver can force firmware crash by performing not allowed
> operation. Driver can deliberately crash firmware when setting vdev param for
> vdev id out of range. This patch introduces two keywords to simulate_fw_crash:
>
> 'soft' which will cause firmware crash that is recoverable
> by warm firmware reset but supported only in main firmware.
> 'hard' which will cause firmware crash recoverable by cold
> firmware reset, this option works for both firmwares.
>
> Commands to trigger firmware soft/hard crash:
>
> echo 'soft' > /sys/kernel/debug/ieee80211/phyX/ath10k/simulate_fw_crash
> echo 'hard' > /sys/kernel/debug/ieee80211/phyX/ath10k/simulate_fw_crash
>
> kvalo: use strncmp(), remove '\n' before checking the command and
> document how buf is null terminated
>
> Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Thanks, applied. I just removed by strncmp() changes based on the
discussion.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <ath10k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] ath10k: add soft/hard firmware crash option to simulate_fw_crash
Date: Mon, 24 Mar 2014 10:25:00 +0200 [thread overview]
Message-ID: <878us080mb.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20140313082431.10798.10888.stgit@potku.adurom.net> (Kalle Valo's message of "Thu, 13 Mar 2014 10:24:31 +0200")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
> From: Marek Puzyniak <marek.puzyniak@tieto.com>
>
> Command WMI_FORCE_FW_HANG_CMDID is not supported in firmware 10.1.
> In order to have firmware crash simulation functionality also
> in firmware 10.1 driver can force firmware crash by performing not allowed
> operation. Driver can deliberately crash firmware when setting vdev param for
> vdev id out of range. This patch introduces two keywords to simulate_fw_crash:
>
> 'soft' which will cause firmware crash that is recoverable
> by warm firmware reset but supported only in main firmware.
> 'hard' which will cause firmware crash recoverable by cold
> firmware reset, this option works for both firmwares.
>
> Commands to trigger firmware soft/hard crash:
>
> echo 'soft' > /sys/kernel/debug/ieee80211/phyX/ath10k/simulate_fw_crash
> echo 'hard' > /sys/kernel/debug/ieee80211/phyX/ath10k/simulate_fw_crash
>
> kvalo: use strncmp(), remove '\n' before checking the command and
> document how buf is null terminated
>
> Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Thanks, applied. I just removed by strncmp() changes based on the
discussion.
--
Kalle Valo
next prev parent reply other threads:[~2014-03-24 8:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 8:24 [PATCH v2] ath10k: add soft/hard firmware crash option to simulate_fw_crash Kalle Valo
2014-03-13 8:24 ` Kalle Valo
2014-03-14 10:39 ` Kalle Valo
2014-03-14 10:39 ` Kalle Valo
2014-03-14 11:38 ` Marek Puzyniak
2014-03-14 11:38 ` Marek Puzyniak
2014-03-19 9:06 ` Kalle Valo
2014-03-19 9:06 ` Kalle Valo
2014-03-19 9:16 ` Michal Kazior
2014-03-19 9:16 ` Michal Kazior
2014-03-19 12:41 ` Jouni Malinen
2014-03-19 12:41 ` Jouni Malinen
2014-03-20 7:51 ` Kalle Valo
2014-03-20 7:51 ` Kalle Valo
2014-03-21 14:37 ` Dan Carpenter
2014-03-21 14:37 ` Dan Carpenter
2014-03-25 6:52 ` Kalle Valo
2014-03-25 6:52 ` Kalle Valo
2014-03-26 11:40 ` Dan Carpenter
2014-03-26 11:40 ` Dan Carpenter
2014-03-24 8:25 ` Kalle Valo [this message]
2014-03-24 8:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878us080mb.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.