From: Jani Nikula <jani.nikula@intel.com>
To: "Manna\, Animesh" <animesh.manna@intel.com>,
Manasi Navare <manasi.d.navare@intel.com>
Cc: nidhi1.gupta@intel.com, intel-gfx@lists.freedesktop.org,
uma.shankar@intel.com, dri-devel@lists.freedesktop.org,
anshuman.gupta@intel.com
Subject: Re: [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation
Date: Wed, 15 Jan 2020 11:11:19 +0200 [thread overview]
Message-ID: <87a76pjd8o.fsf@intel.com> (raw)
In-Reply-To: <88415e48-2d1d-6b31-211c-6509b4605c67@intel.com>
On Mon, 06 Jan 2020, "Manna, Animesh" <animesh.manna@intel.com> wrote:
> Sure Manasi, I will make intel_get_adjust_train() non-static and keep in intel_dp_link_training.c.
> Now as suggested by Jani before (https://patchwork.freedesktop.org/patch/345823/?series=71121&rev=1#comment_640087) other non static functions are not following the rule,
> should I change the function name or keep it as it is?
Please prefix it intel_dp_. I think intel_dp_link_training_ is too long
here. :)
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: "Manna\, Animesh" <animesh.manna@intel.com>,
Manasi Navare <manasi.d.navare@intel.com>
Cc: nidhi1.gupta@intel.com, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation
Date: Wed, 15 Jan 2020 11:11:19 +0200 [thread overview]
Message-ID: <87a76pjd8o.fsf@intel.com> (raw)
In-Reply-To: <88415e48-2d1d-6b31-211c-6509b4605c67@intel.com>
On Mon, 06 Jan 2020, "Manna, Animesh" <animesh.manna@intel.com> wrote:
> Sure Manasi, I will make intel_get_adjust_train() non-static and keep in intel_dp_link_training.c.
> Now as suggested by Jani before (https://patchwork.freedesktop.org/patch/345823/?series=71121&rev=1#comment_640087) other non static functions are not following the rule,
> should I change the function name or keep it as it is?
Please prefix it intel_dp_. I think intel_dp_link_training_ is too long
here. :)
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-15 9:10 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 16:15 [PATCH v3 0/9] DP Phy compliance auto test Animesh Manna
2019-12-30 16:15 ` [Intel-gfx] " Animesh Manna
2019-12-30 16:15 ` [PATCH v3 1/9] drm/amd/display: Align macro name as per DP spec Animesh Manna
2019-12-30 16:15 ` [Intel-gfx] " Animesh Manna
2020-01-03 23:54 ` Manasi Navare
2020-01-03 23:54 ` [Intel-gfx] " Manasi Navare
2020-01-06 23:05 ` Alex Deucher
2020-01-06 23:05 ` [Intel-gfx] " Alex Deucher
2019-12-30 16:15 ` [PATCH v3 2/9] drm/dp: get/set phy compliance pattern Animesh Manna
2019-12-30 16:15 ` [Intel-gfx] " Animesh Manna
2019-12-30 16:15 ` [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation Animesh Manna
2019-12-30 16:15 ` [Intel-gfx] " Animesh Manna
2020-01-02 9:18 ` Jani Nikula
2020-01-02 9:18 ` [Intel-gfx] " Jani Nikula
2020-01-02 10:26 ` Manna, Animesh
2020-01-02 10:26 ` [Intel-gfx] " Manna, Animesh
2020-01-03 23:48 ` Manasi Navare
2020-01-03 23:48 ` [Intel-gfx] " Manasi Navare
2020-01-06 10:02 ` Manna, Animesh
2020-01-06 10:02 ` [Intel-gfx] " Manna, Animesh
2020-01-15 9:11 ` Jani Nikula [this message]
2020-01-15 9:11 ` Jani Nikula
2019-12-30 16:15 ` [PATCH v3 4/9] drm/i915/dp: Preparation for DP phy compliance auto test Animesh Manna
2019-12-30 16:15 ` [Intel-gfx] " Animesh Manna
2019-12-30 16:15 ` [PATCH v3 5/9] drm/i915/dsb: Send uevent to testapp Animesh Manna
2019-12-30 16:15 ` [Intel-gfx] " Animesh Manna
2019-12-30 16:15 ` [PATCH v3 6/9] drm/i915/dp: Add debugfs entry for DP phy compliance Animesh Manna
2019-12-30 16:15 ` [Intel-gfx] " Animesh Manna
2019-12-30 16:15 ` [PATCH v3 7/9] drm/i915/dp: Register definition for DP compliance register Animesh Manna
2019-12-30 16:15 ` [Intel-gfx] " Animesh Manna
2019-12-30 16:15 ` [PATCH v3 8/9] drm/i915/dp: Update the pattern as per request Animesh Manna
2019-12-30 16:15 ` [Intel-gfx] " Animesh Manna
2020-01-02 9:23 ` Jani Nikula
2020-01-02 9:23 ` Jani Nikula
2020-01-03 23:51 ` Manasi Navare
2020-01-03 23:51 ` Manasi Navare
2019-12-30 16:15 ` [PATCH v3 9/9] drm/i915/dp: [FIXME] Program vswing, pre-emphasis, test-pattern Animesh Manna
2019-12-30 16:15 ` [Intel-gfx] " Animesh Manna
2019-12-30 16:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DP Phy compliance auto test (rev5) Patchwork
2019-12-30 17:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2019-12-31 7:05 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-12-23 16:43 [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation Animesh Manna
2019-12-19 12:33 [PATCH v2 " Ville Syrjälä
2019-12-23 16:45 ` [PATCH v3 " Animesh Manna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a76pjd8o.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=animesh.manna@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=manasi.d.navare@intel.com \
--cc=nidhi1.gupta@intel.com \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.