All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: Petr Mladek <pmladek@suse.com>
Cc: Andrea Parri <andrea.parri@amarulasolutions.com>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Brendan Higgins <brendanhiggins@google.com>,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	kexec@lists.infradead.org
Subject: Re: [RFC PATCH v5 2/3] printk-rb: new printk ringbuffer implementation (reader)
Date: Wed, 04 Dec 2019 14:28:48 +0100	[thread overview]
Message-ID: <87a788fcdr.fsf@linutronix.de> (raw)
In-Reply-To: <20191204125450.ob5b7xi3gevor4qz@pathway.suse.cz> (Petr Mladek's message of "Wed, 4 Dec 2019 13:54:50 +0100")

On 2019-12-04, Petr Mladek <pmladek@suse.com> wrote:
>> +	} else if ((DATA_WRAPS(data_ring, blk_lpos->begin) + 1 ==
>> +		    DATA_WRAPS(data_ring, blk_lpos->next)) ||
>> +		   ((DATA_WRAPS(data_ring, blk_lpos->begin) ==
>> +		     DATA_WRAPS(data_ring, -1UL)) &&
>> +		    (DATA_WRAPS(data_ring, blk_lpos->next) == 0))) {
>
> I wonder if the following might be easier to understand even for
> people like me ;-)
>
> 	} else if (DATA_WRAPS(data_ring, blk_lpos->begin + DATA_SIZE(data_ring)) ==
> 		    DATA_WRAPS(data_ring, blk_lpos->next)) {

Yes, this is clear and covers both cases. Thanks.

John

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: John Ogness <john.ogness@linutronix.de>
To: Petr Mladek <pmladek@suse.com>
Cc: linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrea Parri <andrea.parri@amarulasolutions.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Brendan Higgins <brendanhiggins@google.com>,
	kexec@lists.infradead.org
Subject: Re: [RFC PATCH v5 2/3] printk-rb: new printk ringbuffer implementation (reader)
Date: Wed, 04 Dec 2019 14:28:48 +0100	[thread overview]
Message-ID: <87a788fcdr.fsf@linutronix.de> (raw)
In-Reply-To: <20191204125450.ob5b7xi3gevor4qz@pathway.suse.cz> (Petr Mladek's message of "Wed, 4 Dec 2019 13:54:50 +0100")

On 2019-12-04, Petr Mladek <pmladek@suse.com> wrote:
>> +	} else if ((DATA_WRAPS(data_ring, blk_lpos->begin) + 1 ==
>> +		    DATA_WRAPS(data_ring, blk_lpos->next)) ||
>> +		   ((DATA_WRAPS(data_ring, blk_lpos->begin) ==
>> +		     DATA_WRAPS(data_ring, -1UL)) &&
>> +		    (DATA_WRAPS(data_ring, blk_lpos->next) == 0))) {
>
> I wonder if the following might be easier to understand even for
> people like me ;-)
>
> 	} else if (DATA_WRAPS(data_ring, blk_lpos->begin + DATA_SIZE(data_ring)) ==
> 		    DATA_WRAPS(data_ring, blk_lpos->next)) {

Yes, this is clear and covers both cases. Thanks.

John

  reply	other threads:[~2019-12-04 13:29 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28  1:52 [RFC PATCH v5 0/3] printk: new ringbuffer implementation John Ogness
2019-11-28  1:52 ` John Ogness
2019-11-28  1:52 ` [RFC PATCH v5 1/3] printk-rb: new printk ringbuffer implementation (writer) John Ogness
2019-11-28  1:52   ` John Ogness
2019-12-02 15:48   ` Petr Mladek
2019-12-02 15:48     ` Petr Mladek
2019-12-02 15:59     ` Petr Mladek
2019-12-02 15:59       ` Petr Mladek
2019-12-02 16:37       ` John Ogness
2019-12-02 16:37         ` John Ogness
2019-12-03  1:17         ` Sergey Senozhatsky
2019-12-03  1:17           ` Sergey Senozhatsky
2019-12-03 14:18           ` Steven Rostedt
2019-12-03 14:18             ` Steven Rostedt
2019-12-05 12:01             ` John Ogness
2019-12-05 12:01               ` John Ogness
2019-12-03  8:54         ` Petr Mladek
2019-12-03  8:54           ` Petr Mladek
2019-12-03 14:13     ` John Ogness
2019-12-03 14:13       ` John Ogness
2019-12-03 14:36       ` Petr Mladek
2019-12-03 14:36         ` Petr Mladek
2019-12-09  9:19     ` Sergey Senozhatsky
2019-12-09  9:19       ` Sergey Senozhatsky
2019-12-09  7:42   ` Sergey Senozhatsky
2019-12-09  7:42     ` Sergey Senozhatsky
2019-12-09  9:00     ` John Ogness
2019-12-09  9:00       ` John Ogness
2019-12-09  9:27   ` Sergey Senozhatsky
2019-12-09  9:27     ` Sergey Senozhatsky
2019-12-09  9:34     ` John Ogness
2019-12-09  9:34       ` John Ogness
2019-12-21 14:22   ` Andrea Parri
2019-12-21 14:22     ` Andrea Parri
2019-12-23 16:01     ` John Ogness
2019-12-23 16:01       ` John Ogness
2020-01-03 10:24       ` Petr Mladek
2020-01-04 14:33         ` Andrea Parri
2019-11-28  1:52 ` [RFC PATCH v5 2/3] printk-rb: new printk ringbuffer implementation (reader) John Ogness
2019-11-28  1:52   ` John Ogness
2019-12-03 12:06   ` Petr Mladek
2019-12-03 12:06     ` Petr Mladek
2019-12-03 13:46     ` John Ogness
2019-12-03 13:46       ` John Ogness
2019-12-04 12:54       ` Petr Mladek
2019-12-04 12:54         ` Petr Mladek
2019-12-04 13:28         ` John Ogness [this message]
2019-12-04 13:28           ` John Ogness
2019-12-09  8:43   ` Sergey Senozhatsky
2019-12-09  8:43     ` Sergey Senozhatsky
2019-12-09  9:03     ` Sergey Senozhatsky
2019-12-09  9:03       ` Sergey Senozhatsky
2019-12-09  9:09     ` John Ogness
2019-12-09  9:09       ` John Ogness
2019-11-28  1:52 ` [RFC PATCH v5 3/3] printk-rb: add test module John Ogness
2019-11-28  1:52   ` John Ogness
2019-12-09  8:44   ` Sergey Senozhatsky
2019-12-09  8:44     ` Sergey Senozhatsky
2019-12-05 13:46 ` [RFC PATCH v5 0/3] printk: new ringbuffer implementation Prarit Bhargava
2019-12-05 13:46   ` Prarit Bhargava
2019-12-05 14:05   ` John Ogness
2019-12-05 14:05     ` John Ogness
2019-12-06 14:16     ` Prarit Bhargava
2019-12-06 14:16       ` Prarit Bhargava
2020-01-27 12:20 ` Eugeniu Rosca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a788fcdr.fsf@linutronix.de \
    --to=john.ogness@linutronix.de \
    --cc=andrea.parri@amarulasolutions.com \
    --cc=brendanhiggins@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.