All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Joe Perches <joe@perches.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/1] drm/gma500: dont expose stack, mrst_lvds_find_best_pll
Date: Mon, 22 Aug 2016 11:39:48 +0300	[thread overview]
Message-ID: <87a8g5urhn.fsf@intel.com> (raw)
In-Reply-To: <1471809437-4377-1-git-send-email-xypron.glpk@gmx.de>

On Sun, 21 Aug 2016, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> All components of variable clock should be initialized
> to avoid bytes from the kernel stack to be exposed.
>
> Reported-by: Joe Perches <joe@perches.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> index 28bd8f3..0277d85 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> @@ -195,6 +195,7 @@ static bool mrst_lvds_find_best_pll(const struct gma_limit_t *limit,
>  	struct gma_clock_t clock;
>  	int err = target;
>  
> +	memset(clock, 0, sizeof(struct gma_clock_t));

Again, did you actually build this? This is hurting not helping us. It
makes me think you didn't try your other patches either.

BR,
Jani.


>  	memset(best_clock, 0, sizeof(*best_clock));
>  
>  	for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) {

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Joe Perches <joe@perches.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: Re: [PATCH 1/1] drm/gma500: dont expose stack, mrst_lvds_find_best_pll
Date: Mon, 22 Aug 2016 11:39:48 +0300	[thread overview]
Message-ID: <87a8g5urhn.fsf@intel.com> (raw)
In-Reply-To: <1471809437-4377-1-git-send-email-xypron.glpk@gmx.de>

On Sun, 21 Aug 2016, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> All components of variable clock should be initialized
> to avoid bytes from the kernel stack to be exposed.
>
> Reported-by: Joe Perches <joe@perches.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> index 28bd8f3..0277d85 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> @@ -195,6 +195,7 @@ static bool mrst_lvds_find_best_pll(const struct gma_limit_t *limit,
>  	struct gma_clock_t clock;
>  	int err = target;
>  
> +	memset(clock, 0, sizeof(struct gma_clock_t));

Again, did you actually build this? This is hurting not helping us. It
makes me think you didn't try your other patches either.

BR,
Jani.


>  	memset(best_clock, 0, sizeof(*best_clock));
>  
>  	for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) {

-- 
Jani Nikula, Intel Open Source Technology Center

  reply	other threads:[~2016-08-22  8:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-21 19:57 [PATCH 1/1] drm/gma500: dont expose stack, mrst_lvds_find_best_pll Heinrich Schuchardt
2016-08-22  8:39 ` Jani Nikula [this message]
2016-08-22  8:39   ` Jani Nikula
2016-08-22 12:40 ` kbuild test robot
2016-08-22 12:40   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8g5urhn.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrik.r.jakobsson@gmail.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.