From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless@vger.kernel.org,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 1/2] ath10k: introduce rx_status htt template
Date: Mon, 24 Mar 2014 12:47:46 +0200 [thread overview]
Message-ID: <87a9cf7u0d.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CALhHN=peGOBr3_9zpiE73HMnOd3_WZqo00B+RtvaXSS0OH2MEQ@mail.gmail.com> (Janusz Dziedzic's message of "Mon, 24 Mar 2014 11:16:54 +0100")
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
> On 24 March 2014 11:06, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
>>
>>> Introduce rx_status htt template instead of
>>> stack version.
>>>
>>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
>>
>> Why? What's the benefit from doing this?
>>
> This is the must in case we would like to report rssi + rates correctly.
> I describe this in 2/2 - maybe squash them?
Nah, better to keep them separated. But in patch 1 please document why
you are doing that, so that I (and others cherry picking ath10k patches)
don't need to guess. For example, you can say "in preparation for foo"
or something like that.
> Currently during heavy traffic we could have:
>> 10 packets with START_VALID - correct RSSI + rates
>> 10 packets with END_VALID
>> 10 packets with START_VALID - correct RSSI + rates
>> 10 packets with END_VALID -
> ...
>
> Because of that we have to store rssi + rates for case when END_VALID only.
> In other case when using monitor we will see:
> - 10 packets with correct rssi/rates
> - 10 packets with rssi=-95/rate=6Mbps
Ok, I understand now. Please document that in patch 2.
And in the future, please double check that your commit logs answer the
question "why?". That will save everyone's time :)
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] ath10k: introduce rx_status htt template
Date: Mon, 24 Mar 2014 12:47:46 +0200 [thread overview]
Message-ID: <87a9cf7u0d.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CALhHN=peGOBr3_9zpiE73HMnOd3_WZqo00B+RtvaXSS0OH2MEQ@mail.gmail.com> (Janusz Dziedzic's message of "Mon, 24 Mar 2014 11:16:54 +0100")
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
> On 24 March 2014 11:06, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
>>
>>> Introduce rx_status htt template instead of
>>> stack version.
>>>
>>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
>>
>> Why? What's the benefit from doing this?
>>
> This is the must in case we would like to report rssi + rates correctly.
> I describe this in 2/2 - maybe squash them?
Nah, better to keep them separated. But in patch 1 please document why
you are doing that, so that I (and others cherry picking ath10k patches)
don't need to guess. For example, you can say "in preparation for foo"
or something like that.
> Currently during heavy traffic we could have:
>> 10 packets with START_VALID - correct RSSI + rates
>> 10 packets with END_VALID
>> 10 packets with START_VALID - correct RSSI + rates
>> 10 packets with END_VALID -
> ...
>
> Because of that we have to store rssi + rates for case when END_VALID only.
> In other case when using monitor we will see:
> - 10 packets with correct rssi/rates
> - 10 packets with rssi=-95/rate=6Mbps
Ok, I understand now. Please document that in patch 2.
And in the future, please double check that your commit logs answer the
question "why?". That will save everyone's time :)
--
Kalle Valo
next prev parent reply other threads:[~2014-03-24 10:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 9:33 [PATCH 1/2] ath10k: introduce rx_status htt template Janusz Dziedzic
2014-03-21 9:33 ` Janusz Dziedzic
2014-03-21 9:33 ` [PATCH 2/2] ath10k: fix rssi and rate reporting Janusz Dziedzic
2014-03-21 9:33 ` Janusz Dziedzic
2014-03-24 10:08 ` Kalle Valo
2014-03-24 10:08 ` Kalle Valo
2014-03-24 10:06 ` [PATCH 1/2] ath10k: introduce rx_status htt template Kalle Valo
2014-03-24 10:06 ` Kalle Valo
2014-03-24 10:16 ` Janusz Dziedzic
2014-03-24 10:16 ` Janusz Dziedzic
2014-03-24 10:47 ` Kalle Valo [this message]
2014-03-24 10:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9cf7u0d.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.