From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 2/2] ath10k: fix rssi and rate reporting
Date: Mon, 24 Mar 2014 12:08:21 +0200 [thread overview]
Message-ID: <87eh1r7vu2.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1395394437-4048-2-git-send-email-janusz.dziedzic@tieto.com> (Janusz Dziedzic's message of "Fri, 21 Mar 2014 10:33:57 +0100")
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
> RSSI and RATE fields are valid only when START_VALID
> bit is set. So, in current implementation we have to
> remember/caclulate them when START_VALID and report the same
> when only END_VALID is set. In other case during high
> RX traffic we will report invalid RSSI (-95) and RATE (6Mbps)
> when only END_VALID bit set.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
It's not clear for me what (user visible) bug you are fixing, please
describe that in the commit log.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] ath10k: fix rssi and rate reporting
Date: Mon, 24 Mar 2014 12:08:21 +0200 [thread overview]
Message-ID: <87eh1r7vu2.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1395394437-4048-2-git-send-email-janusz.dziedzic@tieto.com> (Janusz Dziedzic's message of "Fri, 21 Mar 2014 10:33:57 +0100")
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
> RSSI and RATE fields are valid only when START_VALID
> bit is set. So, in current implementation we have to
> remember/caclulate them when START_VALID and report the same
> when only END_VALID is set. In other case during high
> RX traffic we will report invalid RSSI (-95) and RATE (6Mbps)
> when only END_VALID bit set.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
It's not clear for me what (user visible) bug you are fixing, please
describe that in the commit log.
--
Kalle Valo
next prev parent reply other threads:[~2014-03-24 10:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 9:33 [PATCH 1/2] ath10k: introduce rx_status htt template Janusz Dziedzic
2014-03-21 9:33 ` Janusz Dziedzic
2014-03-21 9:33 ` [PATCH 2/2] ath10k: fix rssi and rate reporting Janusz Dziedzic
2014-03-21 9:33 ` Janusz Dziedzic
2014-03-24 10:08 ` Kalle Valo [this message]
2014-03-24 10:08 ` Kalle Valo
2014-03-24 10:06 ` [PATCH 1/2] ath10k: introduce rx_status htt template Kalle Valo
2014-03-24 10:06 ` Kalle Valo
2014-03-24 10:16 ` Janusz Dziedzic
2014-03-24 10:16 ` Janusz Dziedzic
2014-03-24 10:47 ` Kalle Valo
2014-03-24 10:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh1r7vu2.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.