From: Kalle Valo <kvalo@qca.qualcomm.com>
To: michal.kazior@tieto.com
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 3/7] ath10k: track vif list internally
Date: Tue, 15 Oct 2013 21:49:19 +0300 [thread overview]
Message-ID: <87a9iabc9c.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20131015184656.14123.70575.stgit@localhost6.localdomain6> (Kalle Valo's message of "Tue, 15 Oct 2013 21:46:56 +0300")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
> From: Michal Kazior <michal.kazior@tieto.com>
>
> mac80211 interface interations functions have
> peculiar locking issues. This patch introduces
> internal (to ath10k) vif list that will be used
> for vif iteration purposes.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
[...]
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -713,6 +713,7 @@ struct ath10k *ath10k_core_create(void *hif_priv, struct device *dev,
> mutex_init(&ar->conf_mutex);
> spin_lock_init(&ar->data_lock);
>
> + INIT_LIST_HEAD(&ar->arvifs);
> INIT_LIST_HEAD(&ar->peers);
> init_waitqueue_head(&ar->peer_mapping_wq);
>
> @@ -824,6 +825,7 @@ int ath10k_core_start(struct ath10k *ar)
> goto err_disconnect_htc;
>
> ar->free_vdev_map = (1 << TARGET_NUM_VDEVS) - 1;
> + INIT_LIST_HEAD(&ar->arvifs);
>
> return 0;
Michal, why do the INIT_LIST_HEAD() twice? Isn't it enough to do it
core_start()?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/7] ath10k: track vif list internally
Date: Tue, 15 Oct 2013 21:49:19 +0300 [thread overview]
Message-ID: <87a9iabc9c.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20131015184656.14123.70575.stgit@localhost6.localdomain6> (Kalle Valo's message of "Tue, 15 Oct 2013 21:46:56 +0300")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
> From: Michal Kazior <michal.kazior@tieto.com>
>
> mac80211 interface interations functions have
> peculiar locking issues. This patch introduces
> internal (to ath10k) vif list that will be used
> for vif iteration purposes.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
[...]
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -713,6 +713,7 @@ struct ath10k *ath10k_core_create(void *hif_priv, struct device *dev,
> mutex_init(&ar->conf_mutex);
> spin_lock_init(&ar->data_lock);
>
> + INIT_LIST_HEAD(&ar->arvifs);
> INIT_LIST_HEAD(&ar->peers);
> init_waitqueue_head(&ar->peer_mapping_wq);
>
> @@ -824,6 +825,7 @@ int ath10k_core_start(struct ath10k *ar)
> goto err_disconnect_htc;
>
> ar->free_vdev_map = (1 << TARGET_NUM_VDEVS) - 1;
> + INIT_LIST_HEAD(&ar->arvifs);
>
> return 0;
Michal, why do the INIT_LIST_HEAD() twice? Isn't it enough to do it
core_start()?
--
Kalle Valo
next prev parent reply other threads:[~2013-10-15 18:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 18:46 [PATCH 0/7] ath10k: fix WMI atomic usage Kalle Valo
2013-10-15 18:46 ` Kalle Valo
2013-10-15 18:46 ` [PATCH 1/7] ath10k: use workqueue to set WEP TX key Kalle Valo
2013-10-15 18:46 ` Kalle Valo
2013-10-15 18:46 ` [PATCH 2/7] ath10k: fix add_interface failure handling Kalle Valo
2013-10-15 18:46 ` Kalle Valo
2013-10-15 18:46 ` [PATCH 3/7] ath10k: track vif list internally Kalle Valo
2013-10-15 18:46 ` Kalle Valo
2013-10-15 18:49 ` Kalle Valo [this message]
2013-10-15 18:49 ` Kalle Valo
2013-10-15 19:37 ` Michal Kazior
2013-10-15 19:37 ` Michal Kazior
2013-10-16 12:47 ` Kalle Valo
2013-10-16 12:47 ` Kalle Valo
2013-10-15 18:47 ` [PATCH 4/7] ath10k: fix scheduling while atomic config bug Kalle Valo
2013-10-15 18:47 ` Kalle Valo
2013-10-15 18:47 ` [PATCH 5/7] ath10k: remove unnecessary checks Kalle Valo
2013-10-15 18:47 ` Kalle Valo
2013-10-15 18:47 ` [PATCH 6/7] ath10k: fix ath10k_bss_assoc() to not sleep in atomic context Kalle Valo
2013-10-15 18:47 ` Kalle Valo
2013-10-15 18:47 ` [PATCH 7/7] ath10k: add might_sleep() to ath10k_wmi_cmd_send() Kalle Valo
2013-10-15 18:47 ` Kalle Valo
2013-10-16 12:48 ` [PATCH 0/7] ath10k: fix WMI atomic usage Kalle Valo
2013-10-16 12:48 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9iabc9c.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.