All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Andy Gross <andy.gross@ti.com>, dri-devel@lists.freedesktop.org
Cc: Rob Clark <rob@ti.com>, Greg Kroah-Hartman <greg@kroah.com>
Subject: Re: [PATCH] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR
Date: Fri, 23 Nov 2012 10:10:56 +0200	[thread overview]
Message-ID: <87a9u8hh7z.fsf@intel.com> (raw)
In-Reply-To: <1352842892-2810-1-git-send-email-andy.gross@ti.com>

On Tue, 13 Nov 2012, Andy Gross <andy.gross@ti.com> wrote:
> Return PTR_ERR(-ENOMEM) if dmm_txn_init cannot allocate a
> refill engine.
>
> Signed-off-by: Andy Gross <andy.gross@ti.com>
> ---
>  drivers/staging/omapdrm/omap_dmm_tiler.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/omapdrm/omap_dmm_tiler.c b/drivers/staging/omapdrm/omap_dmm_tiler.c
> index 3ae3955..1a5a7ca 100644
> --- a/drivers/staging/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/staging/omapdrm/omap_dmm_tiler.c
> @@ -279,7 +279,7 @@ static int fill(struct tcm_area *area, struct page **pages,
>  
>  	txn = dmm_txn_init(omap_dmm, area->tcm);
>  	if (IS_ERR_OR_NULL(txn))
> -		return PTR_ERR(txn);
> +		return PTR_ERR(-ENOMEM);

return -ENOMEM;

BR,
Jani.

>  
>  	tcm_for_each_slice(slice, *area, area_s) {
>  		struct pat_area p_area = {
> -- 
> 1.7.5.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2012-11-23  8:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-13 21:41 [PATCH] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR Andy Gross
2012-11-13 23:19 ` Rob Clark
2012-11-23  8:10 ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9u8hh7z.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=andy.gross@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=greg@kroah.com \
    --cc=rob@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.