* [PATCH] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR
@ 2012-11-13 21:41 Andy Gross
2012-11-13 23:19 ` Rob Clark
2012-11-23 8:10 ` Jani Nikula
0 siblings, 2 replies; 3+ messages in thread
From: Andy Gross @ 2012-11-13 21:41 UTC (permalink / raw)
To: dri-devel; +Cc: Rob Clark, Greg Kroah-Hartman
Return PTR_ERR(-ENOMEM) if dmm_txn_init cannot allocate a
refill engine.
Signed-off-by: Andy Gross <andy.gross@ti.com>
---
drivers/staging/omapdrm/omap_dmm_tiler.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/omapdrm/omap_dmm_tiler.c b/drivers/staging/omapdrm/omap_dmm_tiler.c
index 3ae3955..1a5a7ca 100644
--- a/drivers/staging/omapdrm/omap_dmm_tiler.c
+++ b/drivers/staging/omapdrm/omap_dmm_tiler.c
@@ -279,7 +279,7 @@ static int fill(struct tcm_area *area, struct page **pages,
txn = dmm_txn_init(omap_dmm, area->tcm);
if (IS_ERR_OR_NULL(txn))
- return PTR_ERR(txn);
+ return PTR_ERR(-ENOMEM);
tcm_for_each_slice(slice, *area, area_s) {
struct pat_area p_area = {
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR
2012-11-13 21:41 [PATCH] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR Andy Gross
@ 2012-11-13 23:19 ` Rob Clark
2012-11-23 8:10 ` Jani Nikula
1 sibling, 0 replies; 3+ messages in thread
From: Rob Clark @ 2012-11-13 23:19 UTC (permalink / raw)
To: Andy Gross; +Cc: Greg Kroah-Hartman, dri-devel
On Tue, Nov 13, 2012 at 3:41 PM, Andy Gross <andy.gross@ti.com> wrote:
> Return PTR_ERR(-ENOMEM) if dmm_txn_init cannot allocate a
> refill engine.
>
> Signed-off-by: Andy Gross <andy.gross@ti.com>
Signed-off-by: Rob Clark <rob@ti.com>
> ---
> drivers/staging/omapdrm/omap_dmm_tiler.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/omapdrm/omap_dmm_tiler.c b/drivers/staging/omapdrm/omap_dmm_tiler.c
> index 3ae3955..1a5a7ca 100644
> --- a/drivers/staging/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/staging/omapdrm/omap_dmm_tiler.c
> @@ -279,7 +279,7 @@ static int fill(struct tcm_area *area, struct page **pages,
>
> txn = dmm_txn_init(omap_dmm, area->tcm);
> if (IS_ERR_OR_NULL(txn))
> - return PTR_ERR(txn);
> + return PTR_ERR(-ENOMEM);
>
> tcm_for_each_slice(slice, *area, area_s) {
> struct pat_area p_area = {
> --
> 1.7.5.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR
2012-11-13 21:41 [PATCH] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR Andy Gross
2012-11-13 23:19 ` Rob Clark
@ 2012-11-23 8:10 ` Jani Nikula
1 sibling, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2012-11-23 8:10 UTC (permalink / raw)
To: Andy Gross, dri-devel; +Cc: Rob Clark, Greg Kroah-Hartman
On Tue, 13 Nov 2012, Andy Gross <andy.gross@ti.com> wrote:
> Return PTR_ERR(-ENOMEM) if dmm_txn_init cannot allocate a
> refill engine.
>
> Signed-off-by: Andy Gross <andy.gross@ti.com>
> ---
> drivers/staging/omapdrm/omap_dmm_tiler.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/omapdrm/omap_dmm_tiler.c b/drivers/staging/omapdrm/omap_dmm_tiler.c
> index 3ae3955..1a5a7ca 100644
> --- a/drivers/staging/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/staging/omapdrm/omap_dmm_tiler.c
> @@ -279,7 +279,7 @@ static int fill(struct tcm_area *area, struct page **pages,
>
> txn = dmm_txn_init(omap_dmm, area->tcm);
> if (IS_ERR_OR_NULL(txn))
> - return PTR_ERR(txn);
> + return PTR_ERR(-ENOMEM);
return -ENOMEM;
BR,
Jani.
>
> tcm_for_each_slice(slice, *area, area_s) {
> struct pat_area p_area = {
> --
> 1.7.5.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-23 8:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-13 21:41 [PATCH] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR Andy Gross
2012-11-13 23:19 ` Rob Clark
2012-11-23 8:10 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.