* [PATCH] fbfront: Fix no-kbd-event case
@ 2008-02-13 16:03 Samuel Thibault
2008-02-13 17:49 ` Markus Armbruster
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Thibault @ 2008-02-13 16:03 UTC (permalink / raw)
To: xen-devel
fbfront: Fix no-kbd-event case
out_cons shouldn't even be used.
Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
diff -r f76e90b4f7ad drivers/xen/fbfront/xenkbd.c
--- a/drivers/xen/fbfront/xenkbd.c Tue Feb 12 10:44:33 2008 +0000
+++ b/drivers/xen/fbfront/xenkbd.c Wed Feb 13 15:59:45 2008 +0000
@@ -53,7 +53,7 @@ static irqreturn_t input_handler(int rq,
__u32 cons, prod;
prod = page->in_prod;
- if (prod == page->out_cons)
+ if (prod == page->in_cons)
return IRQ_HANDLED;
rmb(); /* ensure we see ring contents up to prod */
for (cons = page->in_cons; cons != prod; cons++) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fbfront: Fix no-kbd-event case
2008-02-13 16:03 [PATCH] fbfront: Fix no-kbd-event case Samuel Thibault
@ 2008-02-13 17:49 ` Markus Armbruster
0 siblings, 0 replies; 2+ messages in thread
From: Markus Armbruster @ 2008-02-13 17:49 UTC (permalink / raw)
To: Samuel Thibault; +Cc: xen-devel
Samuel Thibault <samuel.thibault@eu.citrix.com> writes:
> fbfront: Fix no-kbd-event case
> out_cons shouldn't even be used.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
You're right. Stupid typo.
[...]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-13 17:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-13 16:03 [PATCH] fbfront: Fix no-kbd-event case Samuel Thibault
2008-02-13 17:49 ` Markus Armbruster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.