[KJ] [PATCH] potential parse error in ifdef

[KJ] [PATCH] potential parse error in ifdef

[Yoann Padioleau]

Hi, 

I have made a tool to parse the kernel that does not pre-process the
source. That means that my parser tries to parse all the code, including
code in the #else branch or code that is not often compiled because
the driver is not very used (or not used at all). So, my parser
sometimes reports parse error not originally detected by gcc. 
Here is my (first) patch.

Signed-off-by: Yoann Padioleau <padator@wanadoo.fr> 

---

 drivers/char/watchdog/ixp2000_wdt.c |    2 +-
 drivers/mtd/devices/pmc551.c        |    2 +-
 drivers/mtd/nand/autcpu12.c         |    2 +-
 drivers/mtd/nand/ppchameleonevb.c   |    2 +-
 drivers/net/amd8111e.c              |    2 +-
 drivers/net/skfp/smt.c              |    2 +-
 drivers/scsi/aic7xxx/aic79xx_core.c |    2 +-
 sound/arm/sa11xx-uda1341.c          |    2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)


diff --git a/drivers/char/watchdog/ixp2000_wdt.c b/drivers/char/watchdog/ixp2000_wdt.c
index fd955db..dc7548d 100644
--- a/drivers/char/watchdog/ixp2000_wdt.c
+++ b/drivers/char/watchdog/ixp2000_wdt.c
@@ -205,7 +205,7 @@ static void __exit ixp2000_wdt_exit(void
 module_init(ixp2000_wdt_init);
 module_exit(ixp2000_wdt_exit);
 
-MODULE_AUTHOR("Deepak Saxena <dsaxena@plexity.net">);
+MODULE_AUTHOR("Deepak Saxena <dsaxena@plexity.net>");
 MODULE_DESCRIPTION("IXP2000 Network Processor Watchdog");
 
 module_param(heartbeat, int, 0);
diff --git a/drivers/mtd/devices/pmc551.c b/drivers/mtd/devices/pmc551.c
index a4873ab..e8f686f 100644
--- a/drivers/mtd/devices/pmc551.c
+++ b/drivers/mtd/devices/pmc551.c
@@ -650,7 +650,7 @@ MODULE_DESCRIPTION(PMC551_VERSION);
  */
 static int msize = 0;
 #if defined(CONFIG_MTD_PMC551_APERTURE_SIZE)
-static int asize = CONFIG_MTD_PMC551_APERTURE_SIZE
+static int asize = CONFIG_MTD_PMC551_APERTURE_SIZE;
 #else
 static int asize = 0;
 #endif
diff --git a/drivers/mtd/nand/autcpu12.c b/drivers/mtd/nand/autcpu12.c
index fe94ae9..e3744eb 100644
--- a/drivers/mtd/nand/autcpu12.c
+++ b/drivers/mtd/nand/autcpu12.c
@@ -101,7 +101,7 @@ static void autcpu12_hwcontrol(struct mt
 	struct nand_chip *chip = mtd->priv;
 
 	if (ctrl & NAND_CTRL_CHANGE) {
-		void __iomem *addr
+		void __iomem *addr;
 		unsigned char bits;
 
 		addr = CS89712_VIRT_BASE + AUTCPU12_SMC_PORT_OFFSET;
diff --git a/drivers/mtd/nand/ppchameleonevb.c b/drivers/mtd/nand/ppchameleonevb.c
index eb7d4d4..38fe9e9 100644
--- a/drivers/mtd/nand/ppchameleonevb.c
+++ b/drivers/mtd/nand/ppchameleonevb.c
@@ -81,7 +81,7 @@ #ifdef CONFIG_MTD_PARTITIONS
  */
 static struct mtd_partition partition_info_hi[] = {
       { .name = "PPChameleon HI Nand Flash",
-	offset = 0,
+	.offset = 0,
 	.size = 128 * 1024 * 1024
       }
 };
diff --git a/drivers/net/amd8111e.c b/drivers/net/amd8111e.c
index 675fe91..84b8164 100644
--- a/drivers/net/amd8111e.c
+++ b/drivers/net/amd8111e.c
@@ -155,7 +155,7 @@ This function will write into PHY regist
 */
 static int amd8111e_write_phy(struct amd8111e_priv* lp,int phy_id, int reg, u32 val)
 {
-	unsigned int repeat = REPEAT_CNT
+	unsigned int repeat = REPEAT_CNT;
 	void __iomem *mmio = lp->mmio;
 	unsigned int reg_val;
 
diff --git a/drivers/net/skfp/smt.c b/drivers/net/skfp/smt.c
index fe84780..75afc1f 100644
--- a/drivers/net/skfp/smt.c
+++ b/drivers/net/skfp/smt.c
@@ -1748,7 +1748,7 @@ char *addr_to_string(struct fddi_addr *a
 #endif
 
 #ifdef	AM29K
-smt_ifconfig(int argc, char *argv[])
+int smt_ifconfig(int argc, char *argv[])
 {
 	if (argc >= 2 && !strcmp(argv[0],"opt_bypass") &&
 	    !strcmp(argv[1],"yes")) {
diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c
index 9ddc6e4..05f692b 100644
--- a/drivers/scsi/aic7xxx/aic79xx_core.c
+++ b/drivers/scsi/aic7xxx/aic79xx_core.c
@@ -5180,7 +5180,7 @@ #ifdef AHD_TARGET_MODE
 			cur_lun = lun;
 			max_lun = lun;
 		}
-		for (cur_lun <= max_lun; cur_lun++) {
+		for (;cur_lun <= max_lun; cur_lun++) {
 			struct ahd_tmode_lstate* lstate;
 
 			lstate = tstate->enabled_luns[cur_lun];
diff --git a/sound/arm/sa11xx-uda1341.c b/sound/arm/sa11xx-uda1341.c
index c7e1b26..e7ed868 100644
--- a/sound/arm/sa11xx-uda1341.c
+++ b/sound/arm/sa11xx-uda1341.c
@@ -987,7 +987,7 @@ static int __init sa11xx_uda1341_init(vo
 		if (platform_get_drvdata(device))
 			return 0;
 		platform_device_unregister(device);
-		err = -ENODEV
+		err = -ENODEV;
 	} else
 		err = PTR_ERR(device);
 	platform_driver_unregister(&sa11xx_uda1341_driver);


_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] potential parse error in ifdef

[Matthew Wilcox]

On Mon, May 21, 2007 at 06:39:12PM +0200, Yoann Padioleau wrote:
> I have made a tool to parse the kernel that does not pre-process the
> source. That means that my parser tries to parse all the code, including
> code in the #else branch or code that is not often compiled because
> the driver is not very used (or not used at all). So, my parser
> sometimes reports parse error not originally detected by gcc. 
> Here is my (first) patch.

These all look good to me.

Acked-by: Matthew Wilcox <matthew@wil.cx>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] potential parse error in ifdef

[Yoann Padioleau]

Matthew Wilcox <matthew@wil.cx> writes:

> On Mon, May 21, 2007 at 06:39:12PM +0200, Yoann Padioleau wrote:
>> I have made a tool to parse the kernel that does not pre-process the
>> source. That means that my parser tries to parse all the code, including
>> code in the #else branch or code that is not often compiled because
>> the driver is not very used (or not used at all). So, my parser
>> sometimes reports parse error not originally detected by gcc. 
>> Here is my (first) patch.
>
> These all look good to me.

Thanks. 

>
> Acked-by: Matthew Wilcox <matthew@wil.cx>

Should I CC my patch to LKML ? 



> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] potential parse error in ifdef

[Håkon Løvdal]

On 21/05/07, Matthew Wilcox <matthew@wil.cx> wrote:
> On Mon, May 21, 2007 at 06:39:12PM +0200, Yoann Padioleau wrote:
> > I have made a tool to parse the kernel that does not pre-process the
> > source. That means that my parser tries to parse all the code, including
> > code in the #else branch or code that is not often compiled because
> > the driver is not very used (or not used at all). So, my parser
> > sometimes reports parse error not originally detected by gcc.
> > Here is my (first) patch.
>
> These all look good to me.

But one question. His tool has found some code segments
that obviously never have been compiled and most likely are
not included in the kernel in any way (because otherwise
I would assume that allyesconfig would have caught them).

Dead, unused code that theoretically would compile is
probably better than dead, unused code that would not
compile, but if the code in question is indeed dead and
unused I would assume that the best option would be to
remove it?

BR Håkon Løvdal

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] potential parse error in ifdef

[Cripps]

best way to answer that: try removing the code and testing with "make
allyesconfig" et al ... The big thing about removing said segments of
code is: where else are bits of code that rely on this hiding
throughout the kernel? Once everything is found, if all of the code
does nothing, haul 'er outta there, else, try and minimise the code
that *is* in there so that the remaining kernel code it "prettier."
-Aaron Cripps

P.S. that IS a good question ...once we have a working patch, that is
tested and does what it's supposed to do, *do* we send it upstream to
the LKML, or does someone work on making a digest of all the patches
sent to [KJ] and send that upstream?

On 5/22/07, Håkon Løvdal <hlovdal@gmail.com> wrote:
> On 21/05/07, Matthew Wilcox <matthew@wil.cx> wrote:
> > On Mon, May 21, 2007 at 06:39:12PM +0200, Yoann Padioleau wrote:
> > > I have made a tool to parse the kernel that does not pre-process the
> > > source. That means that my parser tries to parse all the code, including
> > > code in the #else branch or code that is not often compiled because
> > > the driver is not very used (or not used at all). So, my parser
> > > sometimes reports parse error not originally detected by gcc.
> > > Here is my (first) patch.
> >
> > These all look good to me.
>
> But one question. His tool has found some code segments
> that obviously never have been compiled and most likely are
> not included in the kernel in any way (because otherwise
> I would assume that allyesconfig would have caught them).
>
> Dead, unused code that theoretically would compile is
> probably better than dead, unused code that would not
> compile, but if the code in question is indeed dead and
> unused I would assume that the best option would be to
> remove it?
>
> BR Håkon Løvdal
>
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
>

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] potential parse error in ifdef

[walter harms]

hi Håkon,
you are right in some way but look in these (theoretical) example:

#ifdef LINUX
	donea()
#else
	doneb()
#endif

doneb() will never be used on Linux but it may  be useful for a driver programmer to
run that thing on an other system.

IMHO: add a note like "please explain why we need that dead code or we remove it", send it to the
maintainer and let him remove either the code or add an explanation.

re,
 wh

Håkon Løvdal wrote:
> On 21/05/07, Matthew Wilcox <matthew@wil.cx> wrote:
>> On Mon, May 21, 2007 at 06:39:12PM +0200, Yoann Padioleau wrote:
>> > I have made a tool to parse the kernel that does not pre-process the
>> > source. That means that my parser tries to parse all the code,
>> including
>> > code in the #else branch or code that is not often compiled because
>> > the driver is not very used (or not used at all). So, my parser
>> > sometimes reports parse error not originally detected by gcc.
>> > Here is my (first) patch.
>>
>> These all look good to me.
> 
> But one question. His tool has found some code segments
> that obviously never have been compiled and most likely are
> not included in the kernel in any way (because otherwise
> I would assume that allyesconfig would have caught them).
> 
> Dead, unused code that theoretically would compile is
> probably better than dead, unused code that would not
> compile, but if the code in question is indeed dead and
> unused I would assume that the best option would be to
> remove it?
> 
> BR Håkon Løvdal
> 
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
> 
> 
> 
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] potential parse error in ifdef

[Yoann Padioleau]

"Håkon Løvdal" <hlovdal@gmail.com> writes:

> On 21/05/07, Matthew Wilcox <matthew@wil.cx> wrote:
>> On Mon, May 21, 2007 at 06:39:12PM +0200, Yoann Padioleau wrote:
>> > I have made a tool to parse the kernel that does not pre-process the
>> > source. That means that my parser tries to parse all the code, including
>> > code in the #else branch or code that is not often compiled because
>> > the driver is not very used (or not used at all). So, my parser
>> > sometimes reports parse error not originally detected by gcc.
>> > Here is my (first) patch.
>>
>> These all look good to me.
>
> But one question. His tool has found some code segments
> that obviously never have been compiled 

I think so

> and most likely are
> not included in the kernel in any way (because otherwise
> I would assume that allyesconfig would have caught them).

Allyesconfig does not compile everything. It does not compile for
example source code for other architectures, nor drivers made for other
architectures and it does not try all the ifdef combinaisons.

>
> Dead, unused code that theoretically would compile is
> probably better than dead, unused code that would not
> compile, 

Except my patch can only improve the situation. 

> but if the code in question is indeed dead and
> unused I would assume that the best option would be to
> remove it?
>
> BR Håkon Løvdal
>
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors


_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] potential parse error in ifdef

[Robert P. J. Day]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2103 bytes --]

On Wed, 23 May 2007, Yoann Padioleau wrote:

> "Håkon Løvdal" <hlovdal@gmail.com> writes:
>
> > On 21/05/07, Matthew Wilcox <matthew@wil.cx> wrote:
> >> On Mon, May 21, 2007 at 06:39:12PM +0200, Yoann Padioleau wrote:
> >> > I have made a tool to parse the kernel that does not pre-process the
> >> > source. That means that my parser tries to parse all the code, including
> >> > code in the #else branch or code that is not often compiled because
> >> > the driver is not very used (or not used at all). So, my parser
> >> > sometimes reports parse error not originally detected by gcc.
> >> > Here is my (first) patch.
> >>
> >> These all look good to me.
> >
> > But one question. His tool has found some code segments
> > that obviously never have been compiled
>
> I think so
>
> > and most likely are
> > not included in the kernel in any way (because otherwise
> > I would assume that allyesconfig would have caught them).
>
> Allyesconfig does not compile everything. It does not compile for
> example source code for other architectures, nor drivers made for
> other architectures and it does not try all the ifdef combinaisons.

i wrote a script that did something sort of like this a while back.
after a build with "allyesconfig", the script scanned for all source
files for which a corresponding object file wasn't generated.

needless to say, there were *lots* of those since some source files
represent a choice among several possibilities, while there were
entire subdirectories that weren't compiled for that very reason above
-- they were for a different arch.

but digging into the output, i did find a few cases where some source
files were simply not part of the build process anymore, and submitted
patches to have them removed.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

[-- Attachment #2: Type: text/plain, Size: 187 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

[KJ] [PATCH] potential parse error in ifdef

[Yoann Padioleau]

Hi, 

I have made a tool to parse the kernel that does not pre-process the
source. That means that my parser tries to parse all the code, including
code in the #else branch or code that is not often compiled because
the driver is not very used (or not used at all). So, my parser
sometimes reports parse error not originally detected by gcc. 
Here is my (first) patch.

Signed-off-by: Yoann Padioleau <padator@wanadoo.fr> 
Acked-by: Matthew Wilcox <matthew@wil.cx>

---

 drivers/char/watchdog/ixp2000_wdt.c |    2 +-
 drivers/mtd/devices/pmc551.c        |    2 +-
 drivers/mtd/nand/autcpu12.c         |    2 +-
 drivers/mtd/nand/ppchameleonevb.c   |    2 +-
 drivers/net/amd8111e.c              |    2 +-
 drivers/net/skfp/smt.c              |    2 +-
 drivers/scsi/aic7xxx/aic79xx_core.c |    2 +-
 sound/arm/sa11xx-uda1341.c          |    2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)


diff --git a/drivers/char/watchdog/ixp2000_wdt.c b/drivers/char/watchdog/ixp2000_wdt.c
index fd955db..dc7548d 100644
--- a/drivers/char/watchdog/ixp2000_wdt.c
+++ b/drivers/char/watchdog/ixp2000_wdt.c
@@ -205,7 +205,7 @@ static void __exit ixp2000_wdt_exit(void
 module_init(ixp2000_wdt_init);
 module_exit(ixp2000_wdt_exit);
 
-MODULE_AUTHOR("Deepak Saxena <dsaxena@plexity.net">);
+MODULE_AUTHOR("Deepak Saxena <dsaxena@plexity.net>");
 MODULE_DESCRIPTION("IXP2000 Network Processor Watchdog");
 
 module_param(heartbeat, int, 0);
diff --git a/drivers/mtd/devices/pmc551.c b/drivers/mtd/devices/pmc551.c
index a4873ab..e8f686f 100644
--- a/drivers/mtd/devices/pmc551.c
+++ b/drivers/mtd/devices/pmc551.c
@@ -650,7 +650,7 @@ MODULE_DESCRIPTION(PMC551_VERSION);
  */
 static int msize = 0;
 #if defined(CONFIG_MTD_PMC551_APERTURE_SIZE)
-static int asize = CONFIG_MTD_PMC551_APERTURE_SIZE
+static int asize = CONFIG_MTD_PMC551_APERTURE_SIZE;
 #else
 static int asize = 0;
 #endif
diff --git a/drivers/mtd/nand/autcpu12.c b/drivers/mtd/nand/autcpu12.c
index fe94ae9..e3744eb 100644
--- a/drivers/mtd/nand/autcpu12.c
+++ b/drivers/mtd/nand/autcpu12.c
@@ -101,7 +101,7 @@ static void autcpu12_hwcontrol(struct mt
 	struct nand_chip *chip = mtd->priv;
 
 	if (ctrl & NAND_CTRL_CHANGE) {
-		void __iomem *addr
+		void __iomem *addr;
 		unsigned char bits;
 
 		addr = CS89712_VIRT_BASE + AUTCPU12_SMC_PORT_OFFSET;
diff --git a/drivers/mtd/nand/ppchameleonevb.c b/drivers/mtd/nand/ppchameleonevb.c
index eb7d4d4..38fe9e9 100644
--- a/drivers/mtd/nand/ppchameleonevb.c
+++ b/drivers/mtd/nand/ppchameleonevb.c
@@ -81,7 +81,7 @@ #ifdef CONFIG_MTD_PARTITIONS
  */
 static struct mtd_partition partition_info_hi[] = {
       { .name = "PPChameleon HI Nand Flash",
-	offset = 0,
+	.offset = 0,
 	.size = 128 * 1024 * 1024
       }
 };
diff --git a/drivers/net/amd8111e.c b/drivers/net/amd8111e.c
index 675fe91..84b8164 100644
--- a/drivers/net/amd8111e.c
+++ b/drivers/net/amd8111e.c
@@ -155,7 +155,7 @@ This function will write into PHY regist
 */
 static int amd8111e_write_phy(struct amd8111e_priv* lp,int phy_id, int reg, u32 val)
 {
-	unsigned int repeat = REPEAT_CNT
+	unsigned int repeat = REPEAT_CNT;
 	void __iomem *mmio = lp->mmio;
 	unsigned int reg_val;
 
diff --git a/drivers/net/skfp/smt.c b/drivers/net/skfp/smt.c
index fe84780..75afc1f 100644
--- a/drivers/net/skfp/smt.c
+++ b/drivers/net/skfp/smt.c
@@ -1748,7 +1748,7 @@ char *addr_to_string(struct fddi_addr *a
 #endif
 
 #ifdef	AM29K
-smt_ifconfig(int argc, char *argv[])
+int smt_ifconfig(int argc, char *argv[])
 {
 	if (argc >= 2 && !strcmp(argv[0],"opt_bypass") &&
 	    !strcmp(argv[1],"yes")) {
diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c
index 9ddc6e4..05f692b 100644
--- a/drivers/scsi/aic7xxx/aic79xx_core.c
+++ b/drivers/scsi/aic7xxx/aic79xx_core.c
@@ -5180,7 +5180,7 @@ #ifdef AHD_TARGET_MODE
 			cur_lun = lun;
 			max_lun = lun;
 		}
-		for (cur_lun <= max_lun; cur_lun++) {
+		for (;cur_lun <= max_lun; cur_lun++) {
 			struct ahd_tmode_lstate* lstate;
 
 			lstate = tstate->enabled_luns[cur_lun];
diff --git a/sound/arm/sa11xx-uda1341.c b/sound/arm/sa11xx-uda1341.c
index c7e1b26..e7ed868 100644
--- a/sound/arm/sa11xx-uda1341.c
+++ b/sound/arm/sa11xx-uda1341.c
@@ -987,7 +987,7 @@ static int __init sa11xx_uda1341_init(vo
 		if (platform_get_drvdata(device))
 			return 0;
 		platform_device_unregister(device);
-		err = -ENODEV
+		err = -ENODEV;
 	} else
 		err = PTR_ERR(device);
 	platform_driver_unregister(&sa11xx_uda1341_driver);




_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

[PATCH] potential parse error in ifdef

[Yoann Padioleau]

Hi, 

I have made a tool to parse the kernel that does not pre-process the
source. That means that my parser tries to parse all the code, including
code in the #else branch or code that is not often compiled because
the driver is not very used (or not used at all). So, my parser
sometimes reports parse error not originally detected by gcc. 
Here is my (first) patch.

Signed-off-by: Yoann Padioleau <padator@wanadoo.fr> 
Acked-by: Matthew Wilcox <matthew@wil.cx>

---

 drivers/char/watchdog/ixp2000_wdt.c |    2 +-
 drivers/mtd/devices/pmc551.c        |    2 +-
 drivers/mtd/nand/autcpu12.c         |    2 +-
 drivers/mtd/nand/ppchameleonevb.c   |    2 +-
 drivers/net/amd8111e.c              |    2 +-
 drivers/net/skfp/smt.c              |    2 +-
 drivers/scsi/aic7xxx/aic79xx_core.c |    2 +-
 sound/arm/sa11xx-uda1341.c          |    2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)


diff --git a/drivers/char/watchdog/ixp2000_wdt.c b/drivers/char/watchdog/ixp2000_wdt.c
index fd955db..dc7548d 100644
--- a/drivers/char/watchdog/ixp2000_wdt.c
+++ b/drivers/char/watchdog/ixp2000_wdt.c
@@ -205,7 +205,7 @@ static void __exit ixp2000_wdt_exit(void
 module_init(ixp2000_wdt_init);
 module_exit(ixp2000_wdt_exit);
 
-MODULE_AUTHOR("Deepak Saxena <dsaxena@plexity.net">);
+MODULE_AUTHOR("Deepak Saxena <dsaxena@plexity.net>");
 MODULE_DESCRIPTION("IXP2000 Network Processor Watchdog");
 
 module_param(heartbeat, int, 0);
diff --git a/drivers/mtd/devices/pmc551.c b/drivers/mtd/devices/pmc551.c
index a4873ab..e8f686f 100644
--- a/drivers/mtd/devices/pmc551.c
+++ b/drivers/mtd/devices/pmc551.c
@@ -650,7 +650,7 @@ MODULE_DESCRIPTION(PMC551_VERSION);
  */
 static int msize = 0;
 #if defined(CONFIG_MTD_PMC551_APERTURE_SIZE)
-static int asize = CONFIG_MTD_PMC551_APERTURE_SIZE
+static int asize = CONFIG_MTD_PMC551_APERTURE_SIZE;
 #else
 static int asize = 0;
 #endif
diff --git a/drivers/mtd/nand/autcpu12.c b/drivers/mtd/nand/autcpu12.c
index fe94ae9..e3744eb 100644
--- a/drivers/mtd/nand/autcpu12.c
+++ b/drivers/mtd/nand/autcpu12.c
@@ -101,7 +101,7 @@ static void autcpu12_hwcontrol(struct mt
 	struct nand_chip *chip = mtd->priv;
 
 	if (ctrl & NAND_CTRL_CHANGE) {
-		void __iomem *addr
+		void __iomem *addr;
 		unsigned char bits;
 
 		addr = CS89712_VIRT_BASE + AUTCPU12_SMC_PORT_OFFSET;
diff --git a/drivers/mtd/nand/ppchameleonevb.c b/drivers/mtd/nand/ppchameleonevb.c
index eb7d4d4..38fe9e9 100644
--- a/drivers/mtd/nand/ppchameleonevb.c
+++ b/drivers/mtd/nand/ppchameleonevb.c
@@ -81,7 +81,7 @@ #ifdef CONFIG_MTD_PARTITIONS
  */
 static struct mtd_partition partition_info_hi[] = {
       { .name = "PPChameleon HI Nand Flash",
-	offset = 0,
+	.offset = 0,
 	.size = 128 * 1024 * 1024
       }
 };
diff --git a/drivers/net/amd8111e.c b/drivers/net/amd8111e.c
index 675fe91..84b8164 100644
--- a/drivers/net/amd8111e.c
+++ b/drivers/net/amd8111e.c
@@ -155,7 +155,7 @@ This function will write into PHY regist
 */
 static int amd8111e_write_phy(struct amd8111e_priv* lp,int phy_id, int reg, u32 val)
 {
-	unsigned int repeat = REPEAT_CNT
+	unsigned int repeat = REPEAT_CNT;
 	void __iomem *mmio = lp->mmio;
 	unsigned int reg_val;
 
diff --git a/drivers/net/skfp/smt.c b/drivers/net/skfp/smt.c
index fe84780..75afc1f 100644
--- a/drivers/net/skfp/smt.c
+++ b/drivers/net/skfp/smt.c
@@ -1748,7 +1748,7 @@ char *addr_to_string(struct fddi_addr *a
 #endif
 
 #ifdef	AM29K
-smt_ifconfig(int argc, char *argv[])
+int smt_ifconfig(int argc, char *argv[])
 {
 	if (argc >= 2 && !strcmp(argv[0],"opt_bypass") &&
 	    !strcmp(argv[1],"yes")) {
diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c
index 9ddc6e4..05f692b 100644
--- a/drivers/scsi/aic7xxx/aic79xx_core.c
+++ b/drivers/scsi/aic7xxx/aic79xx_core.c
@@ -5180,7 +5180,7 @@ #ifdef AHD_TARGET_MODE
 			cur_lun = lun;
 			max_lun = lun;
 		}
-		for (cur_lun <= max_lun; cur_lun++) {
+		for (;cur_lun <= max_lun; cur_lun++) {
 			struct ahd_tmode_lstate* lstate;
 
 			lstate = tstate->enabled_luns[cur_lun];
diff --git a/sound/arm/sa11xx-uda1341.c b/sound/arm/sa11xx-uda1341.c
index c7e1b26..e7ed868 100644
--- a/sound/arm/sa11xx-uda1341.c
+++ b/sound/arm/sa11xx-uda1341.c
@@ -987,7 +987,7 @@ static int __init sa11xx_uda1341_init(vo
 		if (platform_get_drvdata(device))
 			return 0;
 		platform_device_unregister(device);
-		err = -ENODEV
+		err = -ENODEV;
 	} else
 		err = PTR_ERR(device);
 	platform_driver_unregister(&sa11xx_uda1341_driver);

[KJ] Re: [PATCH] potential parse error in ifdef

[Jiri Kosina]

On Fri, 25 May 2007, Yoann Padioleau wrote:

> I have made a tool to parse the kernel that does not pre-process the
> source. That means that my parser tries to parse all the code, including
> code in the #else branch or code that is not often compiled because
> the driver is not very used (or not used at all). So, my parser
> sometimes reports parse error not originally detected by gcc. 
> Here is my (first) patch.
>  drivers/char/watchdog/ixp2000_wdt.c |    2 +-
>  drivers/mtd/devices/pmc551.c        |    2 +-
>  drivers/mtd/nand/autcpu12.c         |    2 +-
>  drivers/mtd/nand/ppchameleonevb.c   |    2 +-
>  drivers/net/amd8111e.c              |    2 +-
>  drivers/net/skfp/smt.c              |    2 +-
>  drivers/scsi/aic7xxx/aic79xx_core.c |    2 +-
>  sound/arm/sa11xx-uda1341.c          |    2 +-
>  8 files changed, 8 insertions(+), 8 deletions(-)

As these are totally independent fixes across various subsystems, you 
should probably split the patch into per-subsystem patches and submit them 
separately.

Thanks,

-- 
Jiri Kosina
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [PATCH] potential parse error in ifdef

[Jiri Kosina]

On Fri, 25 May 2007, Yoann Padioleau wrote:

> I have made a tool to parse the kernel that does not pre-process the
> source. That means that my parser tries to parse all the code, including
> code in the #else branch or code that is not often compiled because
> the driver is not very used (or not used at all). So, my parser
> sometimes reports parse error not originally detected by gcc. 
> Here is my (first) patch.
>  drivers/char/watchdog/ixp2000_wdt.c |    2 +-
>  drivers/mtd/devices/pmc551.c        |    2 +-
>  drivers/mtd/nand/autcpu12.c         |    2 +-
>  drivers/mtd/nand/ppchameleonevb.c   |    2 +-
>  drivers/net/amd8111e.c              |    2 +-
>  drivers/net/skfp/smt.c              |    2 +-
>  drivers/scsi/aic7xxx/aic79xx_core.c |    2 +-
>  sound/arm/sa11xx-uda1341.c          |    2 +-
>  8 files changed, 8 insertions(+), 8 deletions(-)

As these are totally independent fixes across various subsystems, you 
should probably split the patch into per-subsystem patches and submit them 
separately.

Thanks,

-- 
Jiri Kosina

[KJ] Re: [PATCH] potential parse error in ifdef

[Andrew Morton]

On Fri, 25 May 2007 13:50:37 +0200 (CEST) Jiri Kosina <jikos@jikos.cz> wrote:

> On Fri, 25 May 2007, Yoann Padioleau wrote:
> 
> > I have made a tool to parse the kernel that does not pre-process the
> > source. That means that my parser tries to parse all the code, including
> > code in the #else branch or code that is not often compiled because
> > the driver is not very used (or not used at all). So, my parser
> > sometimes reports parse error not originally detected by gcc. 
> > Here is my (first) patch.
> >  drivers/char/watchdog/ixp2000_wdt.c |    2 +-
> >  drivers/mtd/devices/pmc551.c        |    2 +-
> >  drivers/mtd/nand/autcpu12.c         |    2 +-
> >  drivers/mtd/nand/ppchameleonevb.c   |    2 +-
> >  drivers/net/amd8111e.c              |    2 +-
> >  drivers/net/skfp/smt.c              |    2 +-
> >  drivers/scsi/aic7xxx/aic79xx_core.c |    2 +-
> >  sound/arm/sa11xx-uda1341.c          |    2 +-
> >  8 files changed, 8 insertions(+), 8 deletions(-)
> 
> As these are totally independent fixes across various subsystems, you 
> should probably split the patch into per-subsystem patches and submit them 
> separately.

That's normally true, yes.  But for a bunch of obviously-better one-line
fixes in code which nobody has even compiled in ages, I think we can bend
the rules a bit and just slam it in.

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [PATCH] potential parse error in ifdef

[Andrew Morton]

On Fri, 25 May 2007 13:50:37 +0200 (CEST) Jiri Kosina <jikos@jikos.cz> wrote:

> On Fri, 25 May 2007, Yoann Padioleau wrote:
> 
> > I have made a tool to parse the kernel that does not pre-process the
> > source. That means that my parser tries to parse all the code, including
> > code in the #else branch or code that is not often compiled because
> > the driver is not very used (or not used at all). So, my parser
> > sometimes reports parse error not originally detected by gcc. 
> > Here is my (first) patch.
> >  drivers/char/watchdog/ixp2000_wdt.c |    2 +-
> >  drivers/mtd/devices/pmc551.c        |    2 +-
> >  drivers/mtd/nand/autcpu12.c         |    2 +-
> >  drivers/mtd/nand/ppchameleonevb.c   |    2 +-
> >  drivers/net/amd8111e.c              |    2 +-
> >  drivers/net/skfp/smt.c              |    2 +-
> >  drivers/scsi/aic7xxx/aic79xx_core.c |    2 +-
> >  sound/arm/sa11xx-uda1341.c          |    2 +-
> >  8 files changed, 8 insertions(+), 8 deletions(-)
> 
> As these are totally independent fixes across various subsystems, you 
> should probably split the patch into per-subsystem patches and submit them 
> separately.

That's normally true, yes.  But for a bunch of obviously-better one-line
fixes in code which nobody has even compiled in ages, I think we can bend
the rules a bit and just slam it in.

[KJ] [PATCH] potential parse error in ifdef part 3

[Yoann Padioleau]

parse errors in ifdefs

Fix various bits of obviously-busted code which we're not happening to
compile, due to ifdefs.


Signed-off-by: Yoann Padioleau <padator@wanadoo.fr> 

 arch/i386/math-emu/fpu_entry.c |    2 +-
 arch/m68k/mac/debug.c          |    2 +-
 arch/ppc/syslib/qspan_pci.c    |    4 ++--
 arch/sh64/kernel/pci_sh5.c     |    8 ++++----
 drivers/cdrom/mcdx.c           |    2 +-
 drivers/tc/zs.c                |    2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)



diff --git a/arch/m68k/mac/debug.c b/arch/m68k/mac/debug.c
index 7a5bed5..e8a5713 100644
--- a/arch/m68k/mac/debug.c
+++ b/arch/m68k/mac/debug.c
@@ -71,7 +71,7 @@ #ifdef DEBUG_SCREEN
 
 	/* calculate current offset */
 	pengoffset = (unsigned char *)mac_videobase +
-		(150+line*2) * mac_rowbytes) + 80 * peng;
+		(150+line*2) * mac_rowbytes + 80 * peng;
 
 	pptr = pengoffset;
 
diff --git a/arch/ppc/syslib/qspan_pci.c b/arch/ppc/syslib/qspan_pci.c
index 85053b2..7a97c74 100644
--- a/arch/ppc/syslib/qspan_pci.c
+++ b/arch/ppc/syslib/qspan_pci.c
@@ -365,13 +365,13 @@ int qspan_pcibios_find_class(unsigned in
 }
 
 void __init
-m8xx_pcibios_fixup(void))
+m8xx_pcibios_fixup(void)
 {
    /* Lots to do here, all board and configuration specific. */
 }
 
 void __init
-m8xx_setup_pci_ptrs(void))
+m8xx_setup_pci_ptrs(void)
 {
 	set_config_access_method(qspan);
 
diff --git a/arch/sh64/kernel/pci_sh5.c b/arch/sh64/kernel/pci_sh5.c
index fb51660..3334f99 100644
--- a/arch/sh64/kernel/pci_sh5.c
+++ b/arch/sh64/kernel/pci_sh5.c
@@ -521,10 +521,10 @@ #if 1
 		bus->resource[0]->start = PCIBIOS_MIN_IO;
 		bus->resource[1]->start = PCIBIOS_MIN_MEM;
 #else
-		bus->resource[0]->end = 0
-		bus->resource[1]->end = 0
-		bus->resource[0]->start =0
-		  bus->resource[1]->start = 0;
+		bus->resource[0]->end = 0;
+		bus->resource[1]->end = 0;
+		bus->resource[0]->start =0;
+		bus->resource[1]->start = 0;
 #endif
 		/* Turn off downstream PF memory address range by default */
 		bus->resource[2]->start = 1024*1024;
diff --git a/drivers/cdrom/mcdx.c b/drivers/cdrom/mcdx.c
index f574962..4310cc8 100644
--- a/drivers/cdrom/mcdx.c
+++ b/drivers/cdrom/mcdx.c
@@ -1053,11 +1053,11 @@ static void __exit mcdx_exit(void)
 	if (unregister_blkdev(MAJOR_NR, "mcdx") != 0) {
 		xwarn("cleanup() unregister_blkdev() failed\n");
 	}
-	blk_cleanup_queue(mcdx_queue);
 #if !MCDX_QUIET
 	else
 	xinfo("cleanup() succeeded\n");
 #endif
+	blk_cleanup_queue(mcdx_queue);
 }
 
 #ifdef MODULE
diff --git a/drivers/tc/zs.c b/drivers/tc/zs.c
index 3524e3f..61de78a 100644
--- a/drivers/tc/zs.c
+++ b/drivers/tc/zs.c
@@ -2182,7 +2182,7 @@ struct dec_serial_hook zs_kgdbhook = {
 	.init_info	= kgdbhook_init_info,
 	.rx_char	= kgdbhook_rx_char,
 	.cflags		= B38400 | CS8 | CLOCAL,
-}
+};
 
 void __init zs_kgdb_hook(int tty_num)
 {
diff --git a/arch/i386/math-emu/fpu_entry.c b/arch/i386/math-emu/fpu_entry.c
index ddf8fa3..1853524 100644
--- a/arch/i386/math-emu/fpu_entry.c
+++ b/arch/i386/math-emu/fpu_entry.c
@@ -754,7 +754,7 @@ #endif /* PECULIAR_486 */
     return -1;
   if ( offset )
     if (__copy_to_user(d+other, (u_char *)&S387->st_space, offset))
-      return -1
+      return -1;
   RE_ENTRANT_CHECK_ON;
 
   return 1;

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

[PATCH] potential parse error in ifdef part 3

[Yoann Padioleau]

parse errors in ifdefs

Fix various bits of obviously-busted code which we're not happening to
compile, due to ifdefs.


Signed-off-by: Yoann Padioleau <padator@wanadoo.fr> 

 arch/i386/math-emu/fpu_entry.c |    2 +-
 arch/m68k/mac/debug.c          |    2 +-
 arch/ppc/syslib/qspan_pci.c    |    4 ++--
 arch/sh64/kernel/pci_sh5.c     |    8 ++++----
 drivers/cdrom/mcdx.c           |    2 +-
 drivers/tc/zs.c                |    2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)



diff --git a/arch/m68k/mac/debug.c b/arch/m68k/mac/debug.c
index 7a5bed5..e8a5713 100644
--- a/arch/m68k/mac/debug.c
+++ b/arch/m68k/mac/debug.c
@@ -71,7 +71,7 @@ #ifdef DEBUG_SCREEN
 
 	/* calculate current offset */
 	pengoffset = (unsigned char *)mac_videobase +
-		(150+line*2) * mac_rowbytes) + 80 * peng;
+		(150+line*2) * mac_rowbytes + 80 * peng;
 
 	pptr = pengoffset;
 
diff --git a/arch/ppc/syslib/qspan_pci.c b/arch/ppc/syslib/qspan_pci.c
index 85053b2..7a97c74 100644
--- a/arch/ppc/syslib/qspan_pci.c
+++ b/arch/ppc/syslib/qspan_pci.c
@@ -365,13 +365,13 @@ int qspan_pcibios_find_class(unsigned in
 }
 
 void __init
-m8xx_pcibios_fixup(void))
+m8xx_pcibios_fixup(void)
 {
    /* Lots to do here, all board and configuration specific. */
 }
 
 void __init
-m8xx_setup_pci_ptrs(void))
+m8xx_setup_pci_ptrs(void)
 {
 	set_config_access_method(qspan);
 
diff --git a/arch/sh64/kernel/pci_sh5.c b/arch/sh64/kernel/pci_sh5.c
index fb51660..3334f99 100644
--- a/arch/sh64/kernel/pci_sh5.c
+++ b/arch/sh64/kernel/pci_sh5.c
@@ -521,10 +521,10 @@ #if 1
 		bus->resource[0]->start = PCIBIOS_MIN_IO;
 		bus->resource[1]->start = PCIBIOS_MIN_MEM;
 #else
-		bus->resource[0]->end = 0
-		bus->resource[1]->end = 0
-		bus->resource[0]->start =0
-		  bus->resource[1]->start = 0;
+		bus->resource[0]->end = 0;
+		bus->resource[1]->end = 0;
+		bus->resource[0]->start =0;
+		bus->resource[1]->start = 0;
 #endif
 		/* Turn off downstream PF memory address range by default */
 		bus->resource[2]->start = 1024*1024;
diff --git a/drivers/cdrom/mcdx.c b/drivers/cdrom/mcdx.c
index f574962..4310cc8 100644
--- a/drivers/cdrom/mcdx.c
+++ b/drivers/cdrom/mcdx.c
@@ -1053,11 +1053,11 @@ static void __exit mcdx_exit(void)
 	if (unregister_blkdev(MAJOR_NR, "mcdx") != 0) {
 		xwarn("cleanup() unregister_blkdev() failed\n");
 	}
-	blk_cleanup_queue(mcdx_queue);
 #if !MCDX_QUIET
 	else
 	xinfo("cleanup() succeeded\n");
 #endif
+	blk_cleanup_queue(mcdx_queue);
 }
 
 #ifdef MODULE
diff --git a/drivers/tc/zs.c b/drivers/tc/zs.c
index 3524e3f..61de78a 100644
--- a/drivers/tc/zs.c
+++ b/drivers/tc/zs.c
@@ -2182,7 +2182,7 @@ struct dec_serial_hook zs_kgdbhook = {
 	.init_info	= kgdbhook_init_info,
 	.rx_char	= kgdbhook_rx_char,
 	.cflags		= B38400 | CS8 | CLOCAL,
-}
+};
 
 void __init zs_kgdb_hook(int tty_num)
 {
diff --git a/arch/i386/math-emu/fpu_entry.c b/arch/i386/math-emu/fpu_entry.c
index ddf8fa3..1853524 100644
--- a/arch/i386/math-emu/fpu_entry.c
+++ b/arch/i386/math-emu/fpu_entry.c
@@ -754,7 +754,7 @@ #endif /* PECULIAR_486 */
     return -1;
   if ( offset )
     if (__copy_to_user(d+other, (u_char *)&S387->st_space, offset))
-      return -1
+      return -1;
   RE_ENTRANT_CHECK_ON;
 
   return 1;

[KJ] Re: [PATCH] potential parse error in ifdef part 3

[Geert Uytterhoeven]

On Mon, 4 Jun 2007, Yoann Padioleau wrote:
> parse errors in ifdefs
> 
> Fix various bits of obviously-busted code which we're not happening to
> compile, due to ifdefs.

> --- a/arch/m68k/mac/debug.c
> +++ b/arch/m68k/mac/debug.c
> @@ -71,7 +71,7 @@ #ifdef DEBUG_SCREEN
>  
>  	/* calculate current offset */
>  	pengoffset = (unsigned char *)mac_videobase +
> -		(150+line*2) * mac_rowbytes) + 80 * peng;
> +		(150+line*2) * mac_rowbytes + 80 * peng;
>  
>  	pptr = pengoffset;

Already fixed in 4eb527a0ca83de28e773371f42abad2ab1ed7fdf

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [PATCH] potential parse error in ifdef part 3

[Geert Uytterhoeven]

On Mon, 4 Jun 2007, Yoann Padioleau wrote:
> parse errors in ifdefs
> 
> Fix various bits of obviously-busted code which we're not happening to
> compile, due to ifdefs.

> --- a/arch/m68k/mac/debug.c
> +++ b/arch/m68k/mac/debug.c
> @@ -71,7 +71,7 @@ #ifdef DEBUG_SCREEN
>  
>  	/* calculate current offset */
>  	pengoffset = (unsigned char *)mac_videobase +
> -		(150+line*2) * mac_rowbytes) + 80 * peng;
> +		(150+line*2) * mac_rowbytes + 80 * peng;
>  
>  	pptr = pengoffset;

Already fixed in 4eb527a0ca83de28e773371f42abad2ab1ed7fdf

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds