All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption.
@ 2022-01-11  7:55 Ashish Arora
  2022-01-11  8:36   ` Jani Nikula
                   ` (4 more replies)
  0 siblings, 5 replies; 14+ messages in thread
From: Ashish Arora @ 2022-01-11  7:55 UTC (permalink / raw)
  To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com
  Cc: intel-gfx@lists.freedesktop.org, Linux Kernel Mailing List

From: Ashish Arora <ashisharora.linux@outlook.com>

On certain 4k panels and Macs, the BIOS framebuffer is larger than what
panel requires causing display corruption. Introduce a check for the same.


Signed-off-by: Ashish Arora <ashisharora.linux@outlook.com>
Reviewed-by: Aun-Ali Zaidi <admin@kodeit.net>
---
V2 :- Use != instead of < and >
V3 :- Mention Macs (Thanks to Orlando)
 drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index 842c04e63..16b1c82b2 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -181,10 +181,10 @@ static int intelfb_create(struct drm_fb_helper *helper,
 	int ret;
 
 	if (intel_fb &&
-	    (sizes->fb_width > intel_fb->base.width ||
-	     sizes->fb_height > intel_fb->base.height)) {
+	    (sizes->fb_width != intel_fb->base.width ||
+	     sizes->fb_height != intel_fb->base.height)) {
 		drm_dbg_kms(&dev_priv->drm,
-			    "BIOS fb too small (%dx%d), we require (%dx%d),"
+			    "BIOS fb not valid (%dx%d), we require (%dx%d),"
 			    " releasing it\n",
 			    intel_fb->base.width, intel_fb->base.height,
 			    sizes->fb_width, sizes->fb_height);
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2025-01-07 14:52 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-11  7:55 [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption Ashish Arora
2022-01-11  8:36 ` Jani Nikula
2022-01-11  8:36   ` Jani Nikula
2022-01-11 18:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Discard large BIOS framebuffers causing display corruption. (rev3) Patchwork
2022-01-11 23:33 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-01-12 13:37 ` [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption Ville Syrjälä
2022-01-12 13:37   ` Ville Syrjälä
2022-01-12 13:42   ` Ashish Arora
2022-01-30  9:27   ` Ashish Arora
2025-01-03 11:15 ` [BUG] The bottom and right edges on the tty are not shown on Apple T2 MacBooks with Retina display Aditya Garg
2025-01-03 14:14   ` Jani Nikula
2025-01-07 12:25     ` Aditya Garg
2025-01-07 12:32       ` Jani Nikula
2025-01-07 14:32         ` Aditya Garg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.