All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption.
@ 2022-01-11  7:55 Ashish Arora
  2022-01-11  8:36   ` Jani Nikula
                   ` (4 more replies)
  0 siblings, 5 replies; 14+ messages in thread
From: Ashish Arora @ 2022-01-11  7:55 UTC (permalink / raw)
  To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com
  Cc: intel-gfx@lists.freedesktop.org, Linux Kernel Mailing List

From: Ashish Arora <ashisharora.linux@outlook.com>

On certain 4k panels and Macs, the BIOS framebuffer is larger than what
panel requires causing display corruption. Introduce a check for the same.


Signed-off-by: Ashish Arora <ashisharora.linux@outlook.com>
Reviewed-by: Aun-Ali Zaidi <admin@kodeit.net>
---
V2 :- Use != instead of < and >
V3 :- Mention Macs (Thanks to Orlando)
 drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index 842c04e63..16b1c82b2 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -181,10 +181,10 @@ static int intelfb_create(struct drm_fb_helper *helper,
 	int ret;
 
 	if (intel_fb &&
-	    (sizes->fb_width > intel_fb->base.width ||
-	     sizes->fb_height > intel_fb->base.height)) {
+	    (sizes->fb_width != intel_fb->base.width ||
+	     sizes->fb_height != intel_fb->base.height)) {
 		drm_dbg_kms(&dev_priv->drm,
-			    "BIOS fb too small (%dx%d), we require (%dx%d),"
+			    "BIOS fb not valid (%dx%d), we require (%dx%d),"
 			    " releasing it\n",
 			    intel_fb->base.width, intel_fb->base.height,
 			    sizes->fb_width, sizes->fb_height);
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption.
  2022-01-11  7:55 [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption Ashish Arora
@ 2022-01-11  8:36   ` Jani Nikula
  2022-01-11 18:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Discard large BIOS framebuffers causing display corruption. (rev3) Patchwork
                     ` (3 subsequent siblings)
  4 siblings, 0 replies; 14+ messages in thread
From: Jani Nikula @ 2022-01-11  8:36 UTC (permalink / raw)
  To: Ashish Arora, joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com
  Cc: intel-gfx@lists.freedesktop.org, Linux Kernel Mailing List

On Tue, 11 Jan 2022, Ashish Arora <ashisharora.linux@outlook.com> wrote:
> From: Ashish Arora <ashisharora.linux@outlook.com>
>
> On certain 4k panels and Macs, the BIOS framebuffer is larger than what
> panel requires causing display corruption. Introduce a check for the same.
>
>
> Signed-off-by: Ashish Arora <ashisharora.linux@outlook.com>
> Reviewed-by: Aun-Ali Zaidi <admin@kodeit.net>

I'll defer to Ville on this one, Cc'd.

BR,
Jani.



> ---
> V2 :- Use != instead of < and >
> V3 :- Mention Macs (Thanks to Orlando)
>  drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index 842c04e63..16b1c82b2 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -181,10 +181,10 @@ static int intelfb_create(struct drm_fb_helper *helper,
>  	int ret;
>  
>  	if (intel_fb &&
> -	    (sizes->fb_width > intel_fb->base.width ||
> -	     sizes->fb_height > intel_fb->base.height)) {
> +	    (sizes->fb_width != intel_fb->base.width ||
> +	     sizes->fb_height != intel_fb->base.height)) {
>  		drm_dbg_kms(&dev_priv->drm,
> -			    "BIOS fb too small (%dx%d), we require (%dx%d),"
> +			    "BIOS fb not valid (%dx%d), we require (%dx%d),"
>  			    " releasing it\n",
>  			    intel_fb->base.width, intel_fb->base.height,
>  			    sizes->fb_width, sizes->fb_height);

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption.
@ 2022-01-11  8:36   ` Jani Nikula
  0 siblings, 0 replies; 14+ messages in thread
From: Jani Nikula @ 2022-01-11  8:36 UTC (permalink / raw)
  To: Ashish Arora, joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com
  Cc: Linux Kernel Mailing List, intel-gfx@lists.freedesktop.org,
	ville.syrjala

On Tue, 11 Jan 2022, Ashish Arora <ashisharora.linux@outlook.com> wrote:
> From: Ashish Arora <ashisharora.linux@outlook.com>
>
> On certain 4k panels and Macs, the BIOS framebuffer is larger than what
> panel requires causing display corruption. Introduce a check for the same.
>
>
> Signed-off-by: Ashish Arora <ashisharora.linux@outlook.com>
> Reviewed-by: Aun-Ali Zaidi <admin@kodeit.net>

I'll defer to Ville on this one, Cc'd.

BR,
Jani.



> ---
> V2 :- Use != instead of < and >
> V3 :- Mention Macs (Thanks to Orlando)
>  drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index 842c04e63..16b1c82b2 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -181,10 +181,10 @@ static int intelfb_create(struct drm_fb_helper *helper,
>  	int ret;
>  
>  	if (intel_fb &&
> -	    (sizes->fb_width > intel_fb->base.width ||
> -	     sizes->fb_height > intel_fb->base.height)) {
> +	    (sizes->fb_width != intel_fb->base.width ||
> +	     sizes->fb_height != intel_fb->base.height)) {
>  		drm_dbg_kms(&dev_priv->drm,
> -			    "BIOS fb too small (%dx%d), we require (%dx%d),"
> +			    "BIOS fb not valid (%dx%d), we require (%dx%d),"
>  			    " releasing it\n",
>  			    intel_fb->base.width, intel_fb->base.height,
>  			    sizes->fb_width, sizes->fb_height);

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Discard large BIOS framebuffers causing display corruption. (rev3)
  2022-01-11  7:55 [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption Ashish Arora
  2022-01-11  8:36   ` Jani Nikula
@ 2022-01-11 18:17 ` Patchwork
  2022-01-11 23:33 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2022-01-11 18:17 UTC (permalink / raw)
  To: Ashish Arora; +Cc: intel-gfx

[-- Attachment #1: Type: text/plain, Size: 7881 bytes --]

== Series Details ==

Series: drm/i915: Discard large BIOS framebuffers causing display corruption. (rev3)
URL   : https://patchwork.freedesktop.org/series/98683/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11066 -> Patchwork_21968
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/index.html

Participating hosts (43 -> 43)
------------------------------

  Additional (2): bat-adlp-4 fi-pnv-d510 
  Missing    (2): fi-bsw-cyan fi-bdw-samus 

Known issues
------------

  Here are the changes found in Patchwork_21968 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_huc_copy@huc-copy:
    - fi-skl-6600u:       NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/fi-skl-6600u/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - bat-adlp-4:         NOTRUN -> [SKIP][2] ([i915#4613]) +3 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/bat-adlp-4/igt@gem_lmem_swapping@basic.html

  * igt@gem_lmem_swapping@verify-random:
    - fi-skl-6600u:       NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/fi-skl-6600u/igt@gem_lmem_swapping@verify-random.html

  * igt@gem_tiled_pread_basic:
    - bat-adlp-4:         NOTRUN -> [SKIP][4] ([i915#3282])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/bat-adlp-4/igt@gem_tiled_pread_basic.html

  * igt@i915_selftest@live@hangcheck:
    - fi-snb-2600:        [PASS][5] -> [INCOMPLETE][6] ([i915#3921])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/fi-snb-2600/igt@i915_selftest@live@hangcheck.html

  * igt@i915_selftest@live@hugepages:
    - bat-adlp-4:         NOTRUN -> [DMESG-WARN][7] ([i915#1888])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/bat-adlp-4/igt@i915_selftest@live@hugepages.html

  * igt@i915_selftest@live@requests:
    - fi-pnv-d510:        NOTRUN -> [DMESG-FAIL][8] ([i915#2927] / [i915#4528])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/fi-pnv-d510/igt@i915_selftest@live@requests.html

  * igt@kms_chamelium@dp-crc-fast:
    - bat-adlp-4:         NOTRUN -> [SKIP][9] ([fdo#111827]) +8 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/bat-adlp-4/igt@kms_chamelium@dp-crc-fast.html

  * igt@kms_chamelium@vga-edid-read:
    - fi-skl-6600u:       NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/fi-skl-6600u/igt@kms_chamelium@vga-edid-read.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - fi-skl-6600u:       NOTRUN -> [SKIP][11] ([fdo#109271]) +2 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/fi-skl-6600u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
    - bat-adlp-4:         NOTRUN -> [SKIP][12] ([i915#4103]) +1 similar issue
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/bat-adlp-4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_force_connector_basic@force-load-detect:
    - bat-adlp-4:         NOTRUN -> [SKIP][13] ([fdo#109285])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/bat-adlp-4/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
    - fi-skl-6600u:       NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#533])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/fi-skl-6600u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html

  * igt@kms_psr@primary_page_flip:
    - fi-skl-6600u:       NOTRUN -> [FAIL][15] ([i915#4547])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/fi-skl-6600u/igt@kms_psr@primary_page_flip.html

  * igt@prime_vgem@basic-fence-read:
    - bat-adlp-4:         NOTRUN -> [SKIP][16] ([i915#3291] / [i915#3708]) +2 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/bat-adlp-4/igt@prime_vgem@basic-fence-read.html

  * igt@prime_vgem@basic-userptr:
    - fi-pnv-d510:        NOTRUN -> [SKIP][17] ([fdo#109271]) +39 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/fi-pnv-d510/igt@prime_vgem@basic-userptr.html
    - bat-adlp-4:         NOTRUN -> [SKIP][18] ([i915#3301] / [i915#3708])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/bat-adlp-4/igt@prime_vgem@basic-userptr.html

  * igt@runner@aborted:
    - fi-pnv-d510:        NOTRUN -> [FAIL][19] ([fdo#109271] / [i915#2403] / [i915#4312])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/fi-pnv-d510/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@kms_flip@basic-flip-vs-wf_vblank@a-vga1:
    - fi-bwr-2160:        [FAIL][20] ([i915#2122]) -> [PASS][21]
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/fi-bwr-2160/igt@kms_flip@basic-flip-vs-wf_vblank@a-vga1.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/fi-bwr-2160/igt@kms_flip@basic-flip-vs-wf_vblank@a-vga1.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-cml-u2:          [DMESG-WARN][22] ([i915#4269]) -> [PASS][23]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
  [i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
  [i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533


Build changes
-------------

  * Linux: CI_DRM_11066 -> Patchwork_21968

  CI-20190529: 20190529
  CI_DRM_11066: fc076e8fc52ed40fee33f416a4475a57219011a5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_6326: ec75f64fcbcf4aac58fbf1bf629e8f59b19db4ce @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_21968: f155d5e19eea7b65033472327d1f2e95b883fbf0 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

f155d5e19eea drm/i915: Discard large BIOS framebuffers causing display corruption.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/index.html

[-- Attachment #2: Type: text/html, Size: 9575 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Discard large BIOS framebuffers causing display corruption. (rev3)
  2022-01-11  7:55 [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption Ashish Arora
  2022-01-11  8:36   ` Jani Nikula
  2022-01-11 18:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Discard large BIOS framebuffers causing display corruption. (rev3) Patchwork
@ 2022-01-11 23:33 ` Patchwork
  2022-01-12 13:37   ` Ville Syrjälä
  2025-01-03 11:15 ` [BUG] The bottom and right edges on the tty are not shown on Apple T2 MacBooks with Retina display Aditya Garg
  4 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2022-01-11 23:33 UTC (permalink / raw)
  To: Ashish Arora; +Cc: intel-gfx

[-- Attachment #1: Type: text/plain, Size: 30299 bytes --]

== Series Details ==

Series: drm/i915: Discard large BIOS framebuffers causing display corruption. (rev3)
URL   : https://patchwork.freedesktop.org/series/98683/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11066_full -> Patchwork_21968_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_21968_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_21968_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_21968_full:

### CI changes ###

#### Possible regressions ####

  * boot:
    - shard-iclb:         ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [FAIL][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb3/boot.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb8/boot.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb8/boot.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb8/boot.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb7/boot.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb1/boot.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb7/boot.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb7/boot.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb1/boot.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb1/boot.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb1/boot.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb6/boot.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb6/boot.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb2/boot.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb2/boot.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb6/boot.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb5/boot.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb2/boot.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb5/boot.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb5/boot.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb4/boot.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb3/boot.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb4/boot.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb3/boot.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb4/boot.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb1/boot.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb1/boot.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb2/boot.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb2/boot.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb2/boot.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb3/boot.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb3/boot.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb3/boot.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb4/boot.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb4/boot.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb4/boot.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb5/boot.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb5/boot.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb5/boot.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb5/boot.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb5/boot.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb6/boot.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb6/boot.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb6/boot.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb7/boot.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb7/boot.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb7/boot.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb8/boot.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb8/boot.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb8/boot.html
    - shard-snb:          ([PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57], [PASS][58], [PASS][59], [PASS][60], [PASS][61], [PASS][62], [PASS][63], [PASS][64], [PASS][65], [PASS][66], [PASS][67], [PASS][68], [PASS][69], [PASS][70], [PASS][71], [PASS][72], [PASS][73], [PASS][74], [PASS][75]) -> ([PASS][76], [PASS][77], [PASS][78], [PASS][79], [PASS][80], [PASS][81], [PASS][82], [PASS][83], [PASS][84], [PASS][85], [PASS][86], [PASS][87], [PASS][88], [PASS][89], [PASS][90], [FAIL][91], [PASS][92], [PASS][93], [PASS][94], [PASS][95], [PASS][96], [PASS][97], [PASS][98], [PASS][99], [PASS][100])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb7/boot.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb7/boot.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb7/boot.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb7/boot.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb7/boot.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb6/boot.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb6/boot.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb6/boot.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb6/boot.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb6/boot.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb5/boot.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb5/boot.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb5/boot.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb5/boot.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb5/boot.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb4/boot.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb4/boot.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb4/boot.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb4/boot.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb4/boot.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb2/boot.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb2/boot.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb2/boot.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb2/boot.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-snb2/boot.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb5/boot.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb4/boot.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb4/boot.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb4/boot.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb4/boot.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb4/boot.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb2/boot.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb2/boot.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb2/boot.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb2/boot.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb2/boot.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb7/boot.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb7/boot.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb7/boot.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb7/boot.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb6/boot.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb6/boot.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb6/boot.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb6/boot.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb6/boot.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb6/boot.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb5/boot.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb5/boot.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb5/boot.html
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-snb5/boot.html

  

### IGT changes ###

#### Possible regressions ####

  * igt@i915_pm_rpm@system-suspend-modeset:
    - shard-iclb:         [PASS][101] -> [SKIP][102]
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb2/igt@i915_pm_rpm@system-suspend-modeset.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb5/igt@i915_pm_rpm@system-suspend-modeset.html

  
Known issues
------------

  Here are the changes found in Patchwork_21968_full that come from known issues:

### CI changes ###

#### Possible fixes ####

  * boot:
    - shard-glk:          ([PASS][103], [PASS][104], [PASS][105], [PASS][106], [PASS][107], [PASS][108], [PASS][109], [PASS][110], [PASS][111], [PASS][112], [PASS][113], [PASS][114], [PASS][115], [PASS][116], [PASS][117], [PASS][118], [PASS][119], [PASS][120], [PASS][121], [PASS][122], [PASS][123], [FAIL][124], [PASS][125], [PASS][126], [PASS][127]) ([i915#4392]) -> ([PASS][128], [PASS][129], [PASS][130], [PASS][131], [PASS][132], [PASS][133], [PASS][134], [PASS][135], [PASS][136], [PASS][137], [PASS][138], [PASS][139], [PASS][140], [PASS][141], [PASS][142], [PASS][143], [PASS][144], [PASS][145], [PASS][146], [PASS][147], [PASS][148], [PASS][149], [PASS][150], [PASS][151], [PASS][152])
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk1/boot.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk1/boot.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk1/boot.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk2/boot.html
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk2/boot.html
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk2/boot.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk3/boot.html
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk3/boot.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk3/boot.html
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk4/boot.html
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk4/boot.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk4/boot.html
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk5/boot.html
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk5/boot.html
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk5/boot.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk6/boot.html
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk6/boot.html
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk7/boot.html
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk7/boot.html
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk7/boot.html
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk8/boot.html
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk8/boot.html
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk8/boot.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk9/boot.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk9/boot.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk4/boot.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk4/boot.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk5/boot.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk5/boot.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk5/boot.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk6/boot.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk6/boot.html
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk7/boot.html
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk7/boot.html
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk8/boot.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk8/boot.html
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk8/boot.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk9/boot.html
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk9/boot.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk9/boot.html
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk1/boot.html
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk1/boot.html
   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk1/boot.html
   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk2/boot.html
   [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk2/boot.html
   [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk2/boot.html
   [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk3/boot.html
   [150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk3/boot.html
   [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk3/boot.html
   [152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk4/boot.html

  

### IGT changes ###

#### Issues hit ####

  * igt@gem_create@create-massive:
    - shard-apl:          NOTRUN -> [DMESG-WARN][153] ([i915#3002])
   [153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-apl3/igt@gem_create@create-massive.html

  * igt@gem_eio@unwedge-stress:
    - shard-tglb:         [PASS][154] -> [FAIL][155] ([i915#232])
   [154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-tglb6/igt@gem_eio@unwedge-stress.html
   [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb5/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_balancer@parallel-keep-submit-fence:
    - shard-iclb:         [PASS][156] -> [SKIP][157] ([i915#4525]) +1 similar issue
   [156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb4/igt@gem_exec_balancer@parallel-keep-submit-fence.html
   [157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb3/igt@gem_exec_balancer@parallel-keep-submit-fence.html

  * igt@gem_exec_capture@pi@rcs0:
    - shard-skl:          NOTRUN -> [INCOMPLETE][158] ([i915#4547])
   [158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-skl8/igt@gem_exec_capture@pi@rcs0.html

  * igt@gem_exec_fair@basic-none-solo@rcs0:
    - shard-glk:          NOTRUN -> [FAIL][159] ([i915#2842])
   [159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk6/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-glk:          [PASS][160] -> [FAIL][161] ([i915#2842]) +1 similar issue
   [160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_lmem_swapping@basic:
    - shard-kbl:          NOTRUN -> [SKIP][162] ([fdo#109271] / [i915#4613])
   [162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-kbl7/igt@gem_lmem_swapping@basic.html

  * igt@gem_lmem_swapping@heavy-verify-random:
    - shard-skl:          NOTRUN -> [SKIP][163] ([fdo#109271] / [i915#4613]) +1 similar issue
   [163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-skl8/igt@gem_lmem_swapping@heavy-verify-random.html

  * igt@gem_lmem_swapping@random:
    - shard-apl:          NOTRUN -> [SKIP][164] ([fdo#109271] / [i915#4613])
   [164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-apl3/igt@gem_lmem_swapping@random.html

  * igt@gem_pread@exhaustion:
    - shard-glk:          NOTRUN -> [WARN][165] ([i915#2658])
   [165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk6/igt@gem_pread@exhaustion.html

  * igt@gem_pwrite@basic-exhaustion:
    - shard-kbl:          NOTRUN -> [WARN][166] ([i915#2658])
   [166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-kbl7/igt@gem_pwrite@basic-exhaustion.html

  * igt@gem_pxp@verify-pxp-execution-after-suspend-resume:
    - shard-tglb:         NOTRUN -> [SKIP][167] ([i915#4270]) +1 similar issue
   [167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb7/igt@gem_pxp@verify-pxp-execution-after-suspend-resume.html

  * igt@gem_render_copy@linear-to-vebox-y-tiled:
    - shard-apl:          NOTRUN -> [SKIP][168] ([fdo#109271]) +35 similar issues
   [168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-apl3/igt@gem_render_copy@linear-to-vebox-y-tiled.html

  * igt@gem_render_copy@y-tiled-to-vebox-x-tiled:
    - shard-glk:          NOTRUN -> [SKIP][169] ([fdo#109271]) +37 similar issues
   [169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk6/igt@gem_render_copy@y-tiled-to-vebox-x-tiled.html

  * igt@gem_userptr_blits@dmabuf-sync:
    - shard-iclb:         NOTRUN -> [SKIP][170] ([i915#3323])
   [170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb2/igt@gem_userptr_blits@dmabuf-sync.html
    - shard-tglb:         NOTRUN -> [SKIP][171] ([i915#3323])
   [171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb8/igt@gem_userptr_blits@dmabuf-sync.html

  * igt@gem_userptr_blits@unsync-overlap:
    - shard-tglb:         NOTRUN -> [SKIP][172] ([i915#3297])
   [172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb7/igt@gem_userptr_blits@unsync-overlap.html

  * igt@gen9_exec_parse@allowed-all:
    - shard-glk:          [PASS][173] -> [DMESG-WARN][174] ([i915#1436] / [i915#716])
   [173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk2/igt@gen9_exec_parse@allowed-all.html
   [174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk1/igt@gen9_exec_parse@allowed-all.html

  * igt@gen9_exec_parse@shadow-peek:
    - shard-tglb:         NOTRUN -> [SKIP][175] ([i915#2527] / [i915#2856]) +1 similar issue
   [175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb8/igt@gen9_exec_parse@shadow-peek.html
    - shard-iclb:         NOTRUN -> [SKIP][176] ([i915#2856])
   [176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb2/igt@gen9_exec_parse@shadow-peek.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
    - shard-kbl:          NOTRUN -> [SKIP][177] ([fdo#109271] / [i915#1937])
   [177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-kbl6/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html

  * igt@i915_pm_rc6_residency@media-rc6-accuracy:
    - shard-tglb:         NOTRUN -> [SKIP][178] ([fdo#109289] / [fdo#111719])
   [178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb7/igt@i915_pm_rc6_residency@media-rc6-accuracy.html

  * igt@i915_suspend@fence-restore-tiled2untiled:
    - shard-kbl:          [PASS][179] -> [DMESG-WARN][180] ([i915#180]) +1 similar issue
   [179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-kbl3/igt@i915_suspend@fence-restore-tiled2untiled.html
   [180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-kbl4/igt@i915_suspend@fence-restore-tiled2untiled.html

  * igt@kms_big_fb@linear-32bpp-rotate-180:
    - shard-glk:          [PASS][181] -> [DMESG-WARN][182] ([i915#118]) +1 similar issue
   [181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk6/igt@kms_big_fb@linear-32bpp-rotate-180.html
   [182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk3/igt@kms_big_fb@linear-32bpp-rotate-180.html

  * igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
    - shard-skl:          NOTRUN -> [SKIP][183] ([fdo#109271] / [i915#3777])
   [183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-skl8/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip.html

  * igt@kms_big_fb@y-tiled-8bpp-rotate-90:
    - shard-tglb:         NOTRUN -> [SKIP][184] ([fdo#111614])
   [184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb7/igt@kms_big_fb@y-tiled-8bpp-rotate-90.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
    - shard-skl:          NOTRUN -> [FAIL][185] ([i915#3743])
   [185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-skl1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
    - shard-apl:          NOTRUN -> [SKIP][186] ([fdo#109271] / [i915#3777])
   [186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-apl3/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html

  * igt@kms_big_fb@yf-tiled-64bpp-rotate-90:
    - shard-tglb:         NOTRUN -> [SKIP][187] ([fdo#111615])
   [187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb7/igt@kms_big_fb@yf-tiled-64bpp-rotate-90.html

  * igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs:
    - shard-iclb:         NOTRUN -> [SKIP][188] ([fdo#109278]) +1 similar issue
   [188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb2/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs.html

  * igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
    - shard-kbl:          NOTRUN -> [SKIP][189] ([fdo#109271] / [i915#3886]) +4 similar issues
   [189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-kbl6/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
    - shard-glk:          NOTRUN -> [SKIP][190] ([fdo#109271] / [i915#3886])
   [190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk6/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
    - shard-apl:          NOTRUN -> [SKIP][191] ([fdo#109271] / [i915#3886])
   [191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-apl3/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
    - shard-skl:          NOTRUN -> [SKIP][192] ([fdo#109271] / [i915#3886]) +4 similar issues
   [192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-skl2/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][193] ([i915#3689] / [i915#3886])
   [193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb7/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_gen12_mc_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][194] ([i915#3689]) +1 similar issue
   [194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb7/igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-d-bad-pixel-format-yf_tiled_ccs:
    - shard-kbl:          NOTRUN -> [SKIP][195] ([fdo#109271]) +41 similar issues
   [195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-kbl6/igt@kms_ccs@pipe-d-bad-pixel-format-yf_tiled_ccs.html

  * igt@kms_ccs@pipe-d-crc-primary-rotation-180-yf_tiled_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][196] ([fdo#111615] / [i915#3689]) +2 similar issues
   [196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb7/igt@kms_ccs@pipe-d-crc-primary-rotation-180-yf_tiled_ccs.html

  * igt@kms_chamelium@common-hpd-after-suspend:
    - shard-apl:          NOTRUN -> [SKIP][197] ([fdo#109271] / [fdo#111827]) +3 similar issues
   [197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-apl2/igt@kms_chamelium@common-hpd-after-suspend.html

  * igt@kms_chamelium@vga-hpd-after-suspend:
    - shard-glk:          NOTRUN -> [SKIP][198] ([fdo#109271] / [fdo#111827]) +2 similar issues
   [198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-glk6/igt@kms_chamelium@vga-hpd-after-suspend.html

  * igt@kms_color@pipe-d-ctm-0-5:
    - shard-skl:          NOTRUN -> [SKIP][199] ([fdo#109271]) +90 similar issues
   [199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-skl8/igt@kms_color@pipe-d-ctm-0-5.html

  * igt@kms_color_chamelium@pipe-a-ctm-0-75:
    - shard-kbl:          NOTRUN -> [SKIP][200] ([fdo#109271] / [fdo#111827]) +3 similar issues
   [200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-kbl6/igt@kms_color_chamelium@pipe-a-ctm-0-75.html

  * igt@kms_color_chamelium@pipe-d-ctm-red-to-blue:
    - shard-tglb:         NOTRUN -> [SKIP][201] ([fdo#109284] / [fdo#111827]) +3 similar issues
   [201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb8/igt@kms_color_chamelium@pipe-d-ctm-red-to-blue.html
    - shard-skl:          NOTRUN -> [SKIP][202] ([fdo#109271] / [fdo#111827]) +5 similar issues
   [202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-skl1/igt@kms_color_chamelium@pipe-d-ctm-red-to-blue.html
    - shard-iclb:         NOTRUN -> [SKIP][203] ([fdo#109278] / [fdo#109284] / [fdo#111827])
   [203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb2/igt@kms_color_chamelium@pipe-d-ctm-red-to-blue.html

  * igt@kms_content_protection@srm:
    - shard-tglb:         NOTRUN -> [SKIP][204] ([i915#1063])
   [204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb7/igt@kms_content_protection@srm.html

  * igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding:
    - shard-tglb:         NOTRUN -> [SKIP][205] ([i915#3359]) +2 similar issues
   [205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb1/igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding.html

  * igt@kms_cursor_crc@pipe-b-cursor-512x170-random:
    - shard-tglb:         NOTRUN -> [SKIP][206] ([fdo#109279] / [i915#3359])
   [206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb7/igt@kms_cursor_crc@pipe-b-cursor-512x170-random.html

  * igt@kms_cursor_crc@pipe-c-cursor-32x32-sliding:
    - shard-tglb:         NOTRUN -> [SKIP][207] ([i915#3319])
   [207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-32x32-sliding.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - shard-tglb:         NOTRUN -> [SKIP][208] ([i915#4103])
   [208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-tglb7/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-iclb:         [PASS][209] -> [FAIL][210] ([i915#2346])
   [209]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21968/index.html

[-- Attachment #2: Type: text/html, Size: 32407 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption.
  2022-01-11  7:55 [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption Ashish Arora
@ 2022-01-12 13:37   ` Ville Syrjälä
  2022-01-11 18:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Discard large BIOS framebuffers causing display corruption. (rev3) Patchwork
                     ` (3 subsequent siblings)
  4 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjälä @ 2022-01-12 13:37 UTC (permalink / raw)
  To: Ashish Arora; +Cc: intel-gfx@lists.freedesktop.org, Linux Kernel Mailing List

On Tue, Jan 11, 2022 at 07:55:22AM +0000, Ashish Arora wrote:
> From: Ashish Arora <ashisharora.linux@outlook.com>
> 
> On certain 4k panels and Macs, the BIOS framebuffer is larger than what
> panel requires causing display corruption. Introduce a check for the same.

If a larger fb causes corruption then there is a real bug somewhere.

> 
> 
> Signed-off-by: Ashish Arora <ashisharora.linux@outlook.com>
> Reviewed-by: Aun-Ali Zaidi <admin@kodeit.net>
> ---
> V2 :- Use != instead of < and >
> V3 :- Mention Macs (Thanks to Orlando)
>  drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index 842c04e63..16b1c82b2 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -181,10 +181,10 @@ static int intelfb_create(struct drm_fb_helper *helper,
>  	int ret;
>  
>  	if (intel_fb &&
> -	    (sizes->fb_width > intel_fb->base.width ||
> -	     sizes->fb_height > intel_fb->base.height)) {
> +	    (sizes->fb_width != intel_fb->base.width ||
> +	     sizes->fb_height != intel_fb->base.height)) {
>  		drm_dbg_kms(&dev_priv->drm,
> -			    "BIOS fb too small (%dx%d), we require (%dx%d),"
> +			    "BIOS fb not valid (%dx%d), we require (%dx%d),"
>  			    " releasing it\n",
>  			    intel_fb->base.width, intel_fb->base.height,
>  			    sizes->fb_width, sizes->fb_height);
> -- 
> 2.25.1
> 

-- 
Ville Syrjälä
Intel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption.
@ 2022-01-12 13:37   ` Ville Syrjälä
  0 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjälä @ 2022-01-12 13:37 UTC (permalink / raw)
  To: Ashish Arora
  Cc: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com, intel-gfx@lists.freedesktop.org,
	Linux Kernel Mailing List

On Tue, Jan 11, 2022 at 07:55:22AM +0000, Ashish Arora wrote:
> From: Ashish Arora <ashisharora.linux@outlook.com>
> 
> On certain 4k panels and Macs, the BIOS framebuffer is larger than what
> panel requires causing display corruption. Introduce a check for the same.

If a larger fb causes corruption then there is a real bug somewhere.

> 
> 
> Signed-off-by: Ashish Arora <ashisharora.linux@outlook.com>
> Reviewed-by: Aun-Ali Zaidi <admin@kodeit.net>
> ---
> V2 :- Use != instead of < and >
> V3 :- Mention Macs (Thanks to Orlando)
>  drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index 842c04e63..16b1c82b2 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -181,10 +181,10 @@ static int intelfb_create(struct drm_fb_helper *helper,
>  	int ret;
>  
>  	if (intel_fb &&
> -	    (sizes->fb_width > intel_fb->base.width ||
> -	     sizes->fb_height > intel_fb->base.height)) {
> +	    (sizes->fb_width != intel_fb->base.width ||
> +	     sizes->fb_height != intel_fb->base.height)) {
>  		drm_dbg_kms(&dev_priv->drm,
> -			    "BIOS fb too small (%dx%d), we require (%dx%d),"
> +			    "BIOS fb not valid (%dx%d), we require (%dx%d),"
>  			    " releasing it\n",
>  			    intel_fb->base.width, intel_fb->base.height,
>  			    sizes->fb_width, sizes->fb_height);
> -- 
> 2.25.1
> 

-- 
Ville Syrjälä
Intel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption.
  2022-01-12 13:37   ` Ville Syrjälä
  (?)
@ 2022-01-12 13:42   ` Ashish Arora
  -1 siblings, 0 replies; 14+ messages in thread
From: Ashish Arora @ 2022-01-12 13:42 UTC (permalink / raw)
  To: Ville Syrjälä
  Cc: Aun-Ali Zaidi, Orlando Chamberlain,
	intel-gfx@lists.freedesktop.org, Linux Kernel Mailing List,
	Aditya Garg



> On 12-Jan-2022, at 7:07 PM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> 
> On Tue, Jan 11, 2022 at 07:55:22AM +0000, Ashish Arora wrote:
>> From: Ashish Arora <ashisharora.linux@outlook.com>
>> 
>> On certain 4k panels and Macs, the BIOS framebuffer is larger than what
>> panel requires causing display corruption. Introduce a check for the same.
> 
> If a larger fb causes corruption then there is a real bug somewhere.
I would like to clarify that what I meant by display corruption that some edges of screen are not seen.

Orlando described better in a mail as follows :- 

"I haven't observed "display corruption", but on my MacBookPro16,1 the bottom
and right edges of the TTY are not on the screen, so a few lines of text
cannot be seen.

This also occurs on the internal displays of all (as far as I know) other
2018-2020 Intel Macbooks when using the Intel GPU (The 15" and 16" ones
also have an AMDGPU, but this issue occurs when they have the Intel GPU
set as the boot gpu).”
> 
>> 
>> 
>> Signed-off-by: Ashish Arora <ashisharora.linux@outlook.com>
>> Reviewed-by: Aun-Ali Zaidi <admin@kodeit.net>
>> ---
>> V2 :- Use != instead of < and >
>> V3 :- Mention Macs (Thanks to Orlando)
>> drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
>> index 842c04e63..16b1c82b2 100644
>> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
>> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
>> @@ -181,10 +181,10 @@ static int intelfb_create(struct drm_fb_helper *helper,
>> 	int ret;
>> 
>> 	if (intel_fb &&
>> -	    (sizes->fb_width > intel_fb->base.width ||
>> -	     sizes->fb_height > intel_fb->base.height)) {
>> +	    (sizes->fb_width != intel_fb->base.width ||
>> +	     sizes->fb_height != intel_fb->base.height)) {
>> 		drm_dbg_kms(&dev_priv->drm,
>> -			    "BIOS fb too small (%dx%d), we require (%dx%d),"
>> +			    "BIOS fb not valid (%dx%d), we require (%dx%d),"
>> 			    " releasing it\n",
>> 			    intel_fb->base.width, intel_fb->base.height,
>> 			    sizes->fb_width, sizes->fb_height);
>> -- 
>> 2.25.1
>> 
> 
> -- 
> Ville Syrjälä
> Intel


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption.
  2022-01-12 13:37   ` Ville Syrjälä
  (?)
  (?)
@ 2022-01-30  9:27   ` Ashish Arora
  -1 siblings, 0 replies; 14+ messages in thread
From: Ashish Arora @ 2022-01-30  9:27 UTC (permalink / raw)
  To: Ville Syrjälä
  Cc: Aun-Ali Zaidi, Orlando Chamberlain,
	intel-gfx@lists.freedesktop.org, Linux Kernel Mailing List,
	Aditya Garg



> On 12-Jan-2022, at 7:07 PM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> 
> On Tue, Jan 11, 2022 at 07:55:22AM +0000, Ashish Arora wrote:
>> From: Ashish Arora <ashisharora.linux@outlook.com>
>> 
>> On certain 4k panels and Macs, the BIOS framebuffer is larger than what
>> panel requires causing display corruption. Introduce a check for the same.
> 
> If a larger fb causes corruption then there is a real bug somewhere.
Hi Ville

I and some members of the t2 linux group would like to have more details of this bug.
> 
>> 
>> 
>> Signed-off-by: Ashish Arora <ashisharora.linux@outlook.com>
>> Reviewed-by: Aun-Ali Zaidi <admin@kodeit.net>
>> ---
>> V2 :- Use != instead of < and >
>> V3 :- Mention Macs (Thanks to Orlando)
>> drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
>> index 842c04e63..16b1c82b2 100644
>> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
>> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
>> @@ -181,10 +181,10 @@ static int intelfb_create(struct drm_fb_helper *helper,
>> 	int ret;
>> 
>> 	if (intel_fb &&
>> -	    (sizes->fb_width > intel_fb->base.width ||
>> -	     sizes->fb_height > intel_fb->base.height)) {
>> +	    (sizes->fb_width != intel_fb->base.width ||
>> +	     sizes->fb_height != intel_fb->base.height)) {
>> 		drm_dbg_kms(&dev_priv->drm,
>> -			    "BIOS fb too small (%dx%d), we require (%dx%d),"
>> +			    "BIOS fb not valid (%dx%d), we require (%dx%d),"
>> 			    " releasing it\n",
>> 			    intel_fb->base.width, intel_fb->base.height,
>> 			    sizes->fb_width, sizes->fb_height);
>> -- 
>> 2.25.1
>> 
> 
> -- 
> Ville Syrjälä
> Intel


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [BUG] The bottom and right edges on the tty are not shown on Apple T2 MacBooks with Retina display
  2022-01-11  7:55 [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption Ashish Arora
                   ` (3 preceding siblings ...)
  2022-01-12 13:37   ` Ville Syrjälä
@ 2025-01-03 11:15 ` Aditya Garg
  2025-01-03 14:14   ` Jani Nikula
  4 siblings, 1 reply; 14+ messages in thread
From: Aditya Garg @ 2025-01-03 11:15 UTC (permalink / raw)
  To: Ashish Arora
  Cc: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com, ville.syrjala@linux.intel.com,
	intel-gfx@lists.freedesktop.org, Linux Kernel Mailing List,
	Orlando Chamberlain

Hello maintainers

This bug has been there for a long time, and hasn't been fixed yet. In case the Intel GPU is used as boot GPU on Apple T2 MacBooks, the bottom and right edges of the tty are no longer seen, thus making some text not visible.

It has been reported in almost all Apple T2 MacBooks with Intel GPU, which have the Retina display.

In case of a dual GPU MacBook, if the AMD dGPU is used to boot, the bug no longer exists.

This patch below was submitted 3 years ago, and it fixes this issue.

> On 11 Jan 2022, at 1:25 PM, Ashish Arora <ashisharora.linux@outlook.com> wrote:
> 
> From: Ashish Arora <ashisharora.linux@outlook.com>
> 
> On certain 4k panels and Macs, the BIOS framebuffer is larger than what
> panel requires causing display corruption. Introduce a check for the same.
> 
> 
> Signed-off-by: Ashish Arora <ashisharora.linux@outlook.com>
> Reviewed-by: Aun-Ali Zaidi <admin@kodeit.net>
> ---
> V2 :- Use != instead of < and >
> V3 :- Mention Macs (Thanks to Orlando)
> drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index 842c04e63..16b1c82b2 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -181,10 +181,10 @@ static int intelfb_create(struct drm_fb_helper *helper,
> int ret;
> 
> if (intel_fb &&
> -    (sizes->fb_width > intel_fb->base.width ||
> -     sizes->fb_height > intel_fb->base.height)) {
> +    (sizes->fb_width != intel_fb->base.width ||
> +     sizes->fb_height != intel_fb->base.height)) {
> drm_dbg_kms(&dev_priv->drm,
> -    "BIOS fb too small (%dx%d), we require (%dx%d),"
> +    "BIOS fb not valid (%dx%d), we require (%dx%d),"
>    " releasing it\n",
>    intel_fb->base.width, intel_fb->base.height,
>    sizes->fb_width, sizes->fb_height);
> -- 
> 2.25.1
> 
> 
> 


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [BUG] The bottom and right edges on the tty are not shown on Apple T2 MacBooks with Retina display
  2025-01-03 11:15 ` [BUG] The bottom and right edges on the tty are not shown on Apple T2 MacBooks with Retina display Aditya Garg
@ 2025-01-03 14:14   ` Jani Nikula
  2025-01-07 12:25     ` Aditya Garg
  0 siblings, 1 reply; 14+ messages in thread
From: Jani Nikula @ 2025-01-03 14:14 UTC (permalink / raw)
  To: Aditya Garg, Ashish Arora
  Cc: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
	ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org,
	Linux Kernel Mailing List, Orlando Chamberlain

On Fri, 03 Jan 2025, Aditya Garg <gargaditya08@live.com> wrote:
> Hello maintainers
>
> This bug has been there for a long time, and hasn't been fixed yet. In case the Intel GPU is used as boot GPU on Apple T2 MacBooks, the bottom and right edges of the tty are no longer seen, thus making some text not visible.
>
> It has been reported in almost all Apple T2 MacBooks with Intel GPU, which have the Retina display.
>
> In case of a dual GPU MacBook, if the AMD dGPU is used to boot, the bug no longer exists.
>
> This patch below was submitted 3 years ago, and it fixes this issue.

Please file a bug as described at [1], attaching dmesg from boot with
debugs enabled, etc.

As suggested by Ville in [2], the bug is likely elsewhere, and this just
hides it. A bigger fb shouldn't be a problem, and we shouldn't add this
limitation everywhere because of the issue you're seeing.

BR,
Jani.



[1] https://drm.pages.freedesktop.org/intel-docs/how-to-file-i915-bugs.html

[2] https://lore.kernel.org/r/Yd7ZnBlU0sjP4qcG@intel.com

>
>> On 11 Jan 2022, at 1:25 PM, Ashish Arora <ashisharora.linux@outlook.com> wrote:
>> 
>> From: Ashish Arora <ashisharora.linux@outlook.com>
>> 
>> On certain 4k panels and Macs, the BIOS framebuffer is larger than what
>> panel requires causing display corruption. Introduce a check for the same.
>> 
>> 
>> Signed-off-by: Ashish Arora <ashisharora.linux@outlook.com>
>> Reviewed-by: Aun-Ali Zaidi <admin@kodeit.net>
>> ---
>> V2 :- Use != instead of < and >
>> V3 :- Mention Macs (Thanks to Orlando)
>> drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
>> index 842c04e63..16b1c82b2 100644
>> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
>> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
>> @@ -181,10 +181,10 @@ static int intelfb_create(struct drm_fb_helper *helper,
>> int ret;
>> 
>> if (intel_fb &&
>> -    (sizes->fb_width > intel_fb->base.width ||
>> -     sizes->fb_height > intel_fb->base.height)) {
>> +    (sizes->fb_width != intel_fb->base.width ||
>> +     sizes->fb_height != intel_fb->base.height)) {
>> drm_dbg_kms(&dev_priv->drm,
>> -    "BIOS fb too small (%dx%d), we require (%dx%d),"
>> +    "BIOS fb not valid (%dx%d), we require (%dx%d),"
>>    " releasing it\n",
>>    intel_fb->base.width, intel_fb->base.height,
>>    sizes->fb_width, sizes->fb_height);
>> -- 
>> 2.25.1
>> 
>> 
>> 
>

-- 
Jani Nikula, Intel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [BUG] The bottom and right edges on the tty are not shown on Apple T2 MacBooks with Retina display
  2025-01-03 14:14   ` Jani Nikula
@ 2025-01-07 12:25     ` Aditya Garg
  2025-01-07 12:32       ` Jani Nikula
  0 siblings, 1 reply; 14+ messages in thread
From: Aditya Garg @ 2025-01-07 12:25 UTC (permalink / raw)
  To: Jani Nikula
  Cc: Ashish Arora, joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com, ville.syrjala@linux.intel.com,
	intel-gfx@lists.freedesktop.org, Linux Kernel Mailing List,
	Orlando Chamberlain

Here are the logs requested as per the link you sent me:

1. uname -a:

Linux MacBook 6.12.8-1-t2-noble #1 SMP PREEMPT_DYNAMIC Fri Jan 3 15:43:23 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

2. lspci -vnn -d :*:0300:

00:02.0 VGA compatible controller [0300]: Intel Corporation CoffeeLake-H GT2 [UHD Graphics 630] [8086:3e9b] (prog-if 00 [VGA controller])
	Subsystem: Apple Inc. CoffeeLake-H GT2 [UHD Graphics 630] [106b:019c]
	Flags: bus master, fast devsel, latency 0, IRQ 93, IOMMU group 0
	Memory at 80000000 (64-bit, non-prefetchable) [size=16M]
	Memory at a0000000 (64-bit, prefetchable) [size=256M]
	I/O ports at 4000 [size=64]
	Expansion ROM at 000c0000 [virtual] [disabled] [size=128K]
	Capabilities: [40] Vendor Specific Information: Len=0c <?>
	Capabilities: [70] Express Root Complex Integrated Endpoint, MSI 00
	Capabilities: [ac] MSI: Enable+ Count=1/1 Maskable- 64bit-
	Capabilities: [d0] Power Management version 2
	Capabilities: [100] Process Address Space ID (PASID)
	Capabilities: [200] Address Translation Service (ATS)
	Capabilities: [300] Page Request Interface (PRI)
	Kernel driver in use: i915
	Kernel modules: i915

03:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 14 [Radeon RX 5500/5500M / Pro 5500M] [1002:7340] (rev 43) (prog-if 00 [VGA controller])
	Subsystem: Apple Inc. Navi 14 [Radeon RX 5500/5500M / Pro 5500M] [106b:0210]
	Flags: bus master, fast devsel, latency 0, IRQ 97, IOMMU group 2
	Memory at 4100000000 (64-bit, prefetchable) [size=4G]
	Memory at 4080000000 (64-bit, prefetchable) [size=2M]
	I/O ports at 3000 [size=256]
	Memory at 81500000 (32-bit, non-prefetchable) [size=512K]
	Expansion ROM at 81580000 [disabled] [size=128K]
	Capabilities: [48] Vendor Specific Information: Len=08 <?>
	Capabilities: [50] Power Management version 3
	Capabilities: [64] Express Legacy Endpoint, MSI 00
	Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+
	Capabilities: [100] Vendor Specific Information: ID=0001 Rev=1 Len=010 <?>
	Capabilities: [150] Advanced Error Reporting
	Capabilities: [200] Physical Resizable BAR
	Capabilities: [240] Power Budgeting <?>
	Capabilities: [270] Secondary PCI Express
	Capabilities: [2a0] Access Control Services
	Capabilities: [2b0] Address Translation Service (ATS)
	Capabilities: [2c0] Page Request Interface (PRI)
	Capabilities: [2d0] Process Address Space ID (PASID)
	Capabilities: [320] Latency Tolerance Reporting
	Capabilities: [400] Data Link Feature <?>
	Capabilities: [410] Physical Layer 16.0 GT/s <?>
	Capabilities: [440] Lane Margining at the Receiver <?>
	Kernel driver in use: amdgpu
	Kernel modules: amdgpu

3. dmidecode:

https://pastebin.com/rNDittEZ

4. dmesg:

https://gist.github.com/AdityaGarg8/44cf973ac5cf5eac53246dce67e437ab

5. xrandr --verbose

https://pastebin.com/9ufbbBCc

> On 3 Jan 2025, at 7:44 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> 
> On Fri, 03 Jan 2025, Aditya Garg <gargaditya08@live.com> wrote:
>> Hello maintainers
>> 
>> This bug has been there for a long time, and hasn't been fixed yet. In case the Intel GPU is used as boot GPU on Apple T2 MacBooks, the bottom and right edges of the tty are no longer seen, thus making some text not visible.
>> 
>> It has been reported in almost all Apple T2 MacBooks with Intel GPU, which have the Retina display.
>> 
>> In case of a dual GPU MacBook, if the AMD dGPU is used to boot, the bug no longer exists.
>> 
>> This patch below was submitted 3 years ago, and it fixes this issue.
> 
> Please file a bug as described at [1], attaching dmesg from boot with
> debugs enabled, etc.
> 
> As suggested by Ville in [2], the bug is likely elsewhere, and this just
> hides it. A bigger fb shouldn't be a problem, and we shouldn't add this
> limitation everywhere because of the issue you're seeing.
> 
> BR,
> Jani.
> 
> 
> 
> [1] https://drm.pages.freedesktop.org/intel-docs/how-to-file-i915-bugs.html
> 
> [2] https://lore.kernel.org/r/Yd7ZnBlU0sjP4qcG@intel.com
> 
>> 
>>> On 11 Jan 2022, at 1:25 PM, Ashish Arora <ashisharora.linux@outlook.com> wrote:
>>> 
>>> From: Ashish Arora <ashisharora.linux@outlook.com>
>>> 
>>> On certain 4k panels and Macs, the BIOS framebuffer is larger than what
>>> panel requires causing display corruption. Introduce a check for the same.
>>> 
>>> 
>>> Signed-off-by: Ashish Arora <ashisharora.linux@outlook.com>
>>> Reviewed-by: Aun-Ali Zaidi <admin@kodeit.net>
>>> ---
>>> V2 :- Use != instead of < and >
>>> V3 :- Mention Macs (Thanks to Orlando)
>>> drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>> 
>>> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
>>> index 842c04e63..16b1c82b2 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
>>> @@ -181,10 +181,10 @@ static int intelfb_create(struct drm_fb_helper *helper,
>>> int ret;
>>> 
>>> if (intel_fb &&
>>> -    (sizes->fb_width > intel_fb->base.width ||
>>> -     sizes->fb_height > intel_fb->base.height)) {
>>> +    (sizes->fb_width != intel_fb->base.width ||
>>> +     sizes->fb_height != intel_fb->base.height)) {
>>> drm_dbg_kms(&dev_priv->drm,
>>> -    "BIOS fb too small (%dx%d), we require (%dx%d),"
>>> +    "BIOS fb not valid (%dx%d), we require (%dx%d),"
>>>   " releasing it\n",
>>>   intel_fb->base.width, intel_fb->base.height,
>>>   sizes->fb_width, sizes->fb_height);
>>> -- 
>>> 2.25.1
>>> 
>>> 
>>> 
>> 
> 
> -- 
> Jani Nikula, Intel



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [BUG] The bottom and right edges on the tty are not shown on Apple T2 MacBooks with Retina display
  2025-01-07 12:25     ` Aditya Garg
@ 2025-01-07 12:32       ` Jani Nikula
  2025-01-07 14:32         ` Aditya Garg
  0 siblings, 1 reply; 14+ messages in thread
From: Jani Nikula @ 2025-01-07 12:32 UTC (permalink / raw)
  To: Aditya Garg
  Cc: Ashish Arora, joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com, ville.syrjala@linux.intel.com,
	intel-gfx@lists.freedesktop.org, Linux Kernel Mailing List,
	Orlando Chamberlain

On Tue, 07 Jan 2025, Aditya Garg <gargaditya08@live.com> wrote:
> Here are the logs requested as per the link you sent me:

It also says, "Please file issues in the drm/i915 issue tracker for i915
driver bugs"

I was looking to have that issue created with the logs attached there
instead of mailing lists and pastebins and whatnot.

https://gitlab.freedesktop.org/drm/i915/kernel/-/issues


BR,
Jani.


-- 
Jani Nikula, Intel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [BUG] The bottom and right edges on the tty are not shown on Apple T2 MacBooks with Retina display
  2025-01-07 12:32       ` Jani Nikula
@ 2025-01-07 14:32         ` Aditya Garg
  0 siblings, 0 replies; 14+ messages in thread
From: Aditya Garg @ 2025-01-07 14:32 UTC (permalink / raw)
  To: Jani Nikula
  Cc: Ashish Arora, joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com, ville.syrjala@linux.intel.com,
	intel-gfx@lists.freedesktop.org, Linux Kernel Mailing List,
	Orlando Chamberlain

https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13466

I’ve filed it there.

> On 7 Jan 2025, at 6:02 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> 
> On Tue, 07 Jan 2025, Aditya Garg <gargaditya08@live.com> wrote:
>> Here are the logs requested as per the link you sent me:
> 
> It also says, "Please file issues in the drm/i915 issue tracker for i915
> driver bugs"
> 
> I was looking to have that issue created with the logs attached there
> instead of mailing lists and pastebins and whatnot.
> 
> https://gitlab.freedesktop.org/drm/i915/kernel/-/issues
> 
> 
> BR,
> Jani.
> 
> 
> -- 
> Jani Nikula, Intel


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2025-01-07 14:52 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-11  7:55 [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption Ashish Arora
2022-01-11  8:36 ` Jani Nikula
2022-01-11  8:36   ` Jani Nikula
2022-01-11 18:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Discard large BIOS framebuffers causing display corruption. (rev3) Patchwork
2022-01-11 23:33 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-01-12 13:37 ` [Intel-gfx] [PATCH - v3] drm/i915: Discard large BIOS framebuffers causing display corruption Ville Syrjälä
2022-01-12 13:37   ` Ville Syrjälä
2022-01-12 13:42   ` Ashish Arora
2022-01-30  9:27   ` Ashish Arora
2025-01-03 11:15 ` [BUG] The bottom and right edges on the tty are not shown on Apple T2 MacBooks with Retina display Aditya Garg
2025-01-03 14:14   ` Jani Nikula
2025-01-07 12:25     ` Aditya Garg
2025-01-07 12:32       ` Jani Nikula
2025-01-07 14:32         ` Aditya Garg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.