All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
	 Jeff Johnson <quic_jjohnson@quicinc.com>,
	 ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	 linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] wifi: ath11k: fix temperature event locking
Date: Wed, 25 Oct 2023 12:51:10 +0300	[thread overview]
Message-ID: <87bkcnxc6p.fsf@kernel.org> (raw)
In-Reply-To: <ZTfUswqVkAgJvnye@hovoldconsulting.com> (Johan Hovold's message of "Tue, 24 Oct 2023 16:29:07 +0200")

Johan Hovold <johan@kernel.org> writes:

> On Tue, Oct 24, 2023 at 04:59:35PM +0300, Kalle Valo wrote:
>> Johan Hovold <johan+linaro@kernel.org> writes:
>> 
>> > The ath11k active pdevs are protected by RCU but the temperature event
>> > handling code calling ath11k_mac_get_ar_by_pdev_id() was not marked as a
>> > read-side critical section as reported by RCU lockdep:
>
>> On what hardware and firmware version did you test this? As there's so
>> many different combos we use Tested-on tag to provide that information
>> in the commit message:
>> 
>> https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches#tested-on_tag
>> 
>> I can add that if you let me know what you used.
>
> I hit this on the Lenovo Thinkpad X13s and I guess the tag should be:
>
> Tested-on: QCNFA765 hw2.1 WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23

From ath11k point of view QCNFA765 is WCN6855 so I used this one:

Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23

> Note that I've only been able to test the ath11k fixes (not the
> corresponding ath12k) and I only tested this particular patch fully

Thanks, I added Tested-on to this patch 1 and for the rest I added
"compile tested only".

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
	Jeff Johnson <quic_jjohnson@quicinc.com>,
	ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] wifi: ath11k: fix temperature event locking
Date: Wed, 25 Oct 2023 12:51:10 +0300	[thread overview]
Message-ID: <87bkcnxc6p.fsf@kernel.org> (raw)
In-Reply-To: <ZTfUswqVkAgJvnye@hovoldconsulting.com> (Johan Hovold's message of "Tue, 24 Oct 2023 16:29:07 +0200")

Johan Hovold <johan@kernel.org> writes:

> On Tue, Oct 24, 2023 at 04:59:35PM +0300, Kalle Valo wrote:
>> Johan Hovold <johan+linaro@kernel.org> writes:
>> 
>> > The ath11k active pdevs are protected by RCU but the temperature event
>> > handling code calling ath11k_mac_get_ar_by_pdev_id() was not marked as a
>> > read-side critical section as reported by RCU lockdep:
>
>> On what hardware and firmware version did you test this? As there's so
>> many different combos we use Tested-on tag to provide that information
>> in the commit message:
>> 
>> https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches#tested-on_tag
>> 
>> I can add that if you let me know what you used.
>
> I hit this on the Lenovo Thinkpad X13s and I guess the tag should be:
>
> Tested-on: QCNFA765 hw2.1 WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23

From ath11k point of view QCNFA765 is WCN6855 so I used this one:

Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23

> Note that I've only been able to test the ath11k fixes (not the
> corresponding ath12k) and I only tested this particular patch fully

Thanks, I added Tested-on to this patch 1 and for the rest I added
"compile tested only".

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-10-25  9:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19 15:31 [PATCH v2 0/2] wifi: ath11k: fix event locking Johan Hovold
2023-10-19 15:31 ` Johan Hovold
2023-10-19 15:31 ` [PATCH v2 1/2] wifi: ath11k: fix temperature " Johan Hovold
2023-10-19 15:31   ` Johan Hovold
2023-10-19 17:14   ` Jeff Johnson
2023-10-19 17:14     ` Jeff Johnson
2023-10-24 13:59   ` Kalle Valo
2023-10-24 13:59     ` Kalle Valo
2023-10-24 14:29     ` Johan Hovold
2023-10-24 14:29       ` Johan Hovold
2023-10-25  9:51       ` Kalle Valo [this message]
2023-10-25  9:51         ` Kalle Valo
2023-10-25 12:26         ` Johan Hovold
2023-10-25 12:26           ` Johan Hovold
2023-10-25  9:59   ` Kalle Valo
2023-10-25  9:59     ` Kalle Valo
2023-10-19 15:31 ` [PATCH v2 2/2] wifi: ath11k: fix dfs radar " Johan Hovold
2023-10-19 15:31   ` Johan Hovold
2023-10-24 14:07 ` [PATCH v2 0/2] wifi: ath11k: fix " Kalle Valo
2023-10-24 14:07   ` Kalle Valo
2023-10-24 15:17   ` Johan Hovold
2023-10-24 15:17     ` Johan Hovold
2024-01-13 10:26     ` ath11k: checking RCU usage Kalle Valo
2024-01-22 13:10       ` Johan Hovold
2024-01-22 14:04         ` Johan Hovold
2024-01-22 14:39           ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkcnxc6p.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=johan+linaro@kernel.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_jjohnson@quicinc.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.