All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
	 ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] wifi: ath11k: fix event locking
Date: Tue, 24 Oct 2023 17:07:38 +0300	[thread overview]
Message-ID: <87o7goxget.fsf@kernel.org> (raw)
In-Reply-To: <20231019153115.26401-1-johan+linaro@kernel.org> (Johan Hovold's message of "Thu, 19 Oct 2023 17:31:13 +0200")

Johan Hovold <johan+linaro@kernel.org> writes:

> RCU lockdep reported suspicious RCU usage when accessing the temperature
> sensor. Inspection revealed that the DFS radar event code was also
> missing the required RCU read-side critical section marking.
>
> Johan
>
>
> Changes in v2
>  - add the missing rcu_read_unlock() to an
>    ath11k_wmi_pdev_temperature_event() error path as noticed by Jeff
>
>
> Johan Hovold (2):
>   wifi: ath11k: fix temperature event locking
>   wifi: ath11k: fix dfs radar event locking

Thanks for the fixes. I really like using lockdep_assert_held() to
document if a function requires some lock held, is there anything
similar for RCU?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
	ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] wifi: ath11k: fix event locking
Date: Tue, 24 Oct 2023 17:07:38 +0300	[thread overview]
Message-ID: <87o7goxget.fsf@kernel.org> (raw)
In-Reply-To: <20231019153115.26401-1-johan+linaro@kernel.org> (Johan Hovold's message of "Thu, 19 Oct 2023 17:31:13 +0200")

Johan Hovold <johan+linaro@kernel.org> writes:

> RCU lockdep reported suspicious RCU usage when accessing the temperature
> sensor. Inspection revealed that the DFS radar event code was also
> missing the required RCU read-side critical section marking.
>
> Johan
>
>
> Changes in v2
>  - add the missing rcu_read_unlock() to an
>    ath11k_wmi_pdev_temperature_event() error path as noticed by Jeff
>
>
> Johan Hovold (2):
>   wifi: ath11k: fix temperature event locking
>   wifi: ath11k: fix dfs radar event locking

Thanks for the fixes. I really like using lockdep_assert_held() to
document if a function requires some lock held, is there anything
similar for RCU?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  parent reply	other threads:[~2023-10-24 14:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19 15:31 [PATCH v2 0/2] wifi: ath11k: fix event locking Johan Hovold
2023-10-19 15:31 ` Johan Hovold
2023-10-19 15:31 ` [PATCH v2 1/2] wifi: ath11k: fix temperature " Johan Hovold
2023-10-19 15:31   ` Johan Hovold
2023-10-19 17:14   ` Jeff Johnson
2023-10-19 17:14     ` Jeff Johnson
2023-10-24 13:59   ` Kalle Valo
2023-10-24 13:59     ` Kalle Valo
2023-10-24 14:29     ` Johan Hovold
2023-10-24 14:29       ` Johan Hovold
2023-10-25  9:51       ` Kalle Valo
2023-10-25  9:51         ` Kalle Valo
2023-10-25 12:26         ` Johan Hovold
2023-10-25 12:26           ` Johan Hovold
2023-10-25  9:59   ` Kalle Valo
2023-10-25  9:59     ` Kalle Valo
2023-10-19 15:31 ` [PATCH v2 2/2] wifi: ath11k: fix dfs radar " Johan Hovold
2023-10-19 15:31   ` Johan Hovold
2023-10-24 14:07 ` Kalle Valo [this message]
2023-10-24 14:07   ` [PATCH v2 0/2] wifi: ath11k: fix " Kalle Valo
2023-10-24 15:17   ` Johan Hovold
2023-10-24 15:17     ` Johan Hovold
2024-01-13 10:26     ` ath11k: checking RCU usage Kalle Valo
2024-01-22 13:10       ` Johan Hovold
2024-01-22 14:04         ` Johan Hovold
2024-01-22 14:39           ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7goxget.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=johan+linaro@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_jjohnson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.