All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Aditya Kumar Singh <quic_adisi@quicinc.com>,
	<ath11k@lists.infradead.org>,  <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
Date: Thu, 27 Jul 2023 09:12:58 +0300	[thread overview]
Message-ID: <87bkfx287p.fsf@kernel.org> (raw)
In-Reply-To: <8fe1a927-14da-445c-4c48-e3f4b4c324d4@quicinc.com> (Jeff Johnson's message of "Wed, 26 Jul 2023 09:54:46 -0700")

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 7/25/2023 9:46 PM, Aditya Kumar Singh wrote:
>> 5 GHz band channel 177 support was added with the commit
>> "wifi: ath11k: add channel 177 into 5 GHz channel list". However,
>
> I'd use the same syntax here as in the Fixes tag:
> e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
>
>> during processing for the received ppdu in ath11k_dp_rx_h_ppdu(), channel
>> number is checked only till 173. This leads to driver code checking for
>> channel and then fetching the band from it which is extra effort since
>> firmware has already given the channel number in the meta deta.
>
> nit: s/meta deta/metadata/

I can fix these in the pending branch.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Aditya Kumar Singh <quic_adisi@quicinc.com>,
	<ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
Date: Thu, 27 Jul 2023 09:12:58 +0300	[thread overview]
Message-ID: <87bkfx287p.fsf@kernel.org> (raw)
In-Reply-To: <8fe1a927-14da-445c-4c48-e3f4b4c324d4@quicinc.com> (Jeff Johnson's message of "Wed, 26 Jul 2023 09:54:46 -0700")

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 7/25/2023 9:46 PM, Aditya Kumar Singh wrote:
>> 5 GHz band channel 177 support was added with the commit
>> "wifi: ath11k: add channel 177 into 5 GHz channel list". However,
>
> I'd use the same syntax here as in the Fixes tag:
> e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
>
>> during processing for the received ppdu in ath11k_dp_rx_h_ppdu(), channel
>> number is checked only till 173. This leads to driver code checking for
>> channel and then fetching the band from it which is extra effort since
>> firmware has already given the channel number in the meta deta.
>
> nit: s/meta deta/metadata/

I can fix these in the pending branch.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-07-27  6:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26  4:46 [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz Aditya Kumar Singh
2023-07-26  4:46 ` Aditya Kumar Singh
2023-07-26 16:54 ` Jeff Johnson
2023-07-26 16:54   ` Jeff Johnson
2023-07-27  6:12   ` Kalle Valo [this message]
2023-07-27  6:12     ` Kalle Valo
2023-07-27 12:00     ` Aditya Kumar Singh
2023-07-27 12:00       ` Aditya Kumar Singh
2023-07-27 12:02   ` Aditya Kumar Singh
2023-07-27 12:02     ` Aditya Kumar Singh
2023-08-02 11:49 ` Kalle Valo
2023-08-02 11:49   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkfx287p.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_adisi@quicinc.com \
    --cc=quic_jjohnson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.