* [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
@ 2023-07-26 4:46 ` Aditya Kumar Singh
0 siblings, 0 replies; 12+ messages in thread
From: Aditya Kumar Singh @ 2023-07-26 4:46 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless, Aditya Kumar Singh
5 GHz band channel 177 support was added with the commit
"wifi: ath11k: add channel 177 into 5 GHz channel list". However,
during processing for the received ppdu in ath11k_dp_rx_h_ppdu(), channel
number is checked only till 173. This leads to driver code checking for
channel and then fetching the band from it which is extra effort since
firmware has already given the channel number in the meta deta.
Fix this issue by checking the channel number till 177 since we support
it now.
Found via code review. Compile tested only.
Fixes: e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
---
drivers/net/wireless/ath/ath11k/dp_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 5c76664ba0dd..1e488eed282b 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -2408,7 +2408,7 @@ static void ath11k_dp_rx_h_ppdu(struct ath11k *ar, struct hal_rx_desc *rx_desc,
rx_status->freq = center_freq;
} else if (channel_num >= 1 && channel_num <= 14) {
rx_status->band = NL80211_BAND_2GHZ;
- } else if (channel_num >= 36 && channel_num <= 173) {
+ } else if (channel_num >= 36 && channel_num <= 177) {
rx_status->band = NL80211_BAND_5GHZ;
} else {
spin_lock_bh(&ar->data_lock);
--
2.17.1
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
@ 2023-07-26 4:46 ` Aditya Kumar Singh
0 siblings, 0 replies; 12+ messages in thread
From: Aditya Kumar Singh @ 2023-07-26 4:46 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless, Aditya Kumar Singh
5 GHz band channel 177 support was added with the commit
"wifi: ath11k: add channel 177 into 5 GHz channel list". However,
during processing for the received ppdu in ath11k_dp_rx_h_ppdu(), channel
number is checked only till 173. This leads to driver code checking for
channel and then fetching the band from it which is extra effort since
firmware has already given the channel number in the meta deta.
Fix this issue by checking the channel number till 177 since we support
it now.
Found via code review. Compile tested only.
Fixes: e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
---
drivers/net/wireless/ath/ath11k/dp_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 5c76664ba0dd..1e488eed282b 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -2408,7 +2408,7 @@ static void ath11k_dp_rx_h_ppdu(struct ath11k *ar, struct hal_rx_desc *rx_desc,
rx_status->freq = center_freq;
} else if (channel_num >= 1 && channel_num <= 14) {
rx_status->band = NL80211_BAND_2GHZ;
- } else if (channel_num >= 36 && channel_num <= 173) {
+ } else if (channel_num >= 36 && channel_num <= 177) {
rx_status->band = NL80211_BAND_5GHZ;
} else {
spin_lock_bh(&ar->data_lock);
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
2023-07-26 4:46 ` Aditya Kumar Singh
@ 2023-07-26 16:54 ` Jeff Johnson
-1 siblings, 0 replies; 12+ messages in thread
From: Jeff Johnson @ 2023-07-26 16:54 UTC (permalink / raw)
To: Aditya Kumar Singh, ath11k; +Cc: linux-wireless
On 7/25/2023 9:46 PM, Aditya Kumar Singh wrote:
> 5 GHz band channel 177 support was added with the commit
> "wifi: ath11k: add channel 177 into 5 GHz channel list". However,
I'd use the same syntax here as in the Fixes tag:
e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
> during processing for the received ppdu in ath11k_dp_rx_h_ppdu(), channel
> number is checked only till 173. This leads to driver code checking for
> channel and then fetching the band from it which is extra effort since
> firmware has already given the channel number in the meta deta.
nit: s/meta deta/metadata/
>
> Fix this issue by checking the channel number till 177 since we support
> it now.
>
> Found via code review. Compile tested only.
>
> Fixes: e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
> ---
> drivers/net/wireless/ath/ath11k/dp_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
> index 5c76664ba0dd..1e488eed282b 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
> @@ -2408,7 +2408,7 @@ static void ath11k_dp_rx_h_ppdu(struct ath11k *ar, struct hal_rx_desc *rx_desc,
> rx_status->freq = center_freq;
> } else if (channel_num >= 1 && channel_num <= 14) {
> rx_status->band = NL80211_BAND_2GHZ;
> - } else if (channel_num >= 36 && channel_num <= 173) {
> + } else if (channel_num >= 36 && channel_num <= 177) {
> rx_status->band = NL80211_BAND_5GHZ;
> } else {
> spin_lock_bh(&ar->data_lock);
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
@ 2023-07-26 16:54 ` Jeff Johnson
0 siblings, 0 replies; 12+ messages in thread
From: Jeff Johnson @ 2023-07-26 16:54 UTC (permalink / raw)
To: Aditya Kumar Singh, ath11k; +Cc: linux-wireless
On 7/25/2023 9:46 PM, Aditya Kumar Singh wrote:
> 5 GHz band channel 177 support was added with the commit
> "wifi: ath11k: add channel 177 into 5 GHz channel list". However,
I'd use the same syntax here as in the Fixes tag:
e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
> during processing for the received ppdu in ath11k_dp_rx_h_ppdu(), channel
> number is checked only till 173. This leads to driver code checking for
> channel and then fetching the band from it which is extra effort since
> firmware has already given the channel number in the meta deta.
nit: s/meta deta/metadata/
>
> Fix this issue by checking the channel number till 177 since we support
> it now.
>
> Found via code review. Compile tested only.
>
> Fixes: e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
> ---
> drivers/net/wireless/ath/ath11k/dp_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
> index 5c76664ba0dd..1e488eed282b 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
> @@ -2408,7 +2408,7 @@ static void ath11k_dp_rx_h_ppdu(struct ath11k *ar, struct hal_rx_desc *rx_desc,
> rx_status->freq = center_freq;
> } else if (channel_num >= 1 && channel_num <= 14) {
> rx_status->band = NL80211_BAND_2GHZ;
> - } else if (channel_num >= 36 && channel_num <= 173) {
> + } else if (channel_num >= 36 && channel_num <= 177) {
> rx_status->band = NL80211_BAND_5GHZ;
> } else {
> spin_lock_bh(&ar->data_lock);
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
2023-07-26 16:54 ` Jeff Johnson
@ 2023-07-27 6:12 ` Kalle Valo
-1 siblings, 0 replies; 12+ messages in thread
From: Kalle Valo @ 2023-07-27 6:12 UTC (permalink / raw)
To: Jeff Johnson; +Cc: Aditya Kumar Singh, ath11k, linux-wireless
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 7/25/2023 9:46 PM, Aditya Kumar Singh wrote:
>> 5 GHz band channel 177 support was added with the commit
>> "wifi: ath11k: add channel 177 into 5 GHz channel list". However,
>
> I'd use the same syntax here as in the Fixes tag:
> e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
>
>> during processing for the received ppdu in ath11k_dp_rx_h_ppdu(), channel
>> number is checked only till 173. This leads to driver code checking for
>> channel and then fetching the band from it which is extra effort since
>> firmware has already given the channel number in the meta deta.
>
> nit: s/meta deta/metadata/
I can fix these in the pending branch.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
@ 2023-07-27 6:12 ` Kalle Valo
0 siblings, 0 replies; 12+ messages in thread
From: Kalle Valo @ 2023-07-27 6:12 UTC (permalink / raw)
To: Jeff Johnson; +Cc: Aditya Kumar Singh, ath11k, linux-wireless
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 7/25/2023 9:46 PM, Aditya Kumar Singh wrote:
>> 5 GHz band channel 177 support was added with the commit
>> "wifi: ath11k: add channel 177 into 5 GHz channel list". However,
>
> I'd use the same syntax here as in the Fixes tag:
> e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
>
>> during processing for the received ppdu in ath11k_dp_rx_h_ppdu(), channel
>> number is checked only till 173. This leads to driver code checking for
>> channel and then fetching the band from it which is extra effort since
>> firmware has already given the channel number in the meta deta.
>
> nit: s/meta deta/metadata/
I can fix these in the pending branch.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
2023-07-27 6:12 ` Kalle Valo
@ 2023-07-27 12:00 ` Aditya Kumar Singh
-1 siblings, 0 replies; 12+ messages in thread
From: Aditya Kumar Singh @ 2023-07-27 12:00 UTC (permalink / raw)
To: Kalle Valo, Jeff Johnson; +Cc: ath11k, linux-wireless
On 7/27/2023 11:42, Kalle Valo wrote:
> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>
>> On 7/25/2023 9:46 PM, Aditya Kumar Singh wrote:
>>> 5 GHz band channel 177 support was added with the commit
>>> "wifi: ath11k: add channel 177 into 5 GHz channel list". However,
>>
>> I'd use the same syntax here as in the Fixes tag:
>> e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
>>
>>> during processing for the received ppdu in ath11k_dp_rx_h_ppdu(), channel
>>> number is checked only till 173. This leads to driver code checking for
>>> channel and then fetching the band from it which is extra effort since
>>> firmware has already given the channel number in the meta deta.
>>
>> nit: s/meta deta/metadata/
>
> I can fix these in the pending branch.
Thanks Kalle.
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
@ 2023-07-27 12:00 ` Aditya Kumar Singh
0 siblings, 0 replies; 12+ messages in thread
From: Aditya Kumar Singh @ 2023-07-27 12:00 UTC (permalink / raw)
To: Kalle Valo, Jeff Johnson; +Cc: ath11k, linux-wireless
On 7/27/2023 11:42, Kalle Valo wrote:
> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>
>> On 7/25/2023 9:46 PM, Aditya Kumar Singh wrote:
>>> 5 GHz band channel 177 support was added with the commit
>>> "wifi: ath11k: add channel 177 into 5 GHz channel list". However,
>>
>> I'd use the same syntax here as in the Fixes tag:
>> e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
>>
>>> during processing for the received ppdu in ath11k_dp_rx_h_ppdu(), channel
>>> number is checked only till 173. This leads to driver code checking for
>>> channel and then fetching the band from it which is extra effort since
>>> firmware has already given the channel number in the meta deta.
>>
>> nit: s/meta deta/metadata/
>
> I can fix these in the pending branch.
Thanks Kalle.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
2023-07-26 16:54 ` Jeff Johnson
@ 2023-07-27 12:02 ` Aditya Kumar Singh
-1 siblings, 0 replies; 12+ messages in thread
From: Aditya Kumar Singh @ 2023-07-27 12:02 UTC (permalink / raw)
To: Jeff Johnson, ath11k; +Cc: linux-wireless
On 7/26/2023 22:24, Jeff Johnson wrote:
> On 7/25/2023 9:46 PM, Aditya Kumar Singh wrote:
>> 5 GHz band channel 177 support was added with the commit
>> "wifi: ath11k: add channel 177 into 5 GHz channel list". However,
>
> I'd use the same syntax here as in the Fixes tag:
> e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
>
Sure, I'll keep in mind from next time.
>> during processing for the received ppdu in ath11k_dp_rx_h_ppdu(), channel
>> number is checked only till 173. This leads to driver code checking for
>> channel and then fetching the band from it which is extra effort since
>> firmware has already given the channel number in the meta deta.
>
> nit: s/meta deta/metadata/
Oops! Thanks for pointing out.
Thanks Jeff for your comments.
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
@ 2023-07-27 12:02 ` Aditya Kumar Singh
0 siblings, 0 replies; 12+ messages in thread
From: Aditya Kumar Singh @ 2023-07-27 12:02 UTC (permalink / raw)
To: Jeff Johnson, ath11k; +Cc: linux-wireless
On 7/26/2023 22:24, Jeff Johnson wrote:
> On 7/25/2023 9:46 PM, Aditya Kumar Singh wrote:
>> 5 GHz band channel 177 support was added with the commit
>> "wifi: ath11k: add channel 177 into 5 GHz channel list". However,
>
> I'd use the same syntax here as in the Fixes tag:
> e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
>
Sure, I'll keep in mind from next time.
>> during processing for the received ppdu in ath11k_dp_rx_h_ppdu(), channel
>> number is checked only till 173. This leads to driver code checking for
>> channel and then fetching the band from it which is extra effort since
>> firmware has already given the channel number in the meta deta.
>
> nit: s/meta deta/metadata/
Oops! Thanks for pointing out.
Thanks Jeff for your comments.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
2023-07-26 4:46 ` Aditya Kumar Singh
@ 2023-08-02 11:49 ` Kalle Valo
-1 siblings, 0 replies; 12+ messages in thread
From: Kalle Valo @ 2023-08-02 11:49 UTC (permalink / raw)
To: Aditya Kumar Singh; +Cc: ath11k, linux-wireless, Aditya Kumar Singh
Aditya Kumar Singh <quic_adisi@quicinc.com> wrote:
> 5 GHz band channel 177 support was added with the commit e5e94d10c856 ("wifi:
> ath11k: add channel 177 into 5 GHz channel list"). However, during processing
> for the received ppdu in ath11k_dp_rx_h_ppdu(), channel number is checked only
> till 173. This leads to driver code checking for channel and then fetching the
> band from it which is extra effort since firmware has already given the channel
> number in the metadata.
>
> Fix this issue by checking the channel number till 177 since we support
> it now.
>
> Found via code review. Compile tested only.
>
> Fixes: e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list")
> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
72c8caf904ae wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230726044624.20507-1-quic_adisi@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-08-02 11:49 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-26 4:46 [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz Aditya Kumar Singh
2023-07-26 4:46 ` Aditya Kumar Singh
2023-07-26 16:54 ` Jeff Johnson
2023-07-26 16:54 ` Jeff Johnson
2023-07-27 6:12 ` Kalle Valo
2023-07-27 6:12 ` Kalle Valo
2023-07-27 12:00 ` Aditya Kumar Singh
2023-07-27 12:00 ` Aditya Kumar Singh
2023-07-27 12:02 ` Aditya Kumar Singh
2023-07-27 12:02 ` Aditya Kumar Singh
2023-08-02 11:49 ` Kalle Valo
2023-08-02 11:49 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.