From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>, Pawel Dembicki <paweldembicki@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Adam Baker <linux@baker-net.org.uk>,
Tony Dinh <mibodhi@gmail.com>
Subject: Re: [PATCH v2] ARM: dts: kirkwood: Add Zyxel NSA310S board
Date: Mon, 28 Nov 2022 00:54:14 +0100 [thread overview]
Message-ID: <87bkos9cnt.fsf@BL-laptop> (raw)
In-Reply-To: <Y16QkdYlQ2W5drqw@lunn.ch>
Andrew Lunn <andrew@lunn.ch> writes:
>> + ethphy0: ethernet-phy@1 {
>> + reg = <1>;
>> + phy-mode = "rgmii-id";
>> + marvell,reg-init = <0x1 0x16 0x0 0x3>,
>> + <0x1 0x10 0x0 0x1017>,
>> + <0x1 0x11 0x0 0x4408>,
>> + <0x1 0x16 0x0 0x0>;
>
> The indention is wrong here.
>
> Otherwise
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Andrew
Applied on mvebu/dt
I fixed the indentation while applying the patch.
Thanks,
Gregory
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>, Pawel Dembicki <paweldembicki@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Adam Baker <linux@baker-net.org.uk>,
Tony Dinh <mibodhi@gmail.com>
Subject: Re: [PATCH v2] ARM: dts: kirkwood: Add Zyxel NSA310S board
Date: Mon, 28 Nov 2022 00:54:14 +0100 [thread overview]
Message-ID: <87bkos9cnt.fsf@BL-laptop> (raw)
In-Reply-To: <Y16QkdYlQ2W5drqw@lunn.ch>
Andrew Lunn <andrew@lunn.ch> writes:
>> + ethphy0: ethernet-phy@1 {
>> + reg = <1>;
>> + phy-mode = "rgmii-id";
>> + marvell,reg-init = <0x1 0x16 0x0 0x3>,
>> + <0x1 0x10 0x0 0x1017>,
>> + <0x1 0x11 0x0 0x4408>,
>> + <0x1 0x16 0x0 0x0>;
>
> The indention is wrong here.
>
> Otherwise
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Andrew
Applied on mvebu/dt
I fixed the indentation while applying the patch.
Thanks,
Gregory
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2022-11-27 23:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 20:57 [PATCH v2] ARM: dts: kirkwood: Add Zyxel NSA310S board Pawel Dembicki
2022-10-29 20:57 ` Pawel Dembicki
2022-10-29 21:30 ` Adam Baker
2022-10-29 21:30 ` Adam Baker
2022-10-30 14:56 ` Andrew Lunn
2022-10-30 14:56 ` Andrew Lunn
2022-11-27 23:54 ` Gregory CLEMENT [this message]
2022-11-27 23:54 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkos9cnt.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@baker-net.org.uk \
--cc=mibodhi@gmail.com \
--cc=paweldembicki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.