* [PATCH] ALSA: asihpi - Remove useless code in hpi_meter_get_peak()
@ 2022-09-01 10:28 ` Valentina Goncharenko
0 siblings, 0 replies; 4+ messages in thread
From: Valentina Goncharenko @ 2022-09-01 10:28 UTC (permalink / raw)
To: Jaroslav Kysela
Cc: ldv-project, alsa-devel, Takashi Iwai, Valentina Goncharenko,
linux-kernel, Eliot Blennerhassett
The hpi_meter_get_peak() function contains the expression
"hm.obj_index = hm.obj_index", which does not carry any semantic load.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 719f82d3987a ("ALSA: Add support of AudioScience ASI boards")
Signed-off-by: Valentina Goncharenko <goncharenko.vp@ispras.ru>
---
sound/pci/asihpi/hpifunc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/pci/asihpi/hpifunc.c b/sound/pci/asihpi/hpifunc.c
index 1de05383126a..24047fafef51 100644
--- a/sound/pci/asihpi/hpifunc.c
+++ b/sound/pci/asihpi/hpifunc.c
@@ -2020,7 +2020,6 @@ u16 hpi_meter_get_peak(u32 h_control, short an_peakdB[HPI_MAX_CHANNELS]
HPI_CONTROL_GET_STATE);
if (hpi_handle_indexes(h_control, &hm.adapter_index, &hm.obj_index))
return HPI_ERROR_INVALID_HANDLE;
- hm.obj_index = hm.obj_index;
hm.u.c.attribute = HPI_METER_PEAK;
hpi_send_recv(&hm, &hr);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ALSA: asihpi - Remove useless code in hpi_meter_get_peak()
@ 2022-09-01 10:28 ` Valentina Goncharenko
0 siblings, 0 replies; 4+ messages in thread
From: Valentina Goncharenko @ 2022-09-01 10:28 UTC (permalink / raw)
To: Jaroslav Kysela
Cc: Valentina Goncharenko, Takashi Iwai, Eliot Blennerhassett,
alsa-devel, linux-kernel, ldv-project
The hpi_meter_get_peak() function contains the expression
"hm.obj_index = hm.obj_index", which does not carry any semantic load.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 719f82d3987a ("ALSA: Add support of AudioScience ASI boards")
Signed-off-by: Valentina Goncharenko <goncharenko.vp@ispras.ru>
---
sound/pci/asihpi/hpifunc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/pci/asihpi/hpifunc.c b/sound/pci/asihpi/hpifunc.c
index 1de05383126a..24047fafef51 100644
--- a/sound/pci/asihpi/hpifunc.c
+++ b/sound/pci/asihpi/hpifunc.c
@@ -2020,7 +2020,6 @@ u16 hpi_meter_get_peak(u32 h_control, short an_peakdB[HPI_MAX_CHANNELS]
HPI_CONTROL_GET_STATE);
if (hpi_handle_indexes(h_control, &hm.adapter_index, &hm.obj_index))
return HPI_ERROR_INVALID_HANDLE;
- hm.obj_index = hm.obj_index;
hm.u.c.attribute = HPI_METER_PEAK;
hpi_send_recv(&hm, &hr);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ALSA: asihpi - Remove useless code in hpi_meter_get_peak()
2022-09-01 10:28 ` Valentina Goncharenko
@ 2022-09-01 12:38 ` Takashi Iwai
-1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2022-09-01 12:38 UTC (permalink / raw)
To: Valentina Goncharenko
Cc: ldv-project, alsa-devel, linux-kernel, Takashi Iwai,
Eliot Blennerhassett
On Thu, 01 Sep 2022 12:28:14 +0200,
Valentina Goncharenko wrote:
>
> The hpi_meter_get_peak() function contains the expression
> "hm.obj_index = hm.obj_index", which does not carry any semantic load.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 719f82d3987a ("ALSA: Add support of AudioScience ASI boards")
> Signed-off-by: Valentina Goncharenko <goncharenko.vp@ispras.ru>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ALSA: asihpi - Remove useless code in hpi_meter_get_peak()
@ 2022-09-01 12:38 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2022-09-01 12:38 UTC (permalink / raw)
To: Valentina Goncharenko
Cc: Jaroslav Kysela, Takashi Iwai, Eliot Blennerhassett, alsa-devel,
linux-kernel, ldv-project
On Thu, 01 Sep 2022 12:28:14 +0200,
Valentina Goncharenko wrote:
>
> The hpi_meter_get_peak() function contains the expression
> "hm.obj_index = hm.obj_index", which does not carry any semantic load.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 719f82d3987a ("ALSA: Add support of AudioScience ASI boards")
> Signed-off-by: Valentina Goncharenko <goncharenko.vp@ispras.ru>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-02 6:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-01 10:28 [PATCH] ALSA: asihpi - Remove useless code in hpi_meter_get_peak() Valentina Goncharenko
2022-09-01 10:28 ` Valentina Goncharenko
2022-09-01 12:38 ` Takashi Iwai
2022-09-01 12:38 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.