From: ebiederm@xmission.com (Eric W. Biederman)
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
Simon Horman <horms@verge.net.au>,
Philippe Ombredanne <pombredanne@nexb.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
the arch/x86 maintainers <x86@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kexec Mailing List <kexec@lists.infradead.org>,
natechancellor@gmail.com, Ingo Molnar <mingo@redhat.com>,
Peter Anvin <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86/kexec: prefer _THIS_IP_ to current_text_addr
Date: Tue, 21 Aug 2018 14:40:02 +0200 [thread overview]
Message-ID: <87bm9v28rh.fsf@xmission.com> (raw)
In-Reply-To: <CA+55aFxHtbq=X9Jaes1qwVAhu5mx0eTahUjd7ijxgW44JjFaYQ@mail.gmail.com> (Linus Torvalds's message of "Mon, 20 Aug 2018 16:48:38 -0700")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Mon, Aug 20, 2018 at 10:58 AM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
>>
>> + akpm, Linus
>>
>> Bumping for review.
>
> Ugh. I am not personally a huge fan of this endless "fix up one at a time".
>
> Just do a patch that removes current_text_addr() entirely and be done
> with it, if that's what we want the end result to be.
>
> Don't bother with these small "let's remove the remaining ones one by
> one". Just get it over and done with.
One is generic code the other is assembly but the both appear to do the
same thing without unexpected complexity.
That said the patch earlier in this thread has clearly never been
compiled as it is using THIS_IP instead of _THIS_IP_ and there is not
a define of THIS_IP in the kernel.
Eric
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Peter Anvin <hpa@zytor.com>,
Simon Horman <horms@verge.net.au>,
Andrew Morton <akpm@linux-foundation.org>,
natechancellor@gmail.com,
"the arch\/x86 maintainers" <x86@kernel.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kexec Mailing List <kexec@lists.infradead.org>
Subject: Re: [PATCH] x86/kexec: prefer _THIS_IP_ to current_text_addr
Date: Tue, 21 Aug 2018 14:40:02 +0200 [thread overview]
Message-ID: <87bm9v28rh.fsf@xmission.com> (raw)
In-Reply-To: <CA+55aFxHtbq=X9Jaes1qwVAhu5mx0eTahUjd7ijxgW44JjFaYQ@mail.gmail.com> (Linus Torvalds's message of "Mon, 20 Aug 2018 16:48:38 -0700")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Mon, Aug 20, 2018 at 10:58 AM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
>>
>> + akpm, Linus
>>
>> Bumping for review.
>
> Ugh. I am not personally a huge fan of this endless "fix up one at a time".
>
> Just do a patch that removes current_text_addr() entirely and be done
> with it, if that's what we want the end result to be.
>
> Don't bother with these small "let's remove the remaining ones one by
> one". Just get it over and done with.
One is generic code the other is assembly but the both appear to do the
same thing without unexpected complexity.
That said the patch earlier in this thread has clearly never been
compiled as it is using THIS_IP instead of _THIS_IP_ and there is not
a define of THIS_IP in the kernel.
Eric
next prev parent reply other threads:[~2018-08-21 12:41 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 21:08 [PATCH] x86/kexec: prefer _THIS_IP_ to current_text_addr Nick Desaulniers
2018-08-08 23:06 ` Nick Desaulniers
2018-08-08 23:06 ` Nick Desaulniers
2018-08-13 21:32 ` Nick Desaulniers
2018-08-13 21:32 ` Nick Desaulniers
2018-08-20 17:58 ` Nick Desaulniers
2018-08-20 17:58 ` Nick Desaulniers
2018-08-20 23:48 ` Linus Torvalds
2018-08-20 23:48 ` Linus Torvalds
2018-08-21 12:40 ` Eric W. Biederman [this message]
2018-08-21 12:40 ` Eric W. Biederman
2018-08-21 16:26 ` Nick Desaulniers
2018-08-21 16:26 ` Nick Desaulniers
2018-08-21 20:28 ` [PATCH] treewide: remove current_text_addr Nick Desaulniers
2018-08-21 20:28 ` [OpenRISC] " Nick Desaulniers
2018-08-21 20:28 ` Nick Desaulniers
2018-08-21 20:28 ` Nick Desaulniers
2018-08-21 20:28 ` Nick Desaulniers
2018-08-25 10:48 ` Helge Deller
2018-08-25 10:48 ` [OpenRISC] " Helge Deller
2018-08-25 10:48 ` Helge Deller
2018-08-25 10:48 ` Helge Deller
2018-08-25 10:48 ` Helge Deller
2018-08-26 2:38 ` H. Peter Anvin
2018-08-26 2:38 ` [OpenRISC] " H. Peter Anvin
2018-08-26 2:38 ` H. Peter Anvin
2018-08-26 2:38 ` H. Peter Anvin
2018-08-26 2:38 ` H. Peter Anvin
2018-08-26 3:16 ` H. Peter Anvin
2018-08-26 3:16 ` [OpenRISC] " H. Peter Anvin
2018-08-26 3:16 ` H. Peter Anvin
2018-08-26 3:16 ` H. Peter Anvin
2018-08-26 3:16 ` H. Peter Anvin
2018-08-26 4:56 ` H. Peter Anvin
2018-08-26 4:56 ` [OpenRISC] " H. Peter Anvin
2018-08-26 4:56 ` H. Peter Anvin
2018-08-26 4:56 ` H. Peter Anvin
2018-08-26 4:56 ` H. Peter Anvin
2018-08-26 19:30 ` H. Peter Anvin
2018-08-26 19:30 ` [OpenRISC] " H. Peter Anvin
2018-08-26 19:30 ` H. Peter Anvin
2018-08-26 19:30 ` H. Peter Anvin
2018-08-26 19:30 ` H. Peter Anvin
2018-08-26 20:25 ` Linus Torvalds
2018-08-26 20:25 ` [OpenRISC] " Linus Torvalds
2018-08-26 20:25 ` Linus Torvalds
2018-08-26 20:25 ` Linus Torvalds
2018-08-26 20:25 ` Linus Torvalds
2018-08-26 20:25 ` Linus Torvalds
2018-08-27 2:52 ` Nick Desaulniers
2018-08-27 2:52 ` [OpenRISC] " Nick Desaulniers
2018-08-27 2:52 ` Nick Desaulniers
2018-08-27 2:52 ` Nick Desaulniers
2018-08-27 2:52 ` Nick Desaulniers
2018-08-27 2:52 ` Nick Desaulniers
2018-08-27 7:33 ` Peter Zijlstra
2018-08-27 7:33 ` [OpenRISC] " Peter Zijlstra
2018-08-27 7:33 ` Peter Zijlstra
2018-08-27 7:33 ` Peter Zijlstra
2018-08-27 7:33 ` Peter Zijlstra
2018-08-27 7:33 ` Peter Zijlstra
2018-08-27 12:26 ` H. Peter Anvin
2018-08-27 12:26 ` [OpenRISC] " H. Peter Anvin
2018-08-27 12:26 ` H. Peter Anvin
2018-08-27 12:26 ` H. Peter Anvin
2018-08-27 12:26 ` H. Peter Anvin
2018-08-27 12:26 ` H. Peter Anvin
2018-08-27 13:11 ` Peter Zijlstra
2018-08-27 13:11 ` [OpenRISC] " Peter Zijlstra
2018-08-27 13:11 ` Peter Zijlstra
2018-08-27 13:11 ` Peter Zijlstra
2018-08-27 13:11 ` Peter Zijlstra
2018-08-27 13:11 ` Peter Zijlstra
2018-08-27 13:33 ` H. Peter Anvin
2018-08-27 13:33 ` [OpenRISC] " H. Peter Anvin
2018-08-27 13:33 ` H. Peter Anvin
2018-08-27 13:33 ` H. Peter Anvin
2018-08-27 13:33 ` H. Peter Anvin
2018-08-27 13:33 ` H. Peter Anvin
2018-08-31 16:48 ` Nick Desaulniers
2018-08-31 16:49 ` Nick Desaulniers
2018-08-31 16:48 ` [OpenRISC] " Nick Desaulniers
2018-08-31 16:48 ` Nick Desaulniers
2018-08-31 16:48 ` Nick Desaulniers
2018-08-27 7:43 ` Nicholas Piggin
2018-08-27 7:43 ` Nicholas Piggin
2018-08-27 7:43 ` [OpenRISC] " Nicholas Piggin
2018-08-27 7:43 ` Nicholas Piggin
2018-08-27 7:43 ` Nicholas Piggin
2018-08-27 7:43 ` Nicholas Piggin
2018-08-27 7:43 ` Nicholas Piggin
2018-08-27 7:43 ` Nicholas Piggin
2018-08-26 23:20 ` H. Peter Anvin
2018-08-26 23:20 ` H. Peter Anvin
2018-08-26 23:20 ` [OpenRISC] " H. Peter Anvin
2018-08-26 23:20 ` H. Peter Anvin
2018-08-26 23:20 ` H. Peter Anvin
2018-08-26 23:20 ` H. Peter Anvin
2018-08-26 23:20 ` H. Peter Anvin
2018-08-26 23:20 ` H. Peter Anvin
2018-08-25 21:02 ` Linus Torvalds
2018-08-25 21:02 ` [OpenRISC] " Linus Torvalds
2018-08-25 21:02 ` Linus Torvalds
2018-08-25 21:02 ` Linus Torvalds
2018-08-25 21:02 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm9v28rh.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.