All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Michael Büsch" <m@bues.ch>,
	"Larry Finger" <larry.finger@lwfinger.net>,
	"Matt Redfearn" <matt.redfearn@mips.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Hauke Mehrtens" <hauke@hauke-m.de>,
	LKML <linux-kernel@vger.kernel.org>,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module"
Date: Fri, 11 May 2018 13:13:33 +0300	[thread overview]
Message-ID: <87bmdmcxf6.fsf@codeaurora.org> (raw)
In-Reply-To: <CACna6ry-91oR1u697NRymLsN28fnnHDp9OQrdiVwA7A3KTV1fg@mail.gmail.com> ("Rafał Miłecki"'s message of "Fri, 11 May 2018 11:21:11 +0200")

Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.com> writes:

> On 11 May 2018 at 11:17, Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.com> wrote:
>> From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>>
>> This reverts commit 882164a4a928bcaa53280940436ca476e6b1db8e.
>>
>> Above commit added "SSB =3D y" dependency to the wrong symbol
>> SSB_DRIVER_PCICORE_POSSIBLE and prevented SSB_DRIVER_PCICORE from being
>> selected when needed. PCI core driver for core running in clienthost
>> mode is important for bus initialization. It's perfectly valid scenario
>> to have ssb built as module and use it with buses on PCI cards.
>>
>> This fixes regression that affected all *module* users with PCI cards.
>>
>> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=3D1572349
>> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>
> As these patches fix regression/build error, I believe both should get
> into 4.17.

How much confidence do we have that we don't need to end up reverting
patch 2 as well? I rather be pushing patch 2 to 4.18 so that there's
more time for testing and waiting for feedback.

--=20
Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Michael Büsch" <m@bues.ch>,
	"Larry Finger" <larry.finger@lwfinger.net>,
	"Matt Redfearn" <matt.redfearn@mips.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Hauke Mehrtens" <hauke@hauke-m.de>,
	LKML <linux-kernel@vger.kernel.org>,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module"
Date: Fri, 11 May 2018 13:13:33 +0300	[thread overview]
Message-ID: <87bmdmcxf6.fsf@codeaurora.org> (raw)
In-Reply-To: <CACna6ry-91oR1u697NRymLsN28fnnHDp9OQrdiVwA7A3KTV1fg@mail.gmail.com> ("Rafał Miłecki"'s message of "Fri, 11 May 2018 11:21:11 +0200")

Rafał Miłecki <zajec5@gmail.com> writes:

> On 11 May 2018 at 11:17, Rafał Miłecki <zajec5@gmail.com> wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> This reverts commit 882164a4a928bcaa53280940436ca476e6b1db8e.
>>
>> Above commit added "SSB = y" dependency to the wrong symbol
>> SSB_DRIVER_PCICORE_POSSIBLE and prevented SSB_DRIVER_PCICORE from being
>> selected when needed. PCI core driver for core running in clienthost
>> mode is important for bus initialization. It's perfectly valid scenario
>> to have ssb built as module and use it with buses on PCI cards.
>>
>> This fixes regression that affected all *module* users with PCI cards.
>>
>> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1572349
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>
> As these patches fix regression/build error, I believe both should get
> into 4.17.

How much confidence do we have that we don't need to end up reverting
patch 2 as well? I rather be pushing patch 2 to 4.18 so that there's
more time for testing and waiting for feedback.

-- 
Kalle Valo

  reply	other threads:[~2018-05-11 10:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11  9:17 [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module" Rafał Miłecki
2018-05-11  9:17 ` [PATCH V2 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y Rafał Miłecki
2018-05-11  9:21 ` [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module" Rafał Miłecki
2018-05-11  9:21   ` Rafał Miłecki
2018-05-11 10:13   ` Kalle Valo [this message]
2018-05-11 10:13     ` Kalle Valo
2018-05-11 10:25     ` Rafał Miłecki
2018-05-11 10:25       ` Rafał Miłecki
2018-05-11 12:08     ` Larry Finger
2018-05-12  7:50       ` Kalle Valo
2018-05-12  7:50         ` Kalle Valo
2018-05-12  8:01         ` Michael Büsch
2018-05-12 10:00           ` Rafał Miłecki
2018-05-12 10:14             ` Michael Büsch
2018-05-12  8:40 ` [V2, " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmdmcxf6.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=hauke@hauke-m.de \
    --cc=larry.finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=m@bues.ch \
    --cc=matt.redfearn@mips.com \
    --cc=rafal@milecki.pl \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.