All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] ARM: dts: armada-370-rd: Utilize new DSA binding
Date: Thu, 05 Jan 2017 10:41:16 +0100	[thread overview]
Message-ID: <87bmvletdv.fsf@free-electrons.com> (raw)
In-Reply-To: <307da709-5dbd-845b-b7ec-d0c3d46ad2e6@gmail.com> (Florian Fainelli's message of "Wed, 4 Jan 2017 09:30:07 -0800")

Hi Florian,
 
 On mer., janv. 04 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:

> On 01/03/2017 08:36 AM, Andrew Lunn wrote:
>>> +
>>> +	switch: switch at 10 {
>>> +		compatible = "marvell,mv88e6085";
>>> +		#address-cells = <1>;
>>> +		#size-cells = <0>;
>>> +		reg = <16>;
>> 
>> Hummm, a device tree question. switch at 10, reg = <16>. Is there an
>> implicit understanding that the 10 is hex?
>
> Most (if not all?) unit addresses are hexadecimal, which is why this was
> chosen here, but I really don't mind changing that.

And what about using:
		reg = <0x10>;

Gregory

> -- 
> Florian

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
	Jason Cooper <jason@lakedaemon.net>,
	vivien.didelot@savoirfairelinux.com,
	Russell King <linux@armlinux.org.uk>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 1/8] ARM: dts: armada-370-rd: Utilize new DSA binding
Date: Thu, 05 Jan 2017 10:41:16 +0100	[thread overview]
Message-ID: <87bmvletdv.fsf@free-electrons.com> (raw)
In-Reply-To: <307da709-5dbd-845b-b7ec-d0c3d46ad2e6@gmail.com> (Florian Fainelli's message of "Wed, 4 Jan 2017 09:30:07 -0800")

Hi Florian,
 
 On mer., janv. 04 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:

> On 01/03/2017 08:36 AM, Andrew Lunn wrote:
>>> +
>>> +	switch: switch@10 {
>>> +		compatible = "marvell,mv88e6085";
>>> +		#address-cells = <1>;
>>> +		#size-cells = <0>;
>>> +		reg = <16>;
>> 
>> Hummm, a device tree question. switch@10, reg = <16>. Is there an
>> implicit understanding that the 10 is hex?
>
> Most (if not all?) unit addresses are hexadecimal, which is why this was
> chosen here, but I really don't mind changing that.

And what about using:
		reg = <0x10>;

Gregory

> -- 
> Florian

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	linux-arm-kernel@lists.infradead.org,
	vivien.didelot@savoirfairelinux.com,
	Jason Cooper <jason@lakedaemon.net>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	"open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/8] ARM: dts: armada-370-rd: Utilize new DSA binding
Date: Thu, 05 Jan 2017 10:41:16 +0100	[thread overview]
Message-ID: <87bmvletdv.fsf@free-electrons.com> (raw)
In-Reply-To: <307da709-5dbd-845b-b7ec-d0c3d46ad2e6@gmail.com> (Florian Fainelli's message of "Wed, 4 Jan 2017 09:30:07 -0800")

Hi Florian,
 
 On mer., janv. 04 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:

> On 01/03/2017 08:36 AM, Andrew Lunn wrote:
>>> +
>>> +	switch: switch@10 {
>>> +		compatible = "marvell,mv88e6085";
>>> +		#address-cells = <1>;
>>> +		#size-cells = <0>;
>>> +		reg = <16>;
>> 
>> Hummm, a device tree question. switch@10, reg = <16>. Is there an
>> implicit understanding that the 10 is hex?
>
> Most (if not all?) unit addresses are hexadecimal, which is why this was
> chosen here, but I really don't mind changing that.

And what about using:
		reg = <0x10>;

Gregory

> -- 
> Florian

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2017-01-05  9:41 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02  2:22 [PATCH 0/8] ARM: dts: Switch to new DSA binding Florian Fainelli
2017-01-02  2:22 ` Florian Fainelli
2017-01-02  2:22 ` Florian Fainelli
2017-01-02  2:22 ` [PATCH 1/8] ARM: dts: armada-370-rd: Utilize " Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-03 16:36   ` Andrew Lunn
2017-01-03 16:36     ` Andrew Lunn
2017-01-03 16:36     ` Andrew Lunn
2017-01-04 17:30     ` Florian Fainelli
2017-01-04 17:30       ` Florian Fainelli
2017-01-04 17:30       ` Florian Fainelli
2017-01-05  9:41       ` Gregory CLEMENT [this message]
2017-01-05  9:41         ` Gregory CLEMENT
2017-01-05  9:41         ` Gregory CLEMENT
2017-01-02  2:22 ` [PATCH 2/8] ARM: dts: armada-38x: " Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-03 16:14   ` Gregory CLEMENT
2017-01-03 16:14     ` Gregory CLEMENT
2017-01-03 16:14     ` Gregory CLEMENT
2017-01-02  2:22 ` [PATCH 3/8] ARM: dts: armada-388-clearfog: " Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-02  8:59   ` Neil Armstrong
2017-01-02  8:59     ` Neil Armstrong
2017-01-04 17:23   ` Gregory CLEMENT
2017-01-04 17:23     ` Gregory CLEMENT
2017-01-04 17:23     ` Gregory CLEMENT
2017-01-04 17:27     ` Florian Fainelli
2017-01-04 17:27       ` Florian Fainelli
2017-01-04 17:27       ` Florian Fainelli
2017-01-04 17:38       ` Vivien Didelot
2017-01-04 17:38         ` Vivien Didelot
2017-01-04 17:38         ` Vivien Didelot
2017-01-04 17:42         ` Andrew Lunn
2017-01-04 17:42           ` Andrew Lunn
2017-01-04 17:48           ` Vivien Didelot
2017-01-04 17:48             ` Vivien Didelot
2017-01-04 17:48             ` Vivien Didelot
2017-01-05 12:55       ` Gregory CLEMENT
2017-01-05 12:55         ` Gregory CLEMENT
2017-01-05 12:55         ` Gregory CLEMENT
2017-01-02  2:22 ` [PATCH 4/8] ARM: dts: armada-xp-linksys-mamba: " Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-02  2:22 ` [PATCH 5/8] ARM: dts: kirkwood-dir665: " Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-02  2:22 ` [PATCH 6/8] ARM: dts: kirkwood-linksys-viper: " Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-02  2:22 ` [PATCH 7/8] ARM: dts: kirkwood-mv88f6281gtw-ge: " Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-02  2:22 ` [PATCH 8/8] ARM: dts: kirkwood-rd88f6281: " Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-02  2:22   ` Florian Fainelli
2017-01-03 16:19 ` [PATCH 0/8] ARM: dts: Switch to " Gregory CLEMENT
2017-01-03 16:19   ` Gregory CLEMENT
2017-01-03 16:19   ` Gregory CLEMENT
2017-01-03 16:32   ` Andrew Lunn
2017-01-03 16:32     ` Andrew Lunn
2017-01-03 16:32     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmvletdv.fsf@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.