From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding
Date: Thu, 05 Jan 2017 13:55:17 +0100 [thread overview]
Message-ID: <87k2a9d5u2.fsf@free-electrons.com> (raw)
In-Reply-To: <5a40436a-ebad-8a94-c5c5-546ba33ba545@gmail.com> (Florian Fainelli's message of "Wed, 4 Jan 2017 09:27:35 -0800")
Hi Florian,
On mer., janv. 04 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 01/04/2017 09:23 AM, Gregory CLEMENT wrote:
>> Hi Florian,
>>
>> On lun., janv. 02 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>>> Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net:
>>> dsa: Document new binding"). The legacy binding node is kept included, but is
>>> marked disabled.
>>>
>>
>> I tested this patch on mvebu/dt (I needed to reduce the context to apply
>> the patch due to the changes made by Russell King on this file). I also
>> set the status of the old binding to "disable" (instead of "okay").
>
> Yes, that needs fixing, thanks for mentioning that.
>
>>
>> It seems to work with the limited test did:
>> ifconfig eth1 up
>> udhcpc -i lan1
>> iperf -c mylaptop
>>
>> (same for lan4)
>>
>> However is there a way to be sure that the new binding is used?
>
> The best way is probably to make sure that your switch device appears
> parented to the MDIO bus driver under /sys/class/mdio_bus/*mvmdio*.
> Alternatively, if you see a message like:
>
> DSA: switch 0 0 parsed
>
> in your dmesg, that would also be indicative of using the new binding
> and corresponding code.
So it's OK I had this message.
Gregory
>
> Thanks a lot for trying that out!
> --
> Florian
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
vivien.didelot-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding
Date: Thu, 05 Jan 2017 13:55:17 +0100 [thread overview]
Message-ID: <87k2a9d5u2.fsf@free-electrons.com> (raw)
In-Reply-To: <5a40436a-ebad-8a94-c5c5-546ba33ba545-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> (Florian Fainelli's message of "Wed, 4 Jan 2017 09:27:35 -0800")
Hi Florian,
On mer., janv. 04 2017, Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On 01/04/2017 09:23 AM, Gregory CLEMENT wrote:
>> Hi Florian,
>>
>> On lun., janv. 02 2017, Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>
>>> Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net:
>>> dsa: Document new binding"). The legacy binding node is kept included, but is
>>> marked disabled.
>>>
>>
>> I tested this patch on mvebu/dt (I needed to reduce the context to apply
>> the patch due to the changes made by Russell King on this file). I also
>> set the status of the old binding to "disable" (instead of "okay").
>
> Yes, that needs fixing, thanks for mentioning that.
>
>>
>> It seems to work with the limited test did:
>> ifconfig eth1 up
>> udhcpc -i lan1
>> iperf -c mylaptop
>>
>> (same for lan4)
>>
>> However is there a way to be sure that the new binding is used?
>
> The best way is probably to make sure that your switch device appears
> parented to the MDIO bus driver under /sys/class/mdio_bus/*mvmdio*.
> Alternatively, if you see a message like:
>
> DSA: switch 0 0 parsed
>
> in your dmesg, that would also be indicative of using the new binding
> and corresponding code.
So it's OK I had this message.
Gregory
>
> Thanks a lot for trying that out!
> --
> Florian
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
vivien.didelot@savoirfairelinux.com,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
"open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding
Date: Thu, 05 Jan 2017 13:55:17 +0100 [thread overview]
Message-ID: <87k2a9d5u2.fsf@free-electrons.com> (raw)
In-Reply-To: <5a40436a-ebad-8a94-c5c5-546ba33ba545@gmail.com> (Florian Fainelli's message of "Wed, 4 Jan 2017 09:27:35 -0800")
Hi Florian,
On mer., janv. 04 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 01/04/2017 09:23 AM, Gregory CLEMENT wrote:
>> Hi Florian,
>>
>> On lun., janv. 02 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>>> Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net:
>>> dsa: Document new binding"). The legacy binding node is kept included, but is
>>> marked disabled.
>>>
>>
>> I tested this patch on mvebu/dt (I needed to reduce the context to apply
>> the patch due to the changes made by Russell King on this file). I also
>> set the status of the old binding to "disable" (instead of "okay").
>
> Yes, that needs fixing, thanks for mentioning that.
>
>>
>> It seems to work with the limited test did:
>> ifconfig eth1 up
>> udhcpc -i lan1
>> iperf -c mylaptop
>>
>> (same for lan4)
>>
>> However is there a way to be sure that the new binding is used?
>
> The best way is probably to make sure that your switch device appears
> parented to the MDIO bus driver under /sys/class/mdio_bus/*mvmdio*.
> Alternatively, if you see a message like:
>
> DSA: switch 0 0 parsed
>
> in your dmesg, that would also be indicative of using the new binding
> and corresponding code.
So it's OK I had this message.
Gregory
>
> Thanks a lot for trying that out!
> --
> Florian
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-01-05 12:55 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 2:22 [PATCH 0/8] ARM: dts: Switch to new DSA binding Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` [PATCH 1/8] ARM: dts: armada-370-rd: Utilize " Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-03 16:36 ` Andrew Lunn
2017-01-03 16:36 ` Andrew Lunn
2017-01-03 16:36 ` Andrew Lunn
2017-01-04 17:30 ` Florian Fainelli
2017-01-04 17:30 ` Florian Fainelli
2017-01-04 17:30 ` Florian Fainelli
2017-01-05 9:41 ` Gregory CLEMENT
2017-01-05 9:41 ` Gregory CLEMENT
2017-01-05 9:41 ` Gregory CLEMENT
2017-01-02 2:22 ` [PATCH 2/8] ARM: dts: armada-38x: " Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-03 16:14 ` Gregory CLEMENT
2017-01-03 16:14 ` Gregory CLEMENT
2017-01-03 16:14 ` Gregory CLEMENT
2017-01-02 2:22 ` [PATCH 3/8] ARM: dts: armada-388-clearfog: " Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 8:59 ` Neil Armstrong
2017-01-02 8:59 ` Neil Armstrong
2017-01-04 17:23 ` Gregory CLEMENT
2017-01-04 17:23 ` Gregory CLEMENT
2017-01-04 17:23 ` Gregory CLEMENT
2017-01-04 17:27 ` Florian Fainelli
2017-01-04 17:27 ` Florian Fainelli
2017-01-04 17:27 ` Florian Fainelli
2017-01-04 17:38 ` Vivien Didelot
2017-01-04 17:38 ` Vivien Didelot
2017-01-04 17:38 ` Vivien Didelot
2017-01-04 17:42 ` Andrew Lunn
2017-01-04 17:42 ` Andrew Lunn
2017-01-04 17:48 ` Vivien Didelot
2017-01-04 17:48 ` Vivien Didelot
2017-01-04 17:48 ` Vivien Didelot
2017-01-05 12:55 ` Gregory CLEMENT [this message]
2017-01-05 12:55 ` Gregory CLEMENT
2017-01-05 12:55 ` Gregory CLEMENT
2017-01-02 2:22 ` [PATCH 4/8] ARM: dts: armada-xp-linksys-mamba: " Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` [PATCH 5/8] ARM: dts: kirkwood-dir665: " Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` [PATCH 6/8] ARM: dts: kirkwood-linksys-viper: " Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` [PATCH 7/8] ARM: dts: kirkwood-mv88f6281gtw-ge: " Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` [PATCH 8/8] ARM: dts: kirkwood-rd88f6281: " Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-02 2:22 ` Florian Fainelli
2017-01-03 16:19 ` [PATCH 0/8] ARM: dts: Switch to " Gregory CLEMENT
2017-01-03 16:19 ` Gregory CLEMENT
2017-01-03 16:19 ` Gregory CLEMENT
2017-01-03 16:32 ` Andrew Lunn
2017-01-03 16:32 ` Andrew Lunn
2017-01-03 16:32 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2a9d5u2.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.