All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	linux-firmware@kernel.org
Subject: Re: [PATCH 1/5] ath10k: QCA988X hw2.0: add board.bin
Date: Tue, 20 Oct 2015 15:29:13 +0300	[thread overview]
Message-ID: <87bnbtd8py.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1445193116.31451.78.camel@decadent.org.uk> (Ben Hutchings's message of "Sun, 18 Oct 2015 19:31:56 +0100")

Ben Hutchings <ben@decadent.org.uk> writes:

> On Sun, 2015-10-18 at 19:23 +0100, Ben Hutchings wrote:
>> On Thu, 2015-10-15 at 13:40 +0300, Kalle Valo wrote:
>> > In commit 40d14143b787 ("ath10k: add firmware 10.2.4.45 as firmware-4.bin") I
>> > forgot to commit board.bin file and that's why it was not included in the
>> > commit even I had added an entry to WHENCE. Add that now.
>> > 
>> > At the same time also add Version field for firmware-4.bin.
>> > 
>> > Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
>> [...]
>> 
>> I've applied this and the following 4 patches.  However, I'm not
>> entirely happy with copyright acknowledgements going into the
>> notice_ath10k*.txt files which aren't referenced anywhere.  It would be
>> easy for downstream distributors to miss that they should be packaged
>> along with the firmware blobs they relate to.  Please can you combine
>> these with the QCA licence file or add references to these files from
>> WHENCE?
>> 
>
> Also please make sure that all text files are encoded as UTF-8 (or
> ASCII).  A couple of the notices had quote characters which I
> eventually worked out to be GB2312-encoded.

Sorry about that, I'll check for that in the future.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: <linux-firmware@kernel.org>, <linux-wireless@vger.kernel.org>,
	<ath10k@lists.infradead.org>
Subject: Re: [PATCH 1/5] ath10k: QCA988X hw2.0: add board.bin
Date: Tue, 20 Oct 2015 15:29:13 +0300	[thread overview]
Message-ID: <87bnbtd8py.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1445193116.31451.78.camel@decadent.org.uk> (Ben Hutchings's message of "Sun, 18 Oct 2015 19:31:56 +0100")

Ben Hutchings <ben@decadent.org.uk> writes:

> On Sun, 2015-10-18 at 19:23 +0100, Ben Hutchings wrote:
>> On Thu, 2015-10-15 at 13:40 +0300, Kalle Valo wrote:
>> > In commit 40d14143b787 ("ath10k: add firmware 10.2.4.45 as firmware-4.bin") I
>> > forgot to commit board.bin file and that's why it was not included in the
>> > commit even I had added an entry to WHENCE. Add that now.
>> > 
>> > At the same time also add Version field for firmware-4.bin.
>> > 
>> > Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
>> [...]
>> 
>> I've applied this and the following 4 patches.  However, I'm not
>> entirely happy with copyright acknowledgements going into the
>> notice_ath10k*.txt files which aren't referenced anywhere.  It would be
>> easy for downstream distributors to miss that they should be packaged
>> along with the firmware blobs they relate to.  Please can you combine
>> these with the QCA licence file or add references to these files from
>> WHENCE?
>> 
>
> Also please make sure that all text files are encoded as UTF-8 (or
> ASCII).  A couple of the notices had quote characters which I
> eventually worked out to be GB2312-encoded.

Sorry about that, I'll check for that in the future.

-- 
Kalle Valo

  reply	other threads:[~2015-10-20 12:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 10:40 [PATCH 1/5] ath10k: QCA988X hw2.0: add board.bin Kalle Valo
2015-10-15 10:40 ` Kalle Valo
2015-10-15 10:40 ` [PATCH 2/5] ath10k: QCA988X hw2.0: add firmware 10.2.4.70.9-2 Kalle Valo
2015-10-15 10:40   ` Kalle Valo
2015-10-15 10:40 ` [PATCH 3/5] ath10k: QCA6174 hw2.1: add firmware WLAN.RM.1.1-00141 and board.bin Kalle Valo
2015-10-15 10:40   ` Kalle Valo
2015-10-15 10:40 ` [PATCH 4/5] ath10k: QCA6174 hw3.0: add WLAN.RM.2.0-00180-QCARMSWPZ-1 Kalle Valo
2015-10-15 10:40   ` Kalle Valo
2015-10-15 10:40 ` [PATCH 5/5] ath10k: QCA99X0 hw2.0: add firmware 10.4.1.00030-1 and board.bin Kalle Valo
2015-10-15 10:40   ` Kalle Valo
2015-10-18 18:23 ` [PATCH 1/5] ath10k: QCA988X hw2.0: add board.bin Ben Hutchings
2015-10-18 18:23   ` Ben Hutchings
2015-10-18 18:31   ` Ben Hutchings
2015-10-18 18:31     ` Ben Hutchings
2015-10-20 12:29     ` Kalle Valo [this message]
2015-10-20 12:29       ` Kalle Valo
2015-10-20 12:21   ` Kalle Valo
2015-10-20 12:21     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnbtd8py.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=ben@decadent.org.uk \
    --cc=linux-firmware@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.