Re: [PATCH V3 03/19] OMAP3+: voltage: remove initial voltage

[Kevin Hilman <khilman@ti.com>]

Nishanth Menon <nm@ti.com> writes:

> Blindly setting a 1.2V setting in the initial structure may not even
> match the default voltages stored in the voltage table which are
> supported for the domain. For example, OMAP3430 core domain does not
> use 1.2V and ends up generating a warning on the first transition.
>
> Further, since omap2_set_init_voltage is called as part of the pm
> framework's initialization sequence to configure the voltage required
> for the current OPP, the call does(and has to) setup the system
> voltage(curr_volt as a result) using the right mechanisms appropriate
> for the system at that point of time. This also overrides
> initialization we are currently doing in voltage.c making it
> redundant. So, remove the wrong and redundant initialization.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>

Thanks queuing for 2.6.39 fixes (branch: for_2.6.39/pm-fixes)

Note: Nishanth, I queued the one with updated changelog from the tarball
you sent.)

Kevin

> ---
>  arch/arm/mach-omap2/voltage.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c
> index 56961df..1b40aa0 100644
> --- a/arch/arm/mach-omap2/voltage.c
> +++ b/arch/arm/mach-omap2/voltage.c
> @@ -116,7 +116,6 @@ static int __init _config_common_vdd_data(struct omap_vdd_info *vdd)
>  	sys_clk_speed /= 1000;
>  
>  	/* Generic voltage parameters */
> -	vdd->curr_volt = 1200000;
>  	vdd->volt_scale = vp_forceupdate_scale_voltage;
>  	vdd->vp_enabled = false;