All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
	linux-arm <linux-arm-kernel@lists.infradead.org>,
	Tony <tony@atomide.com>, Paul <paul@pwsan.com>
Subject: Re: [PATCH V3 09/19] OMAP3+: SR: disable interrupt by default
Date: Thu, 17 Mar 2011 10:19:31 -0700	[thread overview]
Message-ID: <87hbb18y1o.fsf@ti.com> (raw)
In-Reply-To: <1299338962-5602-10-git-send-email-nm@ti.com> (Nishanth Menon's message of "Sat, 5 Mar 2011 20:59:12 +0530")

Nishanth Menon <nm@ti.com> writes:

> We will enable and disable interrupt on a need basis in the class
> driver. We need to keep the IRQ disabled by default else the
> forceupdate or vcbypass events could trigger events that we don't
> need/expect to handle.
>
> This is a preparation for SmartReflex AVS class drivers such as
> class 2 and class 1.5 which would need to use interrupts. Existing
> SmartReflex AVS class 3 driver does not require to use interrupts
> and is not impacted by this change.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>

Thanks, queueing for 2.6.40

Kevin

> ---
>  arch/arm/mach-omap2/smartreflex.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> index 7096300..f9057ad 100644
> --- a/arch/arm/mach-omap2/smartreflex.c
> +++ b/arch/arm/mach-omap2/smartreflex.c
> @@ -267,6 +267,7 @@ static int sr_late_init(struct omap_sr *sr_info)
>  				0, name, (void *)sr_info);
>  		if (ret)
>  			goto error;
> +		disable_irq(sr_info->irq);
>  	}
>  
>  	if (pdata && pdata->enable_on_init)

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 09/19] OMAP3+: SR: disable interrupt by default
Date: Thu, 17 Mar 2011 10:19:31 -0700	[thread overview]
Message-ID: <87hbb18y1o.fsf@ti.com> (raw)
In-Reply-To: <1299338962-5602-10-git-send-email-nm@ti.com> (Nishanth Menon's message of "Sat, 5 Mar 2011 20:59:12 +0530")

Nishanth Menon <nm@ti.com> writes:

> We will enable and disable interrupt on a need basis in the class
> driver. We need to keep the IRQ disabled by default else the
> forceupdate or vcbypass events could trigger events that we don't
> need/expect to handle.
>
> This is a preparation for SmartReflex AVS class drivers such as
> class 2 and class 1.5 which would need to use interrupts. Existing
> SmartReflex AVS class 3 driver does not require to use interrupts
> and is not impacted by this change.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>

Thanks, queueing for 2.6.40

Kevin

> ---
>  arch/arm/mach-omap2/smartreflex.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> index 7096300..f9057ad 100644
> --- a/arch/arm/mach-omap2/smartreflex.c
> +++ b/arch/arm/mach-omap2/smartreflex.c
> @@ -267,6 +267,7 @@ static int sr_late_init(struct omap_sr *sr_info)
>  				0, name, (void *)sr_info);
>  		if (ret)
>  			goto error;
> +		disable_irq(sr_info->irq);
>  	}
>  
>  	if (pdata && pdata->enable_on_init)

  reply	other threads:[~2011-03-17 17:19 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-05 15:29 [PATCH V3 00/19] OMAP3+: PM: introduce SR class 1.5 Nishanth Menon
2011-03-05 15:29 ` Nishanth Menon
2011-03-05 15:29 ` [PATCH V3 01/19] OMAP3: hwmod: add SmartReflex IRQs Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-17 14:41   ` Kevin Hilman
2011-03-17 14:41     ` Kevin Hilman
2011-07-26 13:11   ` Felipe Balbi
2011-07-26 13:11     ` Felipe Balbi
2011-03-05 15:29 ` [PATCH V3 02/19] OMAP3+: voltage: fix build warning Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-17 14:49   ` Kevin Hilman
2011-03-17 14:49     ` Kevin Hilman
2011-07-26 13:12   ` Felipe Balbi
2011-07-26 13:12     ` Felipe Balbi
2011-03-05 15:29 ` [PATCH V3 03/19] OMAP3+: voltage: remove initial voltage Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-06 13:37   ` Sergei Shtylyov
2011-03-06 13:37     ` Sergei Shtylyov
2011-03-07  2:52     ` Nishanth Menon
2011-03-07  2:52       ` Nishanth Menon
2011-03-07 16:23       ` Sergei Shtylyov
2011-03-07 16:23         ` Sergei Shtylyov
2011-03-08  1:52         ` Nishanth Menon
2011-03-08  1:52           ` Nishanth Menon
2011-07-26 13:17           ` Felipe Balbi
2011-07-26 13:17             ` Felipe Balbi
2011-03-17 14:53   ` Kevin Hilman
2011-03-17 14:53     ` Kevin Hilman
2011-03-05 15:29 ` [PATCH V3 04/19] OMAP3+: voltage: remove spurious pr_notice for debugfs Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-17 14:55   ` Kevin Hilman
2011-03-17 14:55     ` Kevin Hilman
2011-07-26 13:18   ` Felipe Balbi
2011-07-26 13:18     ` Felipe Balbi
2011-03-05 15:29 ` [PATCH V3 05/19] OMAP3+: voltage: use IS_ERR_OR_NULL Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-05 17:36   ` David Cohen
2011-03-05 17:36     ` David Cohen
2011-03-06  2:45     ` Nishanth Menon
2011-03-06  2:45       ` Nishanth Menon
2011-03-06  8:18       ` Russell King - ARM Linux
2011-03-06  8:18         ` Russell King - ARM Linux
2011-03-07  2:56         ` Nishanth Menon
2011-03-07  2:56           ` Nishanth Menon
2011-07-26 13:19   ` Felipe Balbi
2011-07-26 13:19     ` Felipe Balbi
2011-03-05 15:29 ` [PATCH V3 06/19] OMAP3+: voltage: use volt_data pointer instead values Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-17 17:09   ` Kevin Hilman
2011-03-17 17:09     ` Kevin Hilman
2011-03-05 15:29 ` [PATCH V3 07/19] OMAP3+: voltage: add transdone APIs Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-17 17:14   ` Kevin Hilman
2011-03-17 17:14     ` Kevin Hilman
2011-03-05 15:29 ` [PATCH V3 08/19] OMAP3+: SR: make notify independent of class Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-17 17:18   ` Kevin Hilman
2011-03-17 17:18     ` Kevin Hilman
2011-03-05 15:29 ` [PATCH V3 09/19] OMAP3+: SR: disable interrupt by default Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-17 17:19   ` Kevin Hilman [this message]
2011-03-17 17:19     ` Kevin Hilman
2011-03-05 15:29 ` [PATCH V3 10/19] OMAP3+: SR: enable/disable SR only on need Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-17 17:20   ` Kevin Hilman
2011-03-17 17:20     ` Kevin Hilman
2011-03-05 15:29 ` [PATCH V3 11/19] OMAP3+: SR: fix cosmetic indentation Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-17 17:21   ` Kevin Hilman
2011-03-17 17:21     ` Kevin Hilman
2011-03-17 17:43     ` Aaro Koskinen
2011-03-17 17:43       ` Aaro Koskinen
2011-03-17 20:02       ` Kevin Hilman
2011-03-17 20:02         ` Kevin Hilman
2011-03-05 15:29 ` [PATCH V3 12/19] OMAP3+: SR: introduce class start,stop and priv data Nishanth Menon
2011-03-05 15:29   ` [PATCH V3 12/19] OMAP3+: SR: introduce class start, stop " Nishanth Menon
2011-03-17 17:23   ` [PATCH V3 12/19] OMAP3+: SR: introduce class start,stop " Kevin Hilman
2011-03-17 17:23     ` [PATCH V3 12/19] OMAP3+: SR: introduce class start, stop " Kevin Hilman
2011-03-05 15:29 ` [PATCH V3 13/19] OMAP3+: SR: Reuse sr_[start|stop]_vddautocomp functions Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-07 14:40   ` Jarkko Nikula
2011-03-07 14:40     ` Jarkko Nikula
2011-03-17 17:25   ` Kevin Hilman
2011-03-17 17:25     ` Kevin Hilman
2011-03-05 15:29 ` [PATCH V3 14/19] OMAP3+: SR: introduce notifiers flags Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-17 17:28   ` Kevin Hilman
2011-03-17 17:28     ` Kevin Hilman
2011-03-05 15:29 ` [PATCH V3 15/19] OMAP3+: SR: introduce notifier_control Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-17 17:35   ` Kevin Hilman
2011-03-17 17:35     ` Kevin Hilman
2011-03-05 15:29 ` [PATCH V3 16/19] OMAP3+: SR: disable spamming interrupts Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-05 15:29 ` [PATCH V3 17/19] OMAP3+: SR: make enable path use volt_data pointer Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-17 17:41   ` Kevin Hilman
2011-03-17 17:41     ` Kevin Hilman
2011-03-05 15:29 ` [PATCH V3 18/19] OMAP3630+: SR: add support for class 1.5 Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-17 19:57   ` Kevin Hilman
2011-03-17 19:57     ` Kevin Hilman
2011-03-05 15:29 ` [PATCH V3 19/19] OMAP3430: SR: class3: restrict CPU to run on Nishanth Menon
2011-03-05 15:29   ` Nishanth Menon
2011-03-17 19:58   ` Kevin Hilman
2011-03-17 19:58     ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hbb18y1o.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.