[PATCH 2/4] da850/omap-l138: Add callback to control LCD panel power

[PATCH 2/4] da850/omap-l138: Add callback to control LCD panel power

[Chaithrika U S]

Add the platform specific callback to control LCD panel and
backlight power.

Signed-off-by: Chaithrika U S <chaithrika-l0cyMroinI0@public.gmane.org>
---
This patch applies to DaVinci GIT tree at
http://git.kernel.org/?p=linux/kernel/git/khilman/linux-davinci.git;a=summary

 arch/arm/mach-davinci/board-da850-evm.c |   24 ++++++++++++++----------
 1 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
index 8e0722f..63a6301 100644
--- a/arch/arm/mach-davinci/board-da850-evm.c
+++ b/arch/arm/mach-davinci/board-da850-evm.c
@@ -351,6 +351,15 @@ static struct davinci_mmc_config da850_mmc_config = {
 	.version	= MMC_CTLR_VERSION_2,
 };
 
+static void da850_panel_power_ctrl(int val)
+{
+	/* lcd backlight */
+	gpio_set_value(DA850_LCD_BL_PIN, val);
+
+	/* lcd power */
+	gpio_set_value(DA850_LCD_PWR_PIN, val);
+}
+
 static int da850_lcd_hw_init(void)
 {
 	int status;
@@ -368,17 +377,11 @@ static int da850_lcd_hw_init(void)
 	gpio_direction_output(DA850_LCD_BL_PIN, 0);
 	gpio_direction_output(DA850_LCD_PWR_PIN, 0);
 
-	/* disable lcd backlight */
-	gpio_set_value(DA850_LCD_BL_PIN, 0);
-
-	/* disable lcd power */
-	gpio_set_value(DA850_LCD_PWR_PIN, 0);
-
-	/* enable lcd power */
-	gpio_set_value(DA850_LCD_PWR_PIN, 1);
+	/* Switch off panel power and backlight */
+	da850_panel_power_ctrl(0);
 
-	/* enable lcd backlight */
-	gpio_set_value(DA850_LCD_BL_PIN, 1);
+	/* Switch on panel power and backlight */
+	da850_panel_power_ctrl(1);
 
 	return 0;
 }
@@ -686,6 +689,7 @@ static __init void da850_evm_init(void)
 		pr_warning("da850_evm_init: lcd initialization failed: %d\n",
 				ret);
 
+	sharp_lk043t1dg01_pdata.panel_power_ctrl = da850_panel_power_ctrl,
 	ret = da8xx_register_lcdc(&sharp_lk043t1dg01_pdata);
 	if (ret)
 		pr_warning("da850_evm_init: lcdc registration failed: %d\n",
-- 
1.5.6

Re: [PATCH 2/4] da850/omap-l138: Add callback to control LCD panel power

[Andrew Morton]

On Tue, 08 Dec 2009 09:53:46 -0800
Kevin Hilman <khilman@deeprootsystems.com> wrote:

> Chaithrika U S <chaithrika@ti.com> writes:
> 
> > Add the platform specific callback to control LCD panel and
> > backlight power.
> >
> > Signed-off-by: Chaithrika U S <chaithrika@ti.com>
> > ---
> > This patch applies to DaVinci GIT tree at
> > http://git.kernel.org/?p=linux/kernel/git/khilman/linux-davinci.git;a=summary
> 
> Andrew,
> 
> I see you have pulled this series into -mm.  Thanks.  The
> drivers/video/* changes in patches 1,3 and 4 should go upstream
> through you, but I'd like to request that you drop this patch (PATCH
> 2/4) from your queue, and I will queue it in davinci-next.

I autodrop patches when they turn up in linux-next.  So if you want to
merge something then please just merge away, then I'll drop my copy.

This way patches don't get lost, and I get to check whether the patch
which was in linux-next matches the version I had, and whether the patch
which was merged into linux-next is missing any followup patches which
I had accumulated against the original.


------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev

Re: [PATCH 2/4] da850/omap-l138: Add callback to control LCD panel power

[Kevin Hilman]

Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> writes:

> On Tue, 08 Dec 2009 09:53:46 -0800
> Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org> wrote:
>
>> Chaithrika U S <chaithrika-l0cyMroinI0@public.gmane.org> writes:
>> 
>> > Add the platform specific callback to control LCD panel and
>> > backlight power.
>> >
>> > Signed-off-by: Chaithrika U S <chaithrika-l0cyMroinI0@public.gmane.org>
>> > ---
>> > This patch applies to DaVinci GIT tree at
>> > http://git.kernel.org/?p=linux/kernel/git/khilman/linux-davinci.git;a=summary
>> 
>> Andrew,
>> 
>> I see you have pulled this series into -mm.  Thanks.  The
>> drivers/video/* changes in patches 1,3 and 4 should go upstream
>> through you, but I'd like to request that you drop this patch (PATCH
>> 2/4) from your queue, and I will queue it in davinci-next.
>
> I autodrop patches when they turn up in linux-next.  So if you want to
> merge something then please just merge away, then I'll drop my copy.

OK.

> This way patches don't get lost, and I get to check whether the patch
> which was in linux-next matches the version I had, and whether the patch
> which was merged into linux-next is missing any followup patches which
> I had accumulated against the original.

Sounds good.  Thanks for the explanation.

Kevin