From: Michael Ellerman <mpe@ellerman.id.au>
To: Jani Nikula <jani.nikula@intel.com>, linuxppc-dev@lists.ozlabs.org
Cc: dri-devel@lists.freedesktop.org, lkft-triage@lists.linaro.org,
linux-kernel@vger.kernel.org,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Helge Deller <deller@gmx.de>,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h
Date: Tue, 05 Mar 2024 11:39:18 +1100 [thread overview]
Message-ID: <87cys9pl55.fsf@mail.lhotse> (raw)
In-Reply-To: <87bk7u5n9h.fsf@intel.com>
Jani Nikula <jani.nikula@intel.com> writes:
> On Mon, 04 Mar 2024, Jani Nikula <jani.nikula@intel.com> wrote:
>> Removal of the backlight include from fb.h uncovered an implicit
>> dependency in powerpc asm/backlight.h. Add the explicit include.
>>
>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>> Closes: https://lore.kernel.org/r/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com
>> Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header")
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Helge Deller <deller@gmx.de>
>> Cc: linux-fbdev@vger.kernel.org
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> ---
>>
>> Not even compile tested!
>
> Naresh, please try this patch!
>
> Michael, if this is fine by you, ack to merge via the drm subsystem
> along with the regressing commit?
I prefer Thomas' patch, but I'm fine with either to go in via drm.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jani Nikula <jani.nikula@intel.com>, linuxppc-dev@lists.ozlabs.org
Cc: linux-fbdev@vger.kernel.org,
Naresh Kamboju <naresh.kamboju@linaro.org>,
linux-kernel@vger.kernel.org, lkft-triage@lists.linaro.org,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Helge Deller <deller@gmx.de>
Subject: Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h
Date: Tue, 05 Mar 2024 11:39:18 +1100 [thread overview]
Message-ID: <87cys9pl55.fsf@mail.lhotse> (raw)
In-Reply-To: <87bk7u5n9h.fsf@intel.com>
Jani Nikula <jani.nikula@intel.com> writes:
> On Mon, 04 Mar 2024, Jani Nikula <jani.nikula@intel.com> wrote:
>> Removal of the backlight include from fb.h uncovered an implicit
>> dependency in powerpc asm/backlight.h. Add the explicit include.
>>
>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>> Closes: https://lore.kernel.org/r/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com
>> Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header")
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Helge Deller <deller@gmx.de>
>> Cc: linux-fbdev@vger.kernel.org
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> ---
>>
>> Not even compile tested!
>
> Naresh, please try this patch!
>
> Michael, if this is fine by you, ack to merge via the drm subsystem
> along with the regressing commit?
I prefer Thomas' patch, but I'm fine with either to go in via drm.
cheers
next prev parent reply other threads:[~2024-03-05 0:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 8:20 fbdev/chipsfb.c:401:31: error: invalid use of undefined type 'struct backlight_device' Naresh Kamboju
2024-03-04 9:55 ` [PATCH] powerpc: include linux/backlight.h from asm/backlight.h Jani Nikula
2024-03-04 9:55 ` Jani Nikula
2024-03-04 10:01 ` Jani Nikula
2024-03-04 10:01 ` Jani Nikula
2024-03-04 14:55 ` Naresh Kamboju
2024-03-04 14:55 ` Naresh Kamboju
2024-03-05 0:39 ` Michael Ellerman [this message]
2024-03-05 0:39 ` Michael Ellerman
2024-03-05 8:19 ` Jani Nikula
2024-03-05 8:19 ` Jani Nikula
2024-03-04 10:32 ` Thomas Zimmermann
2024-03-04 10:32 ` Thomas Zimmermann
2024-03-04 10:40 ` Thomas Zimmermann
2024-03-04 10:40 ` Thomas Zimmermann
2024-03-04 18:13 ` Christophe Leroy
2024-03-04 18:13 ` Christophe Leroy
2024-03-05 0:36 ` Michael Ellerman
2024-03-05 0:36 ` Michael Ellerman
2024-03-05 8:09 ` Thomas Zimmermann
2024-03-05 8:09 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cys9pl55.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkft-triage@lists.linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.