All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 09/10] ARM: dts: stm32: add STM32MP1-based Phytec SoM
Date: Tue, 11 Apr 2023 08:42:50 +0200	[thread overview]
Message-ID: <87cz4a5368.fsf@pengutronix.de> (raw)
In-Reply-To: <dda2a928-dbdd-e8e7-fb5e-2bb062a3b2b9@foss.st.com>


Hi Alexandre,

Alexandre TORGUE <alexandre.torgue@foss.st.com> writes:
>> +		gpu_reserved: gpu@f8000000 {
>> +			reg = <0xf8000000 0x8000000>;
>> +			no-map;
>> +		};
>
> It seems that this region is not used. Furthermore if you plan to use it to GPU
> note that it doesn't respect YAMl verification. So please remove it.
>

Ack. Will remove.

>> +&ethernet0 {
>> +	pinctrl-0 = <&ethernet0_rgmii_pins_d>;
>> +	pinctrl-1 = <&ethernet0_rgmii_sleep_pins_d>;
>> +	pinctrl-names = "default", "sleep";
>> +	phy-mode = "rgmii-id";
>> +	max-speed = <1000>;
>> +	phy-handle = <&phy0>;
>> +	st,eth-clk-sel;
>> +	clock-names = "stmmaceth",
>> +		      "mac-clk-tx",
>> +		      "mac-clk-rx",
>> +		      "eth-ck",
>> +		      "syscfg-clk",
>> +		      "ethstp";
>> +	clocks = <&rcc ETHMAC>,
>> +		 <&rcc ETHTX>,
>> +		 <&rcc ETHRX>,
>> +		 <&rcc ETHCK_K>,
>> +		 <&rcc SYSCFG>,
>> +		 <&rcc ETHSTP>;
>
> Why do you re define those clocks ? They are all already defined in
> stm32mp151.dtsi
>

Just an oversight :( Will remove.


Thanks,
Steffen

--
Pengutronix e.K.                | Dipl.-Inform. Steffen Trumtrar |
Steuerwalder Str. 21            | https://www.pengutronix.de/    |
31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 09/10] ARM: dts: stm32: add STM32MP1-based Phytec SoM
Date: Tue, 11 Apr 2023 08:42:50 +0200	[thread overview]
Message-ID: <87cz4a5368.fsf@pengutronix.de> (raw)
In-Reply-To: <dda2a928-dbdd-e8e7-fb5e-2bb062a3b2b9@foss.st.com>


Hi Alexandre,

Alexandre TORGUE <alexandre.torgue@foss.st.com> writes:
>> +		gpu_reserved: gpu@f8000000 {
>> +			reg = <0xf8000000 0x8000000>;
>> +			no-map;
>> +		};
>
> It seems that this region is not used. Furthermore if you plan to use it to GPU
> note that it doesn't respect YAMl verification. So please remove it.
>

Ack. Will remove.

>> +&ethernet0 {
>> +	pinctrl-0 = <&ethernet0_rgmii_pins_d>;
>> +	pinctrl-1 = <&ethernet0_rgmii_sleep_pins_d>;
>> +	pinctrl-names = "default", "sleep";
>> +	phy-mode = "rgmii-id";
>> +	max-speed = <1000>;
>> +	phy-handle = <&phy0>;
>> +	st,eth-clk-sel;
>> +	clock-names = "stmmaceth",
>> +		      "mac-clk-tx",
>> +		      "mac-clk-rx",
>> +		      "eth-ck",
>> +		      "syscfg-clk",
>> +		      "ethstp";
>> +	clocks = <&rcc ETHMAC>,
>> +		 <&rcc ETHTX>,
>> +		 <&rcc ETHRX>,
>> +		 <&rcc ETHCK_K>,
>> +		 <&rcc SYSCFG>,
>> +		 <&rcc ETHSTP>;
>
> Why do you re define those clocks ? They are all already defined in
> stm32mp151.dtsi
>

Just an oversight :( Will remove.


Thanks,
Steffen

--
Pengutronix e.K.                | Dipl.-Inform. Steffen Trumtrar |
Steuerwalder Str. 21            | https://www.pengutronix.de/    |
31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |

  reply	other threads:[~2023-04-11  6:44 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30  5:03 [PATCH v7 00/10] ARM: stm32: add support for Phycore STM32MP1 Steffen Trumtrar
2023-03-30  5:03 ` Steffen Trumtrar
2023-03-30  5:03 ` [PATCH v7 01/10] ARM: dts: stm32: Add alternate pinmux for ethernet Steffen Trumtrar
2023-03-30  5:03   ` Steffen Trumtrar
2023-03-30  5:04 ` [PATCH v7 02/10] ARM: dts: stm32: Add alternate pinmux for sai2b Steffen Trumtrar
2023-03-30  5:04   ` Steffen Trumtrar
2023-03-30  5:04 ` [PATCH v7 03/10] ARM: dts: stm32: Add new pinmux for sdmmc1_b4 Steffen Trumtrar
2023-03-30  5:04   ` Steffen Trumtrar
2023-03-30  5:04 ` [PATCH v7 04/10] ARM: dts: stm32: Add new pinmux for sdmmc2_d47 Steffen Trumtrar
2023-03-30  5:04   ` Steffen Trumtrar
2023-03-30  5:04 ` [PATCH v7 05/10] ARM: dts: stm32: Add pinmux for USART1 pins Steffen Trumtrar
2023-03-30  5:04   ` Steffen Trumtrar
2023-03-30  5:04 ` [PATCH v7 06/10] ARM: dts: stm32: Add idle/sleep pinmux for USART3 Steffen Trumtrar
2023-03-30  5:04   ` Steffen Trumtrar
2023-03-30  5:04 ` [PATCH v7 07/10] ARM: dts: stm32: Add sleep pinmux for SPI1 pins_a Steffen Trumtrar
2023-03-30  5:04   ` Steffen Trumtrar
2023-03-30  5:04 ` [PATCH v7 08/10] dt-bindings: arm: stm32: Add Phytec STM32MP1 board Steffen Trumtrar
2023-03-30  5:04   ` Steffen Trumtrar
2023-03-30  5:04 ` [PATCH v7 09/10] ARM: dts: stm32: add STM32MP1-based Phytec SoM Steffen Trumtrar
2023-03-30  5:04   ` Steffen Trumtrar
2023-04-03  9:10   ` Alexandre TORGUE
2023-04-03  9:10     ` Alexandre TORGUE
2023-04-11  6:42     ` Steffen Trumtrar [this message]
2023-04-11  6:42       ` Steffen Trumtrar
2023-03-30  5:04 ` [PATCH v7 10/10] ARM: dts: stm32: add STM32MP1-based Phytec board Steffen Trumtrar
2023-03-30  5:04   ` Steffen Trumtrar
2023-04-03  9:15   ` Alexandre TORGUE
2023-04-03  9:15     ` Alexandre TORGUE
2023-04-03  9:28     ` [Linux-stm32] " Ahmad Fatoum
2023-04-03  9:28       ` Ahmad Fatoum
2023-04-03  9:45       ` Alexandre TORGUE
2023-04-03  9:45         ` Alexandre TORGUE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz4a5368.fsf@pengutronix.de \
    --to=s.trumtrar@pengutronix.de \
    --cc=alexandre.torgue@foss.st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.