All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Govind Singh <govinds@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH 4/4] ath11k: Register mhi controller device for qca6390
Date: Mon, 11 May 2020 21:03:56 +0300	[thread overview]
Message-ID: <87d07a4acz.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200508085850.23363-5-govinds@codeaurora.org> (Govind Singh's message of "Fri, 8 May 2020 14:28:50 +0530")

+ mani

Govind Singh <govinds@codeaurora.org> writes:

> MHI is a communication protocol to communicate with external
> Qualcomm modems and Wi-Fi chipsets over high speed peripheral buses. Even
> though MHI doesn’t dictate underlying physical layer, protocol and mhi stack
> is structured for PCIe based devices.
>
> Register directly with mhi core layer as a mhi device driver for
> firmware download.
>
> Tested QCA6390 on X86 platform.
> Tested firmware WLAN.HST.1.0.1.c1-00440-QCAHSTSWPLZ_V2_TO_X86-1.
>
> Signed-off-by: Govind Singh <govinds@codeaurora.org>

[...]

> --- a/drivers/net/wireless/ath/ath11k/Kconfig
> +++ b/drivers/net/wireless/ath/ath11k/Kconfig
> @@ -2,7 +2,6 @@
>  config ATH11K
>  	tristate "Qualcomm Technologies 802.11ax chipset support"
>  	depends on MAC80211 && HAS_DMA
> -	depends on REMOTEPROC
>  	depends on CRYPTO_MICHAEL_MIC
>  	depends on ARCH_QCOM || COMPILE_TEST
>  	select ATH_COMMON
> @@ -15,13 +14,13 @@ config ATH11K
>  
>  config ATH11K_AHB
>  	tristate "Qualcomm Technologies 802.11ax chipset AHB support"
> -	depends on ATH11K
> +	depends on ATH11K && REMOTEPROC
>  	---help---
>  	  This module adds support for AHB bus
>  
>  config ATH11K_PCI
>  	tristate "Qualcomm Technologies 802.11ax chipset PCI support"
> -	depends on ATH11K && PCI
> +	depends on ATH11K && PCI && MHI_BUS
>  	---help---
>  	  This module adds support for PCIE bus

Currently ATH11K_PCI is not visible if MHI_BUS is disabled, which I'm
worried will confuse the users. I wonder if we should use 'select
MHI_BUS' instead? That way ATH11K_PCI would be visible even if MHI_BUS
is disabled.

And what about QRTR_MHI? Mani, any suggestions?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Govind Singh <govinds@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH 4/4] ath11k: Register mhi controller device for qca6390
Date: Mon, 11 May 2020 21:03:56 +0300	[thread overview]
Message-ID: <87d07a4acz.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200508085850.23363-5-govinds@codeaurora.org> (Govind Singh's message of "Fri, 8 May 2020 14:28:50 +0530")

+ mani

Govind Singh <govinds@codeaurora.org> writes:

> MHI is a communication protocol to communicate with external
> Qualcomm modems and Wi-Fi chipsets over high speed peripheral buses. Even
> though MHI doesn’t dictate underlying physical layer, protocol and mhi stack
> is structured for PCIe based devices.
>
> Register directly with mhi core layer as a mhi device driver for
> firmware download.
>
> Tested QCA6390 on X86 platform.
> Tested firmware WLAN.HST.1.0.1.c1-00440-QCAHSTSWPLZ_V2_TO_X86-1.
>
> Signed-off-by: Govind Singh <govinds@codeaurora.org>

[...]

> --- a/drivers/net/wireless/ath/ath11k/Kconfig
> +++ b/drivers/net/wireless/ath/ath11k/Kconfig
> @@ -2,7 +2,6 @@
>  config ATH11K
>  	tristate "Qualcomm Technologies 802.11ax chipset support"
>  	depends on MAC80211 && HAS_DMA
> -	depends on REMOTEPROC
>  	depends on CRYPTO_MICHAEL_MIC
>  	depends on ARCH_QCOM || COMPILE_TEST
>  	select ATH_COMMON
> @@ -15,13 +14,13 @@ config ATH11K
>  
>  config ATH11K_AHB
>  	tristate "Qualcomm Technologies 802.11ax chipset AHB support"
> -	depends on ATH11K
> +	depends on ATH11K && REMOTEPROC
>  	---help---
>  	  This module adds support for AHB bus
>  
>  config ATH11K_PCI
>  	tristate "Qualcomm Technologies 802.11ax chipset PCI support"
> -	depends on ATH11K && PCI
> +	depends on ATH11K && PCI && MHI_BUS
>  	---help---
>  	  This module adds support for PCIE bus

Currently ATH11K_PCI is not visible if MHI_BUS is disabled, which I'm
worried will confuse the users. I wonder if we should use 'select
MHI_BUS' instead? That way ATH11K_PCI would be visible even if MHI_BUS
is disabled.

And what about QRTR_MHI? Mani, any suggestions?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2020-05-11 18:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08  8:58 [PATCH 0/4] Add PCI client driver for QCA6390 chipset Govind Singh
2020-05-08  8:58 ` Govind Singh
2020-05-08  8:58 ` [PATCH 1/4] ath11k: " Govind Singh
2020-05-08  8:58   ` Govind Singh
2020-05-11 17:59   ` Kalle Valo
2020-05-11 17:59     ` Kalle Valo
2020-05-12  5:31     ` govinds
2020-05-12  5:31       ` govinds
2020-05-08  8:58 ` [PATCH 2/4] ath11k: setup pci resource for QCA6390 target Govind Singh
2020-05-08  8:58   ` Govind Singh
2020-05-08  8:58 ` [PATCH 3/4] ath11k: Add msi config init for QCA6390 Govind Singh
2020-05-08  8:58   ` Govind Singh
2020-05-08  8:58 ` [PATCH 4/4] ath11k: Register mhi controller device for qca6390 Govind Singh
2020-05-08  8:58   ` Govind Singh
2020-05-11 18:03   ` Kalle Valo [this message]
2020-05-11 18:03     ` Kalle Valo
2020-05-12  7:13     ` Manivannan Sadhasivam
2020-05-12  7:13       ` Manivannan Sadhasivam
2020-05-12  8:19       ` Kalle Valo
2020-05-12  8:19         ` Kalle Valo
2020-05-12  8:24         ` Kalle Valo
2020-05-12  8:24           ` Kalle Valo
2020-05-12  9:00         ` Manivannan Sadhasivam
2020-05-12  9:00           ` Manivannan Sadhasivam
2020-05-11 18:08   ` Kalle Valo
2020-05-11 18:08     ` Kalle Valo
2020-05-15  3:28   ` Carl Huang
2020-05-15  3:28     ` Carl Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d07a4acz.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=govinds@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.