All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2] ath10k: add fw coredump for sdio when firmware assert
Date: Sat, 21 Sep 2019 14:26:54 +0300	[thread overview]
Message-ID: <87d0ftc2kh.fsf@codeaurora.org> (raw)
In-Reply-To: <1567132338-7407-1-git-send-email-wgong@codeaurora.org> (Wen Gong's message of "Fri, 30 Aug 2019 10:32:18 +0800")

Wen Gong <wgong@codeaurora.org> writes:

> When firmware assert, it need coredump to analyze, this patch will
> collect the register and memory info for sdio chip.
>
> The coredump configuration is different between PCIE and SDIO for
> the same reversion, so this patch add bus type to distinguish PCIE
> and SDIO chip for coredump.
>
> Tested with QCA6174 SDIO with firmware
> WLAN.RMH.4.4.1-00007-QCARMSWP-1.
>
> Signed-off-by: Wen Gong <wgong@codeaurora.org>

I think this patch should be split into two, the first patch preparing
coredump layouts to support different bus types and the second patch
adding coredump support for SDIO.

> --- a/drivers/net/wireless/ath/ath10k/hw.h
> +++ b/drivers/net/wireless/ath/ath10k/hw.h
> @@ -11,6 +11,7 @@
>  #include "targaddrs.h"
>  
>  enum ath10k_bus {
> +	ATH10K_BUS_ANY,
>  	ATH10K_BUS_PCI,
>  	ATH10K_BUS_AHB,
>  	ATH10K_BUS_SDIO,

I don't think we need add this type ANY. From a quick look QCA4019 is
AHB and all the rest are PCI, right? So in the first patch you only need
to add correct bus type for each entry and everything should work as
before.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: add fw coredump for sdio when firmware assert
Date: Sat, 21 Sep 2019 14:26:54 +0300	[thread overview]
Message-ID: <87d0ftc2kh.fsf@codeaurora.org> (raw)
In-Reply-To: <1567132338-7407-1-git-send-email-wgong@codeaurora.org> (Wen Gong's message of "Fri, 30 Aug 2019 10:32:18 +0800")

Wen Gong <wgong@codeaurora.org> writes:

> When firmware assert, it need coredump to analyze, this patch will
> collect the register and memory info for sdio chip.
>
> The coredump configuration is different between PCIE and SDIO for
> the same reversion, so this patch add bus type to distinguish PCIE
> and SDIO chip for coredump.
>
> Tested with QCA6174 SDIO with firmware
> WLAN.RMH.4.4.1-00007-QCARMSWP-1.
>
> Signed-off-by: Wen Gong <wgong@codeaurora.org>

I think this patch should be split into two, the first patch preparing
coredump layouts to support different bus types and the second patch
adding coredump support for SDIO.

> --- a/drivers/net/wireless/ath/ath10k/hw.h
> +++ b/drivers/net/wireless/ath/ath10k/hw.h
> @@ -11,6 +11,7 @@
>  #include "targaddrs.h"
>  
>  enum ath10k_bus {
> +	ATH10K_BUS_ANY,
>  	ATH10K_BUS_PCI,
>  	ATH10K_BUS_AHB,
>  	ATH10K_BUS_SDIO,

I don't think we need add this type ANY. From a quick look QCA4019 is
AHB and all the rest are PCI, right? So in the first patch you only need
to add correct bus type for each entry and everything should work as
before.

-- 
Kalle Valo

  reply	other threads:[~2019-09-21 11:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30  2:32 [PATCH v2] ath10k: add fw coredump for sdio when firmware assert Wen Gong
2019-08-30  2:32 ` Wen Gong
2019-09-21 11:26 ` Kalle Valo [this message]
2019-09-21 11:26   ` Kalle Valo
2019-09-21 11:35 ` Kalle Valo
2019-09-21 11:35   ` Kalle Valo
2019-09-23 11:07   ` Wen Gong
2019-09-23 11:07     ` Wen Gong
2019-09-24  3:38     ` Wen Gong
2019-09-24  3:38       ` Wen Gong
2019-09-21 11:38 ` Kalle Valo
2019-09-21 11:38   ` Kalle Valo
2019-09-23 11:09   ` Wen Gong
2019-09-23 11:09     ` Wen Gong
2019-09-23 11:37     ` Kalle Valo
2019-09-23 11:37       ` Kalle Valo
2019-09-23 12:12       ` Wen Gong
2019-09-23 12:12         ` Wen Gong
2019-09-21 11:49 ` Kalle Valo
2019-09-21 11:49   ` Kalle Valo
2019-09-23 11:10   ` Wen Gong
2019-09-23 11:10     ` Wen Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0ftc2kh.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wgong@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.