From: Jani Nikula <jani.nikula@linux.intel.com>
To: DRI Development <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 5/6] backlight: Also nuke BL_CORE_DRIVER1
Date: Mon, 30 Apr 2018 13:24:16 +0300 [thread overview]
Message-ID: <87d0yh9elr.fsf@intel.com> (raw)
In-Reply-To: <20180425174253.4616-5-daniel.vetter@ffwll.ch>
On Wed, 25 Apr 2018, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Now that the 3 drivers using this are cleaned up we can also remove
> this final bit of confusion of leaking driver internals into the
> backlight power interface.
>
> The backlight power interface itself is still a massive mess.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> include/linux/backlight.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/backlight.h b/include/linux/backlight.h
> index 1db67662bfcb..7fbf0539e14a 100644
> --- a/include/linux/backlight.h
> +++ b/include/linux/backlight.h
> @@ -84,7 +84,6 @@ struct backlight_properties {
>
> #define BL_CORE_SUSPENDED (1 << 0) /* backlight is suspended */
> #define BL_CORE_FBBLANK (1 << 1) /* backlight is under an fb blank event */
> -#define BL_CORE_DRIVER1 (1 << 31) /* reserved for driver specific use */
Please also remove the
/* Upper 4 bits are reserved for driver internal use */
comment a few lines up to not give anyone ideas.
With that,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> };
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Daniel Thompson <daniel.thompson@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>
Subject: Re: [PATCH 5/6] backlight: Also nuke BL_CORE_DRIVER1
Date: Mon, 30 Apr 2018 13:24:16 +0300 [thread overview]
Message-ID: <87d0yh9elr.fsf@intel.com> (raw)
In-Reply-To: <20180425174253.4616-5-daniel.vetter@ffwll.ch>
On Wed, 25 Apr 2018, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Now that the 3 drivers using this are cleaned up we can also remove
> this final bit of confusion of leaking driver internals into the
> backlight power interface.
>
> The backlight power interface itself is still a massive mess.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> include/linux/backlight.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/backlight.h b/include/linux/backlight.h
> index 1db67662bfcb..7fbf0539e14a 100644
> --- a/include/linux/backlight.h
> +++ b/include/linux/backlight.h
> @@ -84,7 +84,6 @@ struct backlight_properties {
>
> #define BL_CORE_SUSPENDED (1 << 0) /* backlight is suspended */
> #define BL_CORE_FBBLANK (1 << 1) /* backlight is under an fb blank event */
> -#define BL_CORE_DRIVER1 (1 << 31) /* reserved for driver specific use */
Please also remove the
/* Upper 4 bits are reserved for driver internal use */
comment a few lines up to not give anyone ideas.
With that,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> };
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2018-04-30 10:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 17:42 [PATCH 1/6] backlight: Nuke unused backlight.props.state states Daniel Vetter
2018-04-25 17:42 ` Daniel Vetter
2018-04-25 17:42 ` [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state Daniel Vetter
2018-04-25 17:42 ` Daniel Vetter
2018-04-30 10:21 ` Jani Nikula
2018-04-30 10:21 ` Jani Nikula
2018-04-25 17:42 ` [PATCH 3/6] backlight/pandora: Stop using BL_CORE_DRIVER1 Daniel Vetter
2018-04-25 17:42 ` Daniel Vetter
2018-04-30 10:22 ` Jani Nikula
2018-04-30 10:22 ` Jani Nikula
2018-04-25 17:42 ` [PATCH 4/6] staging/fbtft: " Daniel Vetter
2018-04-25 17:42 ` Daniel Vetter
2018-04-30 9:54 ` Lee Jones
2018-04-30 9:54 ` Lee Jones
2018-04-30 10:59 ` Greg KH
2018-04-30 10:59 ` Greg KH
2018-04-30 10:22 ` Jani Nikula
2018-04-30 10:22 ` Jani Nikula
2018-04-25 17:42 ` [PATCH 5/6] backlight: Also nuke BL_CORE_DRIVER1 Daniel Vetter
2018-04-25 17:42 ` Daniel Vetter
2018-04-30 10:24 ` Jani Nikula [this message]
2018-04-30 10:24 ` Jani Nikula
2018-04-30 12:14 ` Lee Jones
2018-04-30 12:14 ` Lee Jones
2018-04-25 17:42 ` [PATCH 6/6] MAINTAINERS: add dri-devel for backlight subsystem patches Daniel Vetter
2018-04-25 19:43 ` Jingoo Han
2018-04-25 19:43 ` Jingoo Han
2018-04-25 19:42 ` [PATCH 1/6] backlight: Nuke unused backlight.props.state states Jingoo Han
2018-04-25 19:42 ` Jingoo Han
2018-04-30 10:21 ` Jani Nikula
2018-04-30 10:21 ` Jani Nikula
2018-04-30 12:27 ` Lee Jones
2018-04-30 12:27 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2018-01-17 14:01 Daniel Vetter
2018-01-17 14:01 ` [PATCH 5/6] backlight: Also nuke BL_CORE_DRIVER1 Daniel Vetter
2018-01-17 14:01 ` Daniel Vetter
2018-01-17 16:51 ` Daniel Thompson
2018-01-17 16:51 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0yh9elr.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.thompson@linaro.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.