[drm-intel:topic/drm-misc 3/3] htmldocs: include/drm/drm_fb_helper.h:222: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS:

[drm-intel:topic/drm-misc 3/3] htmldocs: include/drm/drm_fb_helper.h:222: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS:

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1544 bytes --]

tree:   git://anongit.freedesktop.org/drm-intel topic/drm-misc
head:   6c4d6f9f997c5dafccb54b52167f0c4d0ea37874
commit: 6c4d6f9f997c5dafccb54b52167f0c4d0ea37874 [3/3] drm/fb-helper: add DRM_FB_HELPER_DEFAULT_OPS for fb_ops
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

>> include/drm/drm_fb_helper.h:222: warning: Cannot understand  * @DRM_FB_HELPER_DEFAULT_OPS:
    on line 222 - I thought it was a doc line

vim +222 include/drm/drm_fb_helper.h

   206		 * Entry on the global kernel_fb_helper_list, used for kgdb entry/exit.
   207		 */
   208		struct list_head kernel_fb_list;
   209	
   210		/**
   211		 * @delayed_hotplug:
   212		 *
   213		 * A hotplug was received while fbdev wasn't in control of the DRM
   214		 * device, i.e. another KMS master was active. The output configuration
   215		 * needs to be reprobe when fbdev is in control again.
   216		 */
   217		bool delayed_hotplug;
   218	};
   219	
   220	/**
   221	 * @DRM_FB_HELPER_DEFAULT_OPS:
 > 222	 *
   223	 * Helper define to register default implementations of drm_fb_helper
   224	 * functions. To be used in struct fb_ops of drm drivers.
   225	 */
   226	#define DRM_FB_HELPER_DEFAULT_OPS \
   227		.fb_check_var	= drm_fb_helper_check_var, \
   228		.fb_set_par	= drm_fb_helper_set_par, \
   229		.fb_setcmap	= drm_fb_helper_setcmap, \
   230		.fb_blank	= drm_fb_helper_blank, \

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6406 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [drm-intel:topic/drm-misc 3/3] htmldocs: include/drm/drm_fb_helper.h:222: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS:

[Jani Nikula]

On Fri, 30 Sep 2016, kbuild test robot <fengguang.wu@intel.com> wrote:
> tree:   git://anongit.freedesktop.org/drm-intel topic/drm-misc
> head:   6c4d6f9f997c5dafccb54b52167f0c4d0ea37874
> commit: 6c4d6f9f997c5dafccb54b52167f0c4d0ea37874 [3/3] drm/fb-helper: add DRM_FB_HELPER_DEFAULT_OPS for fb_ops
> reproduce: make htmldocs
>
> All warnings (new ones prefixed by >>):
>
>>> include/drm/drm_fb_helper.h:222: warning: Cannot understand  * @DRM_FB_HELPER_DEFAULT_OPS:
>     on line 222 - I thought it was a doc line
>
> vim +222 include/drm/drm_fb_helper.h
>
>    206		 * Entry on the global kernel_fb_helper_list, used for kgdb entry/exit.
>    207		 */
>    208		struct list_head kernel_fb_list;
>    209	
>    210		/**
>    211		 * @delayed_hotplug:
>    212		 *
>    213		 * A hotplug was received while fbdev wasn't in control of the DRM
>    214		 * device, i.e. another KMS master was active. The output configuration
>    215		 * needs to be reprobe when fbdev is in control again.
>    216		 */
>    217		bool delayed_hotplug;
>    218	};
>    219	
>    220	/**
>    221	 * @DRM_FB_HELPER_DEFAULT_OPS:

Superfluous @.

BR,
Jani.

>  > 222	 *
>    223	 * Helper define to register default implementations of drm_fb_helper
>    224	 * functions. To be used in struct fb_ops of drm drivers.
>    225	 */
>    226	#define DRM_FB_HELPER_DEFAULT_OPS \
>    227		.fb_check_var	= drm_fb_helper_check_var, \
>    228		.fb_set_par	= drm_fb_helper_set_par, \
>    229		.fb_setcmap	= drm_fb_helper_setcmap, \
>    230		.fb_blank	= drm_fb_helper_blank, \
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [drm-intel:topic/drm-misc 3/3] htmldocs: include/drm/drm_fb_helper.h:222: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS:

[Daniel Vetter]

On Mon, Oct 3, 2016 at 11:35 AM, Jani Nikula
<jani.nikula@linux.intel.com> wrote:
>>    220        /**
>>    221         * @DRM_FB_HELPER_DEFAULT_OPS:
>
> Superfluous @.

Stefan, pls fix this and run

$ make htmldocs

to make sure the output looks correct. Cargo-culting kerneldoc without
checking the output doesn't work too well ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2] drm/fb-helper: add DRM_FB_HELPER_DEFAULT_OPS for fb_ops

[Stefan Christ]

The define DRM_FB_HELPER_DEFAULT_OPS provides the drm_fb_helper default
implementations for functions in struct fb_ops. A drm driver can use it
like:

    static struct fb_ops drm_fbdev_cma_ops = {
        .owner          = THIS_MODULE,
        DRM_FB_HELPER_DEFAULT_OPS,
        /* driver specific implementations */
    };

Suggested-by: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Stefan Christ <contact@stefanchrist.eu>
---
v2: Fix sphinx error:
     warning: Cannot understand  * @DRM_FB_HELPER_DEFAULT_OPS:
---
 include/drm/drm_fb_helper.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index db8d478..f7d7126 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -214,6 +214,19 @@ struct drm_fb_helper {
 	bool delayed_hotplug;
 };
 
+/**
+ * define DRM_FB_HELPER_DEFAULT_OPS - helper define for drm drivers
+ *
+ * Helper define to register default implementations of drm_fb_helper
+ * functions. To be used in struct fb_ops of drm drivers.
+ */
+#define DRM_FB_HELPER_DEFAULT_OPS \
+	.fb_check_var	= drm_fb_helper_check_var, \
+	.fb_set_par	= drm_fb_helper_set_par, \
+	.fb_setcmap	= drm_fb_helper_setcmap, \
+	.fb_blank	= drm_fb_helper_blank, \
+	.fb_pan_display	= drm_fb_helper_pan_display
+
 #ifdef CONFIG_DRM_FBDEV_EMULATION
 int drm_fb_helper_modinit(void);
 void drm_fb_helper_prepare(struct drm_device *dev, struct drm_fb_helper *helper,
-- 
2.1.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/fb-helper: add DRM_FB_HELPER_DEFAULT_OPS for fb_ops

[Gustavo Padovan]

Hi Stefan,

2016-10-04 Stefan Christ <contact@stefanchrist.eu>:

> The define DRM_FB_HELPER_DEFAULT_OPS provides the drm_fb_helper default
> implementations for functions in struct fb_ops. A drm driver can use it
> like:
> 
>     static struct fb_ops drm_fbdev_cma_ops = {
>         .owner          = THIS_MODULE,
>         DRM_FB_HELPER_DEFAULT_OPS,
>         /* driver specific implementations */
>     };
> 
> Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Stefan Christ <contact@stefanchrist.eu>
> ---
> v2: Fix sphinx error:
>      warning: Cannot understand  * @DRM_FB_HELPER_DEFAULT_OPS:
> ---
>  include/drm/drm_fb_helper.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index db8d478..f7d7126 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -214,6 +214,19 @@ struct drm_fb_helper {
>  	bool delayed_hotplug;
>  };
>  
> +/**
> + * define DRM_FB_HELPER_DEFAULT_OPS - helper define for drm drivers

If I'm not mistaken v1 of this patch is already in drm-misc so you may
want to send a patch that fix just the line above.

Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/fb-helper: add DRM_FB_HELPER_DEFAULT_OPS for fb_ops

[Daniel Vetter]

On Wed, Oct 05, 2016 at 11:00:03AM +0200, Gustavo Padovan wrote:
> Hi Stefan,
> 
> 2016-10-04 Stefan Christ <contact@stefanchrist.eu>:
> 
> > The define DRM_FB_HELPER_DEFAULT_OPS provides the drm_fb_helper default
> > implementations for functions in struct fb_ops. A drm driver can use it
> > like:
> > 
> >     static struct fb_ops drm_fbdev_cma_ops = {
> >         .owner          = THIS_MODULE,
> >         DRM_FB_HELPER_DEFAULT_OPS,
> >         /* driver specific implementations */
> >     };
> > 
> > Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> > Signed-off-by: Stefan Christ <contact@stefanchrist.eu>
> > ---
> > v2: Fix sphinx error:
> >      warning: Cannot understand  * @DRM_FB_HELPER_DEFAULT_OPS:
> > ---
> >  include/drm/drm_fb_helper.h | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> > index db8d478..f7d7126 100644
> > --- a/include/drm/drm_fb_helper.h
> > +++ b/include/drm/drm_fb_helper.h
> > @@ -214,6 +214,19 @@ struct drm_fb_helper {
> >  	bool delayed_hotplug;
> >  };
> >  
> > +/**
> > + * define DRM_FB_HELPER_DEFAULT_OPS - helper define for drm drivers
> 
> If I'm not mistaken v1 of this patch is already in drm-misc so you may
> want to send a patch that fix just the line above.

Yup, I need an incremental patch which applies on top of drm-misc or
linux-next. Sorry if this wasn't clear.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/fb-helper: fix sphinx markup for DRM_FB_HELPER_DEFAULT_OPS

[Stefan Christ]

Fix invalid sphinx markup in the comment for the newly added
DRM_FB_HELPER_DEFAULT_OPS.

Signed-off-by: Stefan Christ <contact@stefanchrist.eu>
---
Hi, 

> > If I'm not mistaken v1 of this patch is already in drm-misc so you may
> > want to send a patch that fix just the line above.
> 
> Yup, I need an incremental patch which applies on top of drm-misc or
> linux-next. Sorry if this wasn't clear.
> -Daniel

Thanks for the head-ups. Here is a fix patch for it. Actually I should have
come up with the same idea myself seeing the patch queued for the next pull
request.

I have not added a "Fixes:" trailer in the commit message. If this is necessary
I can resend it, when I see the offending patch in Linus master tree with a
commit id.

Kind regards,
	Stefan Christ
---
 include/drm/drm_fb_helper.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index 3c5f599..ed8edfe 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -218,7 +218,7 @@ struct drm_fb_helper {
 };
 
 /**
- * @DRM_FB_HELPER_DEFAULT_OPS:
+ * define DRM_FB_HELPER_DEFAULT_OPS - helper define for drm drivers
  *
  * Helper define to register default implementations of drm_fb_helper
  * functions. To be used in struct fb_ops of drm drivers.
-- 
2.1.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/fb-helper: fix sphinx markup for DRM_FB_HELPER_DEFAULT_OPS

[Daniel Vetter]

On Wed, Oct 05, 2016 at 08:34:14PM +0200, Stefan Christ wrote:
> Fix invalid sphinx markup in the comment for the newly added
> DRM_FB_HELPER_DEFAULT_OPS.
> 
> Signed-off-by: Stefan Christ <contact@stefanchrist.eu>
> ---
> Hi, 
> 
> > > If I'm not mistaken v1 of this patch is already in drm-misc so you may
> > > want to send a patch that fix just the line above.
> > 
> > Yup, I need an incremental patch which applies on top of drm-misc or
> > linux-next. Sorry if this wasn't clear.
> > -Daniel
> 
> Thanks for the head-ups. Here is a fix patch for it. Actually I should have
> come up with the same idea myself seeing the patch queued for the next pull
> request.
> 
> I have not added a "Fixes:" trailer in the commit message. If this is necessary
> I can resend it, when I see the offending patch in Linus master tree with a
> commit id.

drm-misc has stable sha1, which means you can cite them already when they
show up in linux-next. But for a minor fix like this no big deal really.

Applied to drm-misc, thanks.
-Daniel

> 
> Kind regards,
> 	Stefan Christ
> ---
>  include/drm/drm_fb_helper.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index 3c5f599..ed8edfe 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -218,7 +218,7 @@ struct drm_fb_helper {
>  };
>  
>  /**
> - * @DRM_FB_HELPER_DEFAULT_OPS:
> + * define DRM_FB_HELPER_DEFAULT_OPS - helper define for drm drivers
>   *
>   * Helper define to register default implementations of drm_fb_helper
>   * functions. To be used in struct fb_ops of drm drivers.
> -- 
> 2.1.4
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel