All of lore.kernel.org
 help / color / mirror / Atom feed
From: balbi@kernel.org (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value
Date: Mon, 28 Mar 2016 11:30:11 +0300	[thread overview]
Message-ID: <87d1qf80oc.fsf@ti.com> (raw)
In-Reply-To: <SG2PR06MB09190267848198365A7783A3D8860@SG2PR06MB0919.apcprd06.prod.outlook.com>


Hi,

Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes:
>> > ps: there might be bugs there, but it's a holiday and I really shouldn't
>> > be spending time on this right now ;-)
>> 
>> I'm also off on holiday now until Sunday 10th April... yay :-)
>> >
>> > Anyway, have fun testing. Let me know if it doesn't work.
>> 
>> I only have access to STi platforms which were broken by this change.
>> Not any of the platforms which rely on the functionality which
>> was introduced (although I can't see any reason why your patch wouldn't work).
>> 
>> Maybe Yoshihiro (on CC) could test this on the Renesas platforms and confirm?
>
> Thank you for sending the email to me on CC.
>
> I tested Felipe's patch on Renesas platfroms (R-Car Gen2 and Gen3) and
> I fixed the patch like the following.
>
> However, my fixes patch might need to clean the code up more.
>
> Changes from Felipe's patch:
> - Change function names of xhci_rcar_init_quirk() to xhci_rcar_setup_quirk()

I'm not sure renaming that function fits on the same patch ;-) Sounds
like it should be a separate patch altogether. I'll work on this
tomorrow if it's okay for you guys to test on your respective platforms :-)

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160328/a0b9b24b/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Peter Griffin <peter.griffin@linaro.org>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>,
	"linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mathias.nyman\@intel.com" <mathias.nyman@intel.com>,
	"gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"lee.jones\@linaro.org" <lee.jones@linaro.org>,
	"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"maxime.coquelin\@st.com" <maxime.coquelin@st.com>,
	"patrice.chotard\@st.com" <patrice.chotard@st.com>,
	"stable\@vger.kernel.org" <stable@vger.kernel.org>,
	"felipe.balbi\@linux.intel.com" <felipe.balbi@linux.intel.com>
Subject: RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value
Date: Mon, 28 Mar 2016 11:30:11 +0300	[thread overview]
Message-ID: <87d1qf80oc.fsf@ti.com> (raw)
In-Reply-To: <SG2PR06MB09190267848198365A7783A3D8860@SG2PR06MB0919.apcprd06.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]


Hi,

Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes:
>> > ps: there might be bugs there, but it's a holiday and I really shouldn't
>> > be spending time on this right now ;-)
>> 
>> I'm also off on holiday now until Sunday 10th April... yay :-)
>> >
>> > Anyway, have fun testing. Let me know if it doesn't work.
>> 
>> I only have access to STi platforms which were broken by this change.
>> Not any of the platforms which rely on the functionality which
>> was introduced (although I can't see any reason why your patch wouldn't work).
>> 
>> Maybe Yoshihiro (on CC) could test this on the Renesas platforms and confirm?
>
> Thank you for sending the email to me on CC.
>
> I tested Felipe's patch on Renesas platfroms (R-Car Gen2 and Gen3) and
> I fixed the patch like the following.
>
> However, my fixes patch might need to clean the code up more.
>
> Changes from Felipe's patch:
> - Change function names of xhci_rcar_init_quirk() to xhci_rcar_setup_quirk()

I'm not sure renaming that function fits on the same patch ;-) Sounds
like it should be a separate patch altogether. I'll work on this
tomorrow if it's okay for you guys to test on your respective platforms :-)

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

  reply	other threads:[~2016-03-28  8:30 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-25 14:46 [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value Peter Griffin
2016-03-25 14:46 ` Peter Griffin
2016-03-25 16:58 ` Felipe Balbi
2016-03-25 16:58   ` Felipe Balbi
2016-03-25 17:07   ` Gregory CLEMENT
2016-03-25 17:07     ` Gregory CLEMENT
2016-03-25 17:44     ` Felipe Balbi
2016-03-25 17:44       ` Felipe Balbi
2016-03-26  9:10       ` Peter Griffin
2016-03-26  9:10         ` Peter Griffin
2016-03-26 10:10         ` Felipe Balbi
2016-03-26 10:10           ` Felipe Balbi
2016-03-29  9:04           ` Lee Jones
2016-03-29  9:04             ` Lee Jones
2016-03-28  6:55         ` Yoshihiro Shimoda
2016-03-28  6:55           ` Yoshihiro Shimoda
2016-03-28  8:30           ` Felipe Balbi [this message]
2016-03-28  8:30             ` Felipe Balbi
2016-03-28 10:01             ` Yoshihiro Shimoda
2016-03-28 10:01               ` Yoshihiro Shimoda
2016-04-11 15:44 ` Peter Griffin
2016-04-11 15:44   ` Peter Griffin
2016-04-13 17:00   ` Mathias Nyman
2016-04-13 17:00     ` Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1qf80oc.fsf@ti.com \
    --to=balbi@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.