[PATCH] mmc: Report failure reasons for all cases in sdhci_add_host()

[PATCH] mmc: Report failure reasons for all cases in sdhci_add_host()

[Mark Brown]

For most error conditions sdhci_add_host() will print a diagnostic
message indicating why it failed but there are a few cases where this
does not happen. Add error messages in these cases to aid diagnosis.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/mmc/host/sdhci.c |   10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index caba999..acbc420 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -3031,8 +3031,11 @@ int sdhci_add_host(struct sdhci_host *host)
 
 	ret = request_irq(host->irq, sdhci_irq, IRQF_SHARED,
 		mmc_hostname(mmc), host);
-	if (ret)
+	if (ret) {
+		pr_err("%s: Failed to request IRQ %d: %d\n",
+		       mmc_hostname(mmc), host->irq, ret);
 		goto untasklet;
+	}
 
 	sdhci_init(host, 0);
 
@@ -3049,8 +3052,11 @@ int sdhci_add_host(struct sdhci_host *host)
 	host->led.brightness_set = sdhci_led_control;
 
 	ret = led_classdev_register(mmc_dev(mmc), &host->led);
-	if (ret)
+	if (ret) {
+		pr_err("%s: Failed to register LED device: %d\n",
+		       mmc_hostname(mmc), ret);
 		goto reset;
+	}
 #endif
 
 	mmiowb();
-- 
1.7.10

Re: [PATCH] mmc: Report failure reasons for all cases in sdhci_add_host()

[Chris Ball]

Hi,

On Mon, Jul 02 2012, Mark Brown wrote:
> For most error conditions sdhci_add_host() will print a diagnostic
> message indicating why it failed but there are a few cases where this
> does not happen. Add error messages in these cases to aid diagnosis.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  drivers/mmc/host/sdhci.c |   10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index caba999..acbc420 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -3031,8 +3031,11 @@ int sdhci_add_host(struct sdhci_host *host)
>  
>  	ret = request_irq(host->irq, sdhci_irq, IRQF_SHARED,
>  		mmc_hostname(mmc), host);
> -	if (ret)
> +	if (ret) {
> +		pr_err("%s: Failed to request IRQ %d: %d\n",
> +		       mmc_hostname(mmc), host->irq, ret);
>  		goto untasklet;
> +	}
>  
>  	sdhci_init(host, 0);
>  
> @@ -3049,8 +3052,11 @@ int sdhci_add_host(struct sdhci_host *host)
>  	host->led.brightness_set = sdhci_led_control;
>  
>  	ret = led_classdev_register(mmc_dev(mmc), &host->led);
> -	if (ret)
> +	if (ret) {
> +		pr_err("%s: Failed to register LED device: %d\n",
> +		       mmc_hostname(mmc), ret);
>  		goto reset;
> +	}
>  #endif
>  
>  	mmiowb();

Thanks, pushed to mmc-next for 3.6.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child