All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Vladimir Kondratiev <Vladimir.Kondratiev@mobileye.com>,
	Rob Herring <robh@kernel.org>
Cc: Anup Patel <anup@brainfault.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: interrupt-controller: add risc-v,aplic hart indexes
Date: Mon, 27 Jan 2025 18:52:23 +0100	[thread overview]
Message-ID: <87ed0o87qg.ffs@tglx> (raw)
In-Reply-To: <VI1PR09MB2333835FB0314EE32094D55F941E2@VI1PR09MB2333.eurprd09.prod.outlook.com>

On Sun, Jan 12 2025 at 08:38, Vladimir Kondratiev wrote:
>>> Document optional property "riscv,hart-indexes"
>
>>That is obvious reading the diff. Why do you need this?
>
> I say it briefly in the description for the property.
> In more details this is described in the other patch comment
> - for code that uses this property.
> Is it better to repeat more detailed description in this patch
> comment as well?

Obviously. Each patch has to be self contained and explain what it is
about.

Thanks,

        tglx

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Vladimir Kondratiev <Vladimir.Kondratiev@mobileye.com>,
	Rob Herring <robh@kernel.org>
Cc: Anup Patel <anup@brainfault.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: interrupt-controller: add risc-v,aplic hart indexes
Date: Mon, 27 Jan 2025 18:52:23 +0100	[thread overview]
Message-ID: <87ed0o87qg.ffs@tglx> (raw)
In-Reply-To: <VI1PR09MB2333835FB0314EE32094D55F941E2@VI1PR09MB2333.eurprd09.prod.outlook.com>

On Sun, Jan 12 2025 at 08:38, Vladimir Kondratiev wrote:
>>> Document optional property "riscv,hart-indexes"
>
>>That is obvious reading the diff. Why do you need this?
>
> I say it briefly in the description for the property.
> In more details this is described in the other patch comment
> - for code that uses this property.
> Is it better to repeat more detailed description in this patch
> comment as well?

Obviously. Each patch has to be self contained and explain what it is
about.

Thanks,

        tglx

  reply	other threads:[~2025-01-27 17:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-09 11:38 [PATCH v4 0/2] riscv,aplic: support for hart indexes Vladimir Kondratiev
2025-01-09 11:38 ` Vladimir Kondratiev
2025-01-09 11:38 ` [PATCH v4 1/2] dt-bindings: interrupt-controller: add risc-v,aplic " Vladimir Kondratiev
2025-01-09 11:38   ` Vladimir Kondratiev
2025-01-10 16:20   ` Rob Herring
2025-01-10 16:20     ` Rob Herring
2025-01-12  7:47     ` Vladimir Kondratiev
2025-01-12  7:47       ` Vladimir Kondratiev
2025-01-10 16:22   ` Rob Herring
2025-01-10 16:22     ` Rob Herring
2025-01-12  8:38     ` Vladimir Kondratiev
2025-01-12  8:38       ` Vladimir Kondratiev
2025-01-27 17:52       ` Thomas Gleixner [this message]
2025-01-27 17:52         ` Thomas Gleixner
2025-01-29  9:16         ` [PATCH v5 0/2] riscv,aplic: support for " Vladimir Kondratiev
2025-01-29  9:16           ` Vladimir Kondratiev
2025-01-29  9:16           ` [PATCH v5 1/2] dt-bindings: interrupt-controller: add risc-v,aplic " Vladimir Kondratiev
2025-01-29  9:16             ` Vladimir Kondratiev
2025-01-29 16:40             ` Rob Herring (Arm)
2025-01-29 16:40               ` Rob Herring (Arm)
2025-02-03 13:37             ` [tip: irq/core] dt-bindings: interrupt-controller: Add " tip-bot2 for Vladimir Kondratiev
2025-01-29  9:16           ` [PATCH v5 2/2] irqchip/riscv-aplic: add support for " Vladimir Kondratiev
2025-01-29  9:16             ` Vladimir Kondratiev
2025-02-03 13:37             ` [tip: irq/core] irqchip/riscv-aplic: Add " tip-bot2 for Vladimir Kondratiev
2025-01-09 11:38 ` [PATCH v4 2/2] irqchip/riscv-aplic: add " Vladimir Kondratiev
2025-01-09 11:38   ` Vladimir Kondratiev
2025-01-20  9:57 ` [PATCH v4 0/2] riscv,aplic: " Vladimir Kondratiev
2025-01-20  9:57   ` Vladimir Kondratiev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed0o87qg.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=Vladimir.Kondratiev@mobileye.com \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.