All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: niravkumar.l.rabara@intel.com
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux@treblig.org,  Shen Lichuan <shenlichuan@vivo.com>,
	 Jinjie Ruan <ruanjinjie@huawei.com>,
	u.kleine-koenig@baylibre.com,  linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org,  stable@vger.kernel.org
Subject: Re: [PATCH v2 2/3] mtd: rawnand: cadence: use dma_map_resource for sdma address
Date: Tue, 21 Jan 2025 10:53:26 +0100	[thread overview]
Message-ID: <87ed0wpk6h.fsf@bootlin.com> (raw)
In-Reply-To: <20250116032154.3976447-3-niravkumar.l.rabara@intel.com> (niravkumar l. rabara's message of "Thu, 16 Jan 2025 11:21:53 +0800")

Hello,

On 16/01/2025 at 11:21:53 +08, niravkumar.l.rabara@intel.com wrote:

> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
>
> Map the slave DMA I/O address using dma_map_resource.
> When ARM SMMU is enabled, using a direct physical address of SDMA results
> in DMA transaction failure.

It is in general a better practice anyway. Drivers should be portable
and always remap resources.

> Fixes: ec4ba01e894d ("mtd: rawnand: Add new Cadence NAND driver to MTD subsystem")
> Cc: stable@vger.kernel.org
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: niravkumar.l.rabara@intel.com
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux@treblig.org,  Shen Lichuan <shenlichuan@vivo.com>,
	 Jinjie Ruan <ruanjinjie@huawei.com>,
	u.kleine-koenig@baylibre.com,  linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org,  stable@vger.kernel.org
Subject: Re: [PATCH v2 2/3] mtd: rawnand: cadence: use dma_map_resource for sdma address
Date: Tue, 21 Jan 2025 10:53:26 +0100	[thread overview]
Message-ID: <87ed0wpk6h.fsf@bootlin.com> (raw)
In-Reply-To: <20250116032154.3976447-3-niravkumar.l.rabara@intel.com> (niravkumar l. rabara's message of "Thu, 16 Jan 2025 11:21:53 +0800")

Hello,

On 16/01/2025 at 11:21:53 +08, niravkumar.l.rabara@intel.com wrote:

> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
>
> Map the slave DMA I/O address using dma_map_resource.
> When ARM SMMU is enabled, using a direct physical address of SDMA results
> in DMA transaction failure.

It is in general a better practice anyway. Drivers should be portable
and always remap resources.

> Fixes: ec4ba01e894d ("mtd: rawnand: Add new Cadence NAND driver to MTD subsystem")
> Cc: stable@vger.kernel.org
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>

Thanks,
Miquèl

  reply	other threads:[~2025-01-21  9:53 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16  3:21 [PATCH v2 0/3] mtd: rawnand: cadence: improvement and fixes niravkumar.l.rabara
2025-01-16  3:21 ` niravkumar.l.rabara
2025-01-16  3:21 ` [PATCH v2 1/3] mtd: rawnand: cadence: support deferred prob when DMA is not ready niravkumar.l.rabara
2025-01-16  3:21   ` niravkumar.l.rabara
2025-01-21  9:52   ` Miquel Raynal
2025-01-21  9:52     ` Miquel Raynal
2025-01-29  9:17     ` Rabara, Niravkumar L
2025-01-29  9:17       ` Rabara, Niravkumar L
2025-01-29 10:02       ` Miquel Raynal
2025-01-29 10:02         ` Miquel Raynal
2025-01-30  3:51         ` Rabara, Niravkumar L
2025-01-30  3:51           ` Rabara, Niravkumar L
2025-01-30 15:19           ` Miquel Raynal
2025-01-30 15:19             ` Miquel Raynal
2025-02-04  7:48             ` Rabara, Niravkumar L
2025-02-04  7:48               ` Rabara, Niravkumar L
2025-02-04  9:20               ` Miquel Raynal
2025-02-04  9:20                 ` Miquel Raynal
2025-02-04 10:43                 ` Rabara, Niravkumar L
2025-02-04 10:43                   ` Rabara, Niravkumar L
2025-02-04 13:32                   ` Miquel Raynal
2025-02-04 13:32                     ` Miquel Raynal
2025-02-04 14:11                     ` Rabara, Niravkumar L
2025-02-04 14:11                       ` Rabara, Niravkumar L
2025-02-06 17:01                       ` Miquel Raynal
2025-02-06 17:01                         ` Miquel Raynal
2025-02-07  9:12                         ` Rabara, Niravkumar L
2025-02-07  9:12                           ` Rabara, Niravkumar L
2025-02-07 13:22                           ` Miquel Raynal
2025-02-07 13:22                             ` Miquel Raynal
2025-01-16  3:21 ` [PATCH v2 2/3] mtd: rawnand: cadence: use dma_map_resource for sdma address niravkumar.l.rabara
2025-01-16  3:21   ` niravkumar.l.rabara
2025-01-21  9:53   ` Miquel Raynal [this message]
2025-01-21  9:53     ` Miquel Raynal
2025-01-29  9:02     ` Rabara, Niravkumar L
2025-01-29  9:02       ` Rabara, Niravkumar L
2025-01-29  9:50       ` Miquel Raynal
2025-01-29  9:50         ` Miquel Raynal
2025-01-16  3:21 ` [PATCH v2 3/3] mtd: rawnand: cadence: fix incorrect dev context in dma_unmap_single niravkumar.l.rabara
2025-01-16  3:21   ` niravkumar.l.rabara
2025-01-21  9:54   ` Miquel Raynal
2025-01-21  9:54     ` Miquel Raynal
2025-01-29  8:58     ` Rabara, Niravkumar L
2025-01-29  8:58       ` Rabara, Niravkumar L
2025-01-29  9:48       ` Miquel Raynal
2025-01-29  9:48         ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed0wpk6h.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@treblig.org \
    --cc=niravkumar.l.rabara@intel.com \
    --cc=richard@nod.at \
    --cc=ruanjinjie@huawei.com \
    --cc=shenlichuan@vivo.com \
    --cc=stable@vger.kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.