From: Jani Nikula <jani.nikula@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Pin-yen Lin <treapking@chromium.org>
Cc: "Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Daniel Scally" <djrscally@gmail.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Prashant Malani" <pmalani@chromium.org>,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Xin Ji" <xji@analogixsemi.com>,
linux-kernel@vger.kernel.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
linux-acpi@vger.kernel.org,
"Javier Martinez Canillas" <javierm@redhat.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Hsin-Yi Wang" <hsinyi@chromium.org>,
"Lyude Paul" <lyude@redhat.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Allen Chen" <allen.chen@ite.com.tw>,
dri-devel@lists.freedesktop.org, "Marek Vasut" <marex@denx.de>,
"Stephen Boyd" <swboyd@chromium.org>,
chrome-platform@lists.linux.dev, devicetree@vger.kernel.org,
"Andi Shyti" <andi.shyti@linux.intel.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Douglas Anderson" <dianders@chromium.org>,
"Imre Deak" <imre.deak@intel.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
YueHaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH v14 03/10] drm/display: Add Type-C switch helpers
Date: Wed, 22 Mar 2023 18:27:56 +0200 [thread overview]
Message-ID: <87edpg7nub.fsf@intel.com> (raw)
In-Reply-To: <ZBrgD61p/p17IOJL@smile.fi.intel.com>
On Wed, 22 Mar 2023, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Wed, Mar 22, 2023 at 06:46:32PM +0800, Pin-yen Lin wrote:
>> +#ifdef CONFIG_DRM_DISPLAY_DP_TYPEC_HELPER
>
> Ah, maybe this should use IS_REACHABLE() ?
Personally, I think IS_REACHABLE() is a build-time band-aid solution to
a problem that should be solved in Kconfig. :p
I think it always means there's a configuration combo that shouldn't
exist, and it's a surprise to the user when they've configured
something, Kconfig has deemed it a valid configuration, but they don't
get the feature they want.
As a user, how would they even debug that case? Double check configs,
don't see anything wrong.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Pin-yen Lin <treapking@chromium.org>
Cc: "Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
dri-devel@lists.freedesktop.org,
"Douglas Anderson" <dianders@chromium.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Marek Vasut" <marex@denx.de>,
chrome-platform@lists.linux.dev, "Robert Foss" <rfoss@kernel.org>,
YueHaibing <yuehaibing@huawei.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
linux-acpi@vger.kernel.org,
"Andi Shyti" <andi.shyti@linux.intel.com>,
devicetree@vger.kernel.org,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Allen Chen" <allen.chen@ite.com.tw>,
"Stephen Boyd" <swboyd@chromium.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Hsin-Yi Wang" <hsinyi@chromium.org>,
"Xin Ji" <xji@analogixsemi.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Daniel Scally" <djrscally@gmail.com>,
"Prashant Malani" <pmalani@chromium.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v14 03/10] drm/display: Add Type-C switch helpers
Date: Wed, 22 Mar 2023 18:27:56 +0200 [thread overview]
Message-ID: <87edpg7nub.fsf@intel.com> (raw)
In-Reply-To: <ZBrgD61p/p17IOJL@smile.fi.intel.com>
On Wed, 22 Mar 2023, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Wed, Mar 22, 2023 at 06:46:32PM +0800, Pin-yen Lin wrote:
>> +#ifdef CONFIG_DRM_DISPLAY_DP_TYPEC_HELPER
>
> Ah, maybe this should use IS_REACHABLE() ?
Personally, I think IS_REACHABLE() is a build-time band-aid solution to
a problem that should be solved in Kconfig. :p
I think it always means there's a configuration combo that shouldn't
exist, and it's a surprise to the user when they've configured
something, Kconfig has deemed it a valid configuration, but they don't
get the feature they want.
As a user, how would they even debug that case? Double check configs,
don't see anything wrong.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-03-22 16:28 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 10:46 [PATCH v14 00/10] Register Type-C mode-switch in DP bridge endpoints Pin-yen Lin
2023-03-22 10:46 ` Pin-yen Lin
2023-03-22 10:46 ` [PATCH v14 01/10] device property: Add remote endpoint to devcon matcher Pin-yen Lin
2023-03-22 10:46 ` Pin-yen Lin
2023-03-22 10:46 ` [PATCH v14 02/10] platform/chrome: cros_ec_typec: Purge blocking switch devlinks Pin-yen Lin
2023-03-22 10:46 ` Pin-yen Lin
2023-03-22 12:17 ` AngeloGioacchino Del Regno
2023-03-22 12:17 ` AngeloGioacchino Del Regno
2023-03-22 10:46 ` [PATCH v14 03/10] drm/display: Add Type-C switch helpers Pin-yen Lin
2023-03-22 10:46 ` Pin-yen Lin
2023-03-22 11:01 ` Andy Shevchenko
2023-03-22 11:01 ` Andy Shevchenko
2023-03-22 16:27 ` Jani Nikula [this message]
2023-03-22 16:27 ` Jani Nikula
2023-03-23 12:45 ` Andy Shevchenko
2023-03-23 12:45 ` Andy Shevchenko
2023-03-31 2:36 ` Pin-yen Lin
2023-03-31 2:36 ` Pin-yen Lin
2023-03-31 6:43 ` Pin-yen Lin
2023-03-31 6:43 ` Pin-yen Lin
2023-03-22 22:38 ` Dmitry Baryshkov
2023-03-22 22:38 ` Dmitry Baryshkov
2023-03-23 12:46 ` Andy Shevchenko
2023-03-23 12:46 ` Andy Shevchenko
2023-03-31 2:40 ` Pin-yen Lin
2023-03-31 2:40 ` Pin-yen Lin
2023-03-22 10:46 ` [PATCH v14 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support Pin-yen Lin
2023-03-22 10:46 ` Pin-yen Lin
2023-03-22 10:46 ` [PATCH v14 05/10] drm/bridge: anx7625: Check for Type-C during panel registration Pin-yen Lin
2023-03-22 10:46 ` Pin-yen Lin
2023-03-22 12:17 ` AngeloGioacchino Del Regno
2023-03-22 12:17 ` AngeloGioacchino Del Regno
2023-03-22 10:46 ` [PATCH v14 06/10] drm/bridge: Remove redundant i2c_client in anx7625/it6505 Pin-yen Lin
2023-03-22 10:46 ` Pin-yen Lin
2023-03-22 12:17 ` AngeloGioacchino Del Regno
2023-03-22 12:17 ` AngeloGioacchino Del Regno
2023-03-22 10:46 ` [PATCH v14 07/10] drm/bridge: anx7625: Register Type C mode switches Pin-yen Lin
2023-03-22 10:46 ` Pin-yen Lin
2023-03-22 11:15 ` Andy Shevchenko
2023-03-22 11:15 ` Andy Shevchenko
2023-03-31 8:18 ` Pin-yen Lin
2023-03-31 8:18 ` Pin-yen Lin
2023-03-22 10:46 ` [PATCH v14 08/10] dt-bindings: display: bridge: it6505: Add mode-switch support Pin-yen Lin
2023-03-22 10:46 ` Pin-yen Lin
2023-03-22 10:46 ` [PATCH v14 09/10] drm/bridge: it6505: Fix Kconfig indentation Pin-yen Lin
2023-03-22 10:46 ` Pin-yen Lin
2023-03-22 10:46 ` [PATCH v14 10/10] drm/bridge: it6505: Register Type C mode switches Pin-yen Lin
2023-03-22 10:46 ` Pin-yen Lin
2023-03-22 14:30 ` Andy Shevchenko
2023-03-22 14:30 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edpg7nub.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=allen.chen@ite.com.tw \
--cc=andi.shyti@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=djrscally@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hsinyi@chromium.org \
--cc=imre.deak@intel.com \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=marex@denx.de \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=pmalani@chromium.org \
--cc=rafael@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=swboyd@chromium.org \
--cc=treapking@chromium.org \
--cc=tzimmermann@suse.de \
--cc=xji@analogixsemi.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.