All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: edward-p <edward@edward-p.xyz>
Cc: Stefan Binding <sbinding@opensource.cirrus.com>,
	Kailang Yang <kailang@realtek.com>,
	Lucas Tanure <tanureal@opensource.cirrus.com>,
	Meng Tang <tangmeng@uniontech.com>,
	Philipp Jungkamp <p.jungkamp@gmx.net>,
	Tim Crawford <tcrawford@system76.com>,
	Takashi Iwai <tiwai@suse.com>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Lenovo TianYi510Pro-14IOB
Date: Wed, 07 Dec 2022 13:23:32 +0100	[thread overview]
Message-ID: <87edtb8ksb.wl-tiwai@suse.de> (raw)
In-Reply-To: <20221206180459.44260-1-edward@edward-p.xyz>

On Tue, 06 Dec 2022 19:04:58 +0100,
edward-p wrote:
> 
> Lenovo TianYi510Pro-14IOB (17aa:3742)
> require quirk for enabling headset-mic
> 
> Signed-off-by: edward-p <edward@edward-p.xyz>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216756

The code change looks OK, but the Signed-off-by line has to be with
the real full name.  As it's a legal requirement, it's mandatory.

Could you correct and resubmit?


thanks,

Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: edward-p <edward@edward-p.xyz>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Stefan Binding <sbinding@opensource.cirrus.com>,
	Tim Crawford <tcrawford@system76.com>,
	Meng Tang <tangmeng@uniontech.com>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Lucas Tanure <tanureal@opensource.cirrus.com>,
	Philipp Jungkamp <p.jungkamp@gmx.net>,
	Kailang Yang <kailang@realtek.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Lenovo TianYi510Pro-14IOB
Date: Wed, 07 Dec 2022 13:23:32 +0100	[thread overview]
Message-ID: <87edtb8ksb.wl-tiwai@suse.de> (raw)
In-Reply-To: <20221206180459.44260-1-edward@edward-p.xyz>

On Tue, 06 Dec 2022 19:04:58 +0100,
edward-p wrote:
> 
> Lenovo TianYi510Pro-14IOB (17aa:3742)
> require quirk for enabling headset-mic
> 
> Signed-off-by: edward-p <edward@edward-p.xyz>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216756

The code change looks OK, but the Signed-off-by line has to be with
the real full name.  As it's a legal requirement, it's mandatory.

Could you correct and resubmit?


thanks,

Takashi

  reply	other threads:[~2022-12-07 12:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 18:04 [PATCH] ALSA: hda/realtek: Add quirk for Lenovo TianYi510Pro-14IOB edward-p
2022-12-06 18:04 ` edward-p
2022-12-07 12:23 ` Takashi Iwai [this message]
2022-12-07 12:23   ` Takashi Iwai
2022-12-07 13:32   ` [PATCH v1] " Edward Pacman
2022-12-07 13:32     ` Edward Pacman
2022-12-07 14:05     ` Takashi Iwai
2022-12-07 14:05       ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2022-12-07  3:45 [PATCH] " edward-p

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edtb8ksb.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=edward@edward-p.xyz \
    --cc=kai.heng.feng@canonical.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.jungkamp@gmx.net \
    --cc=sbinding@opensource.cirrus.com \
    --cc=tangmeng@uniontech.com \
    --cc=tanureal@opensource.cirrus.com \
    --cc=tcrawford@system76.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.