[PATCH v2 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

[PATCH v2 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

[David Eccher]

Fix bad unlock balance: ep0_write enter with the locks locked from
inode.c:1769, hence it must exit with spinlock held to avoid double
unlock in dev_config.

Signed-off-by: David Eccher <d.eccher@gmail.com>
---
 drivers/usb/gadget/legacy/inode.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c
index f454c7a..365afd7 100644
--- a/drivers/usb/gadget/legacy/inode.c
+++ b/drivers/usb/gadget/legacy/inode.c
@@ -1137,10 +1137,9 @@ ep0_write (struct file *fd, const char __user *buf, size_t len, loff_t *ptr)
 						dev->gadget->ep0, dev->req,
 						GFP_KERNEL);
 				}
+				spin_lock_irq(&dev->lock);
 				if (retval < 0) {
-					spin_lock_irq (&dev->lock);
 					clean_req (dev->gadget->ep0, dev->req);
-					spin_unlock_irq (&dev->lock);
 				} else
 					retval = len;
 
-- 
1.8.1.2

Re: [PATCH v2 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]


Hi,

David Eccher <d.eccher@gmail.com> writes:
> Fix bad unlock balance: ep0_write enter with the locks locked from
> inode.c:1769, hence it must exit with spinlock held to avoid double
> unlock in dev_config.
>
> Signed-off-by: David Eccher <d.eccher@gmail.com>

which commit is this fixing ? Do we need this backported to stable
kernels ?

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCH v2 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

Felipe Balbi <balbi@ti.com> writes:

> Hi,
>
> David Eccher <d.eccher@gmail.com> writes:
>> Fix bad unlock balance: ep0_write enter with the locks locked from
>> inode.c:1769, hence it must exit with spinlock held to avoid double
>> unlock in dev_config.
>>
>> Signed-off-by: David Eccher <d.eccher@gmail.com>
>
> which commit is this fixing ? Do we need this backported to stable
> kernels ?

oh, this has been like this since before git came to be. Nevermind.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]