From: Kalle Valo <kvalo@qca.qualcomm.com>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 2/2] ath10k: re-config ht_caps when chainmask is modified.
Date: Mon, 24 Nov 2014 12:53:04 +0200 [thread overview]
Message-ID: <87egss7tv3.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <87ioi47vvd.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Mon, 24 Nov 2014 12:09:42 +0200")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
>> @@ -2537,6 +2560,17 @@ static int __ath10k_set_antenna(struct ath10k *ar, u32 tx_ant, u32 rx_ant)
>> ar->cfg_tx_chainmask = tx_ant;
>> ar->cfg_rx_chainmask = rx_ant;
>>
>> + ht_cap = ath10k_get_ht_cap(ar, true);
>> + vht_cap = ath10k_create_vht_cap(ar, true);
>> +
>> + if (ar->phy_capability & WHAL_WLAN_11G_CAPABILITY)
>> + ar->mac.sbands[IEEE80211_BAND_2GHZ].ht_cap = ht_cap;
>> +
>> + if (ar->phy_capability & WHAL_WLAN_11A_CAPABILITY) {
>> + ar->mac.sbands[IEEE80211_BAND_5GHZ].ht_cap = ht_cap;
>> + ar->mac.sbands[IEEE80211_BAND_5GHZ].vht_cap = vht_cap;
>> + }
>
> So this modifies stryct wiphy::bands after we have called
> ieee80211_register_hw(). Is this something which both cfg80211 and
> mac80211 support? I didn't find the documentation mentioning anything
> about this so I got a bit worried.
Johannes mentioned me that this is not supported so I am reluctant to
take these. Unless I'm missing something, of course.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <greearb@candelatech.com>
Cc: <linux-wireless@vger.kernel.org>, <ath10k@lists.infradead.org>
Subject: Re: [PATCH 2/2] ath10k: re-config ht_caps when chainmask is modified.
Date: Mon, 24 Nov 2014 12:53:04 +0200 [thread overview]
Message-ID: <87egss7tv3.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <87ioi47vvd.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Mon, 24 Nov 2014 12:09:42 +0200")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
>> @@ -2537,6 +2560,17 @@ static int __ath10k_set_antenna(struct ath10k *ar, u32 tx_ant, u32 rx_ant)
>> ar->cfg_tx_chainmask = tx_ant;
>> ar->cfg_rx_chainmask = rx_ant;
>>
>> + ht_cap = ath10k_get_ht_cap(ar, true);
>> + vht_cap = ath10k_create_vht_cap(ar, true);
>> +
>> + if (ar->phy_capability & WHAL_WLAN_11G_CAPABILITY)
>> + ar->mac.sbands[IEEE80211_BAND_2GHZ].ht_cap = ht_cap;
>> +
>> + if (ar->phy_capability & WHAL_WLAN_11A_CAPABILITY) {
>> + ar->mac.sbands[IEEE80211_BAND_5GHZ].ht_cap = ht_cap;
>> + ar->mac.sbands[IEEE80211_BAND_5GHZ].vht_cap = vht_cap;
>> + }
>
> So this modifies stryct wiphy::bands after we have called
> ieee80211_register_hw(). Is this something which both cfg80211 and
> mac80211 support? I didn't find the documentation mentioning anything
> about this so I got a bit worried.
Johannes mentioned me that this is not supported so I am reluctant to
take these. Unless I'm missing something, of course.
--
Kalle Valo
next prev parent reply other threads:[~2014-11-24 10:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 16:35 [PATCH 1/2] ath10k: move create-ht-cap methods above set-antenna greearb
2014-09-24 16:35 ` greearb
2014-09-24 16:35 ` [PATCH 2/2] ath10k: re-config ht_caps when chainmask is modified greearb
2014-09-24 16:35 ` greearb
2014-11-24 10:09 ` Kalle Valo
2014-11-24 10:09 ` Kalle Valo
2014-11-24 10:53 ` Kalle Valo [this message]
2014-11-24 10:53 ` Kalle Valo
2014-11-24 18:54 ` Ben Greear
2014-11-24 18:54 ` Ben Greear
2014-11-25 10:18 ` Felix Fietkau
2014-11-25 10:18 ` Felix Fietkau
2014-11-25 8:08 ` [PATCH 1/2] ath10k: move create-ht-cap methods above set-antenna Kalle Valo
2014-11-25 8:08 ` Kalle Valo
2014-11-25 16:22 ` Ben Greear
2014-11-25 16:22 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egss7tv3.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.