All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@linaro.org>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	nm@ti.com, tony@atomide.com
Subject: Re: [PATCH v2 11/18] ARM: OMAP5: PM: Add L2 memory power down support
Date: Wed, 03 Apr 2013 13:58:36 -0700	[thread overview]
Message-ID: <87ehertjpf.fsf@linaro.org> (raw)
In-Reply-To: <1364205910-32392-12-git-send-email-santosh.shilimkar@ti.com> (Santosh Shilimkar's message of "Mon, 25 Mar 2013 15:35:03 +0530")

Santosh Shilimkar <santosh.shilimkar@ti.com> writes:

> When the entire MPUSS cluster is powered down in device off state, L2 cache
> memory looses it's content and hence while targetting such a state,
> l2 cache needs to be flushed to main memory.
>
> Add the necessary low power code support for the same.
>
> Acked-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
>  arch/arm/mach-omap2/omap-secure.h     |    1 +
>  arch/arm/mach-omap2/sleep_omap4plus.S |   21 +++++++++++++++++++++
>  2 files changed, 22 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/omap-secure.h b/arch/arm/mach-omap2/omap-secure.h
> index 1739468..a171a5a 100644
> --- a/arch/arm/mach-omap2/omap-secure.h
> +++ b/arch/arm/mach-omap2/omap-secure.h
> @@ -47,6 +47,7 @@
>  #define OMAP4_MON_L2X0_PREFETCH_INDEX	0x113
>  #define OMAP5_MON_CACHES_CLEAN_INDEX	0x103
>  #define OMAP5_MON_AUX_CTRL_INDEX	0x107
> +#define OMAP5_MON_L2AUX_CTRL_INDEX	0x104

this #define is not used in this patch.

Kevin

>  #define OMAP5_MON_AMBA_IF_INDEX		0x108
>  
> diff --git a/arch/arm/mach-omap2/sleep_omap4plus.S b/arch/arm/mach-omap2/sleep_omap4plus.S
> index 4a5e2e4..288f62f 100644
> --- a/arch/arm/mach-omap2/sleep_omap4plus.S
> +++ b/arch/arm/mach-omap2/sleep_omap4plus.S
> @@ -337,6 +337,7 @@ ENDPROC(omap4_cpu_resume)
>   *	0 - Nothing lost and no need to save: MPUSS INA/CSWR
>   *	1 - CPUx L1 and logic lost: CPU OFF, MPUSS INA/CSWR
>   *	2 - CPUx L1 and logic lost + GIC lost: MPUSS OSWR
> + *	3 - CPUx L1 and logic lost + GIC,L2 lost: MPU OSWR & L2 lost(debug only)
>   */
>  ENTRY(omap5_finish_suspend)
>  	stmfd	sp!, {r4-r12, lr}
> @@ -391,6 +392,26 @@ skip_secure_l1_clean_op:
>  	isb
>  	dsb
>  
> +	bl	omap4_get_sar_ram_base
> +	mov	r8, r0
> +	mrc	p15, 0, r5, c0, c0, 5		@ Read MPIDR
> +	ands	r5, r5, #0x0f
> +	ldreq	r0, [r8, #L2X0_SAVE_OFFSET0]	@ Retrieve L2 state
> +	ldrne	r0, [r8, #L2X0_SAVE_OFFSET1]
> +	cmp	r0, #3
> +	bne	do_wfi
> +	bl	omap4_get_sar_ram_base
> +	ldr	r9, [r0, #OMAP_TYPE_OFFSET]
> +	cmp	r9, #0x1			@ Check for HS device
> +	bne	skip_secure_l2_clean_op
> +	mov	r0, #1				@ Clean secure L2
> +	stmfd   r13!, {r4-r12, r14}
> +	ldr	r12, =OMAP5_MON_CACHES_CLEAN_INDEX
> +	DO_SMC
> +	ldmfd   r13!, {r4-r12, r14}
> +skip_secure_l2_clean_op:
> +	bl	v7_flush_dcache_all
> +
>  do_wfi:
>  	bl	omap_do_wfi

WARNING: multiple messages have this Message-ID (diff)
From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 11/18] ARM: OMAP5: PM: Add L2 memory power down support
Date: Wed, 03 Apr 2013 13:58:36 -0700	[thread overview]
Message-ID: <87ehertjpf.fsf@linaro.org> (raw)
In-Reply-To: <1364205910-32392-12-git-send-email-santosh.shilimkar@ti.com> (Santosh Shilimkar's message of "Mon, 25 Mar 2013 15:35:03 +0530")

Santosh Shilimkar <santosh.shilimkar@ti.com> writes:

> When the entire MPUSS cluster is powered down in device off state, L2 cache
> memory looses it's content and hence while targetting such a state,
> l2 cache needs to be flushed to main memory.
>
> Add the necessary low power code support for the same.
>
> Acked-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
>  arch/arm/mach-omap2/omap-secure.h     |    1 +
>  arch/arm/mach-omap2/sleep_omap4plus.S |   21 +++++++++++++++++++++
>  2 files changed, 22 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/omap-secure.h b/arch/arm/mach-omap2/omap-secure.h
> index 1739468..a171a5a 100644
> --- a/arch/arm/mach-omap2/omap-secure.h
> +++ b/arch/arm/mach-omap2/omap-secure.h
> @@ -47,6 +47,7 @@
>  #define OMAP4_MON_L2X0_PREFETCH_INDEX	0x113
>  #define OMAP5_MON_CACHES_CLEAN_INDEX	0x103
>  #define OMAP5_MON_AUX_CTRL_INDEX	0x107
> +#define OMAP5_MON_L2AUX_CTRL_INDEX	0x104

this #define is not used in this patch.

Kevin

>  #define OMAP5_MON_AMBA_IF_INDEX		0x108
>  
> diff --git a/arch/arm/mach-omap2/sleep_omap4plus.S b/arch/arm/mach-omap2/sleep_omap4plus.S
> index 4a5e2e4..288f62f 100644
> --- a/arch/arm/mach-omap2/sleep_omap4plus.S
> +++ b/arch/arm/mach-omap2/sleep_omap4plus.S
> @@ -337,6 +337,7 @@ ENDPROC(omap4_cpu_resume)
>   *	0 - Nothing lost and no need to save: MPUSS INA/CSWR
>   *	1 - CPUx L1 and logic lost: CPU OFF, MPUSS INA/CSWR
>   *	2 - CPUx L1 and logic lost + GIC lost: MPUSS OSWR
> + *	3 - CPUx L1 and logic lost + GIC,L2 lost: MPU OSWR & L2 lost(debug only)
>   */
>  ENTRY(omap5_finish_suspend)
>  	stmfd	sp!, {r4-r12, lr}
> @@ -391,6 +392,26 @@ skip_secure_l1_clean_op:
>  	isb
>  	dsb
>  
> +	bl	omap4_get_sar_ram_base
> +	mov	r8, r0
> +	mrc	p15, 0, r5, c0, c0, 5		@ Read MPIDR
> +	ands	r5, r5, #0x0f
> +	ldreq	r0, [r8, #L2X0_SAVE_OFFSET0]	@ Retrieve L2 state
> +	ldrne	r0, [r8, #L2X0_SAVE_OFFSET1]
> +	cmp	r0, #3
> +	bne	do_wfi
> +	bl	omap4_get_sar_ram_base
> +	ldr	r9, [r0, #OMAP_TYPE_OFFSET]
> +	cmp	r9, #0x1			@ Check for HS device
> +	bne	skip_secure_l2_clean_op
> +	mov	r0, #1				@ Clean secure L2
> +	stmfd   r13!, {r4-r12, r14}
> +	ldr	r12, =OMAP5_MON_CACHES_CLEAN_INDEX
> +	DO_SMC
> +	ldmfd   r13!, {r4-r12, r14}
> +skip_secure_l2_clean_op:
> +	bl	v7_flush_dcache_all
> +
>  do_wfi:
>  	bl	omap_do_wfi

  reply	other threads:[~2013-04-03 20:58 UTC|newest]

Thread overview: 128+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-25 10:04 [PATCH v2 00/18] ARM: OMAP5: PM: Add MPUSS suspend and CPUidle support Santosh Shilimkar
2013-03-25 10:04 ` Santosh Shilimkar
2013-03-25 10:04 ` [PATCH v2 01/18] ARM: OMAP4+: PM: Consolidate MPU subsystem PM code for re-use Santosh Shilimkar
2013-03-25 10:04   ` Santosh Shilimkar
2013-04-03 19:44   ` Kevin Hilman
2013-04-03 19:44     ` Kevin Hilman
2013-04-04 11:32     ` Santosh Shilimkar
2013-04-04 11:32       ` Santosh Shilimkar
2013-03-25 10:04 ` [PATCH v2 02/18] ARM: OMAP5: PM: Update CPU context register offset Santosh Shilimkar
2013-03-25 10:04   ` Santosh Shilimkar
2013-03-25 10:04 ` [PATCH v2 03/18] ARM: OMAP4+: PM: Consolidate and use OMAP4 PM code for OMAP5 Santosh Shilimkar
2013-03-25 10:04   ` Santosh Shilimkar
2013-04-03 20:20   ` Kevin Hilman
2013-04-03 20:20     ` Kevin Hilman
2013-04-04 11:51     ` Santosh Shilimkar
2013-04-04 11:51       ` Santosh Shilimkar
2013-04-04 11:55       ` Santosh Shilimkar
2013-04-04 11:55         ` Santosh Shilimkar
2013-03-25 10:04 ` [PATCH v2 04/18] ARM: OMAP5: PM: Set MPUSS-EMIF clock-domain static dependency Santosh Shilimkar
2013-03-25 10:04   ` Santosh Shilimkar
2013-03-25 10:04 ` [PATCH v2 05/18] ARM: OMAP5: PM: Enables ES2 PM mode by default Santosh Shilimkar
2013-03-25 10:04   ` Santosh Shilimkar
2013-04-03 20:25   ` Kevin Hilman
2013-04-03 20:25     ` Kevin Hilman
2013-04-04 12:02     ` Santosh Shilimkar
2013-04-04 12:02       ` Santosh Shilimkar
2013-03-25 10:04 ` [PATCH v2 06/18] ARM: OMAP5: PM: Enable Mercury retention mode on CPUx powerdomains Santosh Shilimkar
2013-03-25 10:04   ` Santosh Shilimkar
2013-04-03 20:31   ` Kevin Hilman
2013-04-03 20:31     ` Kevin Hilman
2013-04-04 12:08     ` Santosh Shilimkar
2013-04-04 12:08       ` Santosh Shilimkar
2013-03-25 10:04 ` [PATCH v2 07/18] ARM: OMAP5: Add init_late() hook to enable pm initialization Santosh Shilimkar
2013-03-25 10:04   ` Santosh Shilimkar
2013-04-03 20:33   ` Kevin Hilman
2013-04-03 20:33     ` Kevin Hilman
2013-04-04 12:28     ` Santosh Shilimkar
2013-04-04 12:28       ` Santosh Shilimkar
2013-03-25 10:05 ` [PATCH v2 08/18] ARM: OMAP5: PM: Add CPU power off in hotplug path Santosh Shilimkar
2013-03-25 10:05   ` Santosh Shilimkar
2013-04-03 20:49   ` Kevin Hilman
2013-04-03 20:49     ` Kevin Hilman
2013-04-04 13:23     ` Santosh Shilimkar
2013-04-04 13:23       ` Santosh Shilimkar
2013-04-04 17:31       ` Kevin Hilman
2013-04-04 17:31         ` Kevin Hilman
2013-04-05  9:04         ` Santosh Shilimkar
2013-04-05  9:04           ` Santosh Shilimkar
2013-03-25 10:05 ` [PATCH v2 09/18] ARM: OMAP4+: PM: Restore CPU power state to ON with clockdomain force wakeup method Santosh Shilimkar
2013-03-25 10:05   ` Santosh Shilimkar
2013-04-03 20:54   ` Kevin Hilman
2013-04-03 20:54     ` Kevin Hilman
2013-04-04 13:37     ` Santosh Shilimkar
2013-04-04 13:37       ` Santosh Shilimkar
2013-04-04 17:42       ` Kevin Hilman
2013-04-04 17:42         ` Kevin Hilman
2013-04-05  9:07         ` Santosh Shilimkar
2013-04-05  9:07           ` Santosh Shilimkar
2013-04-05 11:58           ` Santosh Shilimkar
2013-04-05 11:58             ` Santosh Shilimkar
2013-03-25 10:05 ` [PATCH v2 10/18] ARM: OMAP5: PM: Add MPU Open Switch Retention support Santosh Shilimkar
2013-03-25 10:05   ` Santosh Shilimkar
2013-03-25 10:05 ` [PATCH v2 11/18] ARM: OMAP5: PM: Add L2 memory power down support Santosh Shilimkar
2013-03-25 10:05   ` Santosh Shilimkar
2013-04-03 20:58   ` Kevin Hilman [this message]
2013-04-03 20:58     ` Kevin Hilman
2013-04-04 13:46     ` Santosh Shilimkar
2013-04-04 13:46       ` Santosh Shilimkar
2013-03-25 10:05 ` [PATCH v2 12/18] ARM: OMAP4: CPUidle: Avoid double idle driver registration Santosh Shilimkar
2013-03-25 10:05   ` Santosh Shilimkar
2013-04-03 21:03   ` Kevin Hilman
2013-04-03 21:03     ` Kevin Hilman
2013-04-04 13:47     ` Santosh Shilimkar
2013-04-04 13:47       ` Santosh Shilimkar
2013-03-25 10:05 ` [PATCH v2 13/18] ARM: OMAP: CPUidle: Unregister drivere on device registration failure Santosh Shilimkar
2013-03-25 10:05   ` Santosh Shilimkar
2013-04-03 21:03   ` Kevin Hilman
2013-04-03 21:03     ` Kevin Hilman
2013-04-04 13:48     ` Santosh Shilimkar
2013-04-04 13:48       ` Santosh Shilimkar
2013-03-25 10:05 ` [PATCH v2 14/18] ARM: OMAP4: CPUidle: Make C-state description field more precise Santosh Shilimkar
2013-03-25 10:05   ` Santosh Shilimkar
2013-04-03 21:05   ` Kevin Hilman
2013-04-03 21:05     ` Kevin Hilman
2013-04-04 13:48     ` Santosh Shilimkar
2013-04-04 13:48       ` Santosh Shilimkar
2013-03-25 10:05 ` [PATCH v2 15/18] ARM: OMAP4+: CPUidle: Consolidate idle driver for OMAP5 support Santosh Shilimkar
2013-03-25 10:05   ` Santosh Shilimkar
2013-04-03 21:10   ` Kevin Hilman
2013-04-03 21:10     ` Kevin Hilman
2013-04-04 14:04     ` Santosh Shilimkar
2013-04-04 14:04       ` Santosh Shilimkar
2013-03-25 10:05 ` [PATCH v2 16/18] ARM: OMAP4+: CPUidle: Deprecate use of omap4_mpuss_read_prev_context_state() Santosh Shilimkar
2013-03-25 10:05   ` Santosh Shilimkar
2013-04-03 21:37   ` Kevin Hilman
2013-04-03 21:37     ` Kevin Hilman
2013-04-04 13:59     ` Santosh Shilimkar
2013-04-04 13:59       ` Santosh Shilimkar
2013-03-25 10:05 ` [PATCH v2 17/18] ARM: OMAP4+: CPUidle: Add OMAP5 idle driver support Santosh Shilimkar
2013-03-25 10:05   ` Santosh Shilimkar
2013-04-03 21:25   ` Kevin Hilman
2013-04-03 21:25     ` Kevin Hilman
2013-04-04 14:16     ` Santosh Shilimkar
2013-04-04 14:16       ` Santosh Shilimkar
2013-04-04 17:55       ` Kevin Hilman
2013-04-04 17:55         ` Kevin Hilman
2013-04-05  9:41         ` Santosh Shilimkar
2013-04-05  9:41           ` Santosh Shilimkar
2013-03-25 10:05 ` [PATCH v2 18/18] ARM: OMAP5: PM: handle device instance for warm reset Santosh Shilimkar
2013-03-25 10:05   ` Santosh Shilimkar
2013-03-25 11:46 ` [PATCH v2 00/18] ARM: OMAP5: PM: Add MPUSS suspend and CPUidle support Lokesh Vutla
2013-03-25 11:46   ` Lokesh Vutla
2013-03-25 12:10   ` Santosh Shilimkar
2013-03-25 12:10     ` Santosh Shilimkar
2013-03-25 12:27 ` Sourav Poddar
2013-03-25 12:27   ` Sourav Poddar
2013-03-25 12:47   ` Rajendra Nayak
2013-03-25 12:47     ` Rajendra Nayak
2013-03-25 13:00     ` Sourav Poddar
2013-03-25 13:00       ` Sourav Poddar
2013-04-03 22:52 ` Kevin Hilman
2013-04-03 22:52   ` Kevin Hilman
2013-04-04 14:34   ` Santosh Shilimkar
2013-04-04 14:34     ` Santosh Shilimkar
2013-04-04 16:49     ` Santosh Shilimkar
2013-04-04 16:49       ` Santosh Shilimkar
2013-04-04 17:57       ` Kevin Hilman
2013-04-04 17:57         ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ehertjpf.fsf@linaro.org \
    --to=khilman@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.