From: Rusty Russell <rusty@rustcorp.com.au>
Cc: virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] virtio-spec: Define virtio-mmio registers as LE
Date: Fri, 15 Feb 2013 14:27:47 +1030 [thread overview]
Message-ID: <87ehgijkjo.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1360839247-9131-1-git-send-email-pawel.moll@arm.com>
Pawel Moll <pawel.moll@arm.com> writes:
> To solve the never-ending confusions between hosts and guests
> of different endianess, define all virtio-mmio registers as LE.
>
> This change should be safe at this stage, because no known
> working mixed-endian system exists so there is virtually no
> risk of breaking compatibility.
>
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>
Applied. We could also move device configuration space to LE, if we
wanted. It's a bigger change to the Linux implementation, since we now
need accessors for each width, but it might be a good idea. OTOH,
getting such a change into qemu might be harder...
Cheers,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Pawel Moll <pawel.moll@arm.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Marc Zyngier <Marc.Zyngier@arm.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Pawel Moll <pawel.moll@arm.com>
Subject: Re: [PATCH] virtio-spec: Define virtio-mmio registers as LE
Date: Fri, 15 Feb 2013 14:27:47 +1030 [thread overview]
Message-ID: <87ehgijkjo.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1360839247-9131-1-git-send-email-pawel.moll@arm.com>
Pawel Moll <pawel.moll@arm.com> writes:
> To solve the never-ending confusions between hosts and guests
> of different endianess, define all virtio-mmio registers as LE.
>
> This change should be safe at this stage, because no known
> working mixed-endian system exists so there is virtually no
> risk of breaking compatibility.
>
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>
Applied. We could also move device configuration space to LE, if we
wanted. It's a bigger change to the Linux implementation, since we now
need accessors for each width, but it might be a good idea. OTOH,
getting such a change into qemu might be harder...
Cheers,
Rusty.
next prev parent reply other threads:[~2013-02-15 3:57 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 14:25 [RFC PATCH] virt_mmio: fix signature checking for BE guests Marc Zyngier
2013-02-13 14:25 ` Marc Zyngier
2013-02-13 15:08 ` Pawel Moll
2013-02-13 15:08 ` Pawel Moll
2013-02-13 15:28 ` Marc Zyngier
2013-02-13 15:28 ` Marc Zyngier
2013-02-13 15:46 ` Pawel Moll
2013-02-13 15:46 ` Pawel Moll
2013-02-13 16:40 ` Marc Zyngier
2013-02-13 16:40 ` Marc Zyngier
2013-02-13 16:53 ` Michael S. Tsirkin
2013-02-13 16:53 ` Michael S. Tsirkin
2013-02-13 17:04 ` Marc Zyngier
2013-02-13 17:04 ` Marc Zyngier
2013-02-14 0:22 ` Rusty Russell
2013-02-14 0:22 ` Rusty Russell
2013-02-14 10:54 ` [PATCH] virtio-spec: Define virtio-mmio registers as LE Pawel Moll
2013-02-14 10:54 ` Pawel Moll
2013-02-15 3:57 ` Rusty Russell [this message]
2013-02-15 3:57 ` Rusty Russell
2013-03-01 10:41 ` Marc Zyngier
2013-03-01 10:41 ` Marc Zyngier
2013-03-01 10:50 ` Pawel Moll
2013-03-01 10:50 ` Pawel Moll
2013-03-01 11:21 ` Marc Zyngier
2013-03-01 11:21 ` Marc Zyngier
2013-03-01 12:37 ` Pawel Moll
2013-03-01 12:37 ` Pawel Moll
2013-03-01 13:16 ` Marc Zyngier
2013-03-01 13:16 ` Marc Zyngier
2013-03-05 0:11 ` Rusty Russell
2013-03-05 0:11 ` Rusty Russell
2013-03-06 15:10 ` Pawel Moll
2013-03-06 15:10 ` Pawel Moll
2013-03-07 6:36 ` Rusty Russell
2013-03-07 6:36 ` Rusty Russell
2013-02-15 0:07 ` [RFC PATCH] virt_mmio: fix signature checking for BE guests Benjamin Herrenschmidt
2013-02-15 0:07 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehgijkjo.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pawel.moll@arm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.